You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by bostko <gi...@git.apache.org> on 2015/06/23 15:21:37 UTC
[GitHub] incubator-brooklyn pull request: Remove obsolete Tomcat fail bindi...
GitHub user bostko opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/710
Remove obsolete Tomcat fail binding test
Basically the behavior was that it was expecting `LocalhostMachineProvisioningLocation.obtainSpecificPort` to throw an exception "port for httpPort is null" but instead currently it is silent so it causes other exceptions which breaks the test (Freemarker is complaining for missing template value driver.httpPort)
I discussed it with Svet and we decided to delete those.
Please share your thoughts and tell if you think we can add any other relevant tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bostko/incubator-brooklyn tomcat-binding-test
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/710.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #710
----
commit a2660775e987628339bdc14be1c1f06839078981
Author: Valentin Aitken <va...@cloudsoftcorp.com>
Date: 2015-06-23T12:54:54Z
Remove obsolete Tomcat fail binding test
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Remove obsolete Tomcat fail bindi...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/710#issuecomment-114871750
Good to merge. Even when created the test wasn't exercising Tomcat behaviour, but config to attribute convertion + localhost specifics.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Remove obsolete Tomcat fail bindi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/710
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Remove obsolete Tomcat fail bindi...
Posted by mikezaccardo <gi...@git.apache.org>.
Github user mikezaccardo commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/710#issuecomment-114957135
LGTM as well
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---