You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2024/01/27 14:27:03 UTC
[I] support Windows build [incubator-pekko-http]
pjfanning opened a new issue, #446:
URL: https://github.com/apache/incubator-pekko-http/issues/446
Unfortunately, the existing build and tests are based on Linux and this works well for Posix users (Mac, Unix, Linux, etc). Our CI only runs on ubuntu VMs. This can be said of basically all Pekko builds.
Windows users may or may not be able to build this project as is. We have no proof about this. Even if they could build it, some tests might fail.
Unfortunately, CI on Windows VMs can be time consuming to set up and in my experience can often be more brittle.
Windows users do have the choice to use https://en.wikipedia.org/wiki/Windows_Subsystem_for_Linux or to use solutions like dual boot, build VMs on Cloud Providers and Docker Containers.
Supporting Windows would be nice but we probably need Windows users to drive this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] support Windows build [incubator-pekko-http]
Posted by "samueleresca (via GitHub)" <gi...@apache.org>.
samueleresca commented on issue #446:
URL: https://github.com/apache/incubator-pekko-http/issues/446#issuecomment-1913290389
I agree we should proceed with the release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] support Windows build [incubator-pekko-http]
Posted by "samueleresca (via GitHub)" <gi...@apache.org>.
samueleresca commented on issue #446:
URL: https://github.com/apache/incubator-pekko-http/issues/446#issuecomment-1913269746
I'm a Windows 11 user, but I usually dev in a ubuntu instance running on WSL. I tried to clone the project on the Windows host system (not WSL) and give it a go:
- Compilation `sbt compile` is successful.
3 tests are failing:
- `ServerSentEventParserSpec`
- `should parse ServerSentEvents correctly (and emit empty events)`
- `should parse ServerSentEvents correctly (and pass empty events)`
- `FileAndResourceDirectivesSymlinkSpec`
- `should not follow symbolic links to find a file`
I'm trying to see if I can understand the root cause of these failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] support Windows build [incubator-pekko-http]
Posted by "samueleresca (via GitHub)" <gi...@apache.org>.
samueleresca commented on issue #446:
URL: https://github.com/apache/incubator-pekko-http/issues/446#issuecomment-1913290274
The `should not follow symbolic links to find a file` test fails both on `main` and in the `pjfanning:rework-symlink-test` branch for 2 different reasons:
## main
```
[info] - should not follow symbolic links to find a file *** FAILED *** (3 seconds, 21 milliseconds)
[info] java.lang.AssertionError: timeout (3 seconds) waiting for 1 messages on WarningFilter(None,Right(.* points to a location that is not part of .*),false)
[info] at org.apache.pekko.testkit.EventFilter.intercept(TestEventListener.scala:132)
[info] at org.apache.pekko.http.scaladsl.server.directives.FileAndResourceDirectivesSpec.$anonfun$new$41(FileAndResourceDirectivesSpec.scala:214)
```
## rework-symlink-test
```
org.apache.pekko.http.scaladsl.server.directives.FileAndResourceDirectivesSymlinkSpec *** ABORTED *** (59 milliseconds)
[info] java.nio.file.FileSystemException: C:\Users\SAMUEL~1\AppData\Local\Temp\pekko-http-symlink-test8189405977971527262\dirWithLink\linked-dir: A required privilege is not held by the client.
```
The error in `rework-symlink-test` seems requiring some settings change in my system.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] support Windows build [incubator-pekko-http]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on issue #446:
URL: https://github.com/apache/incubator-pekko-http/issues/446#issuecomment-1913276910
thanks @samueleresca with the new FileAndResourceDirectivesSymlinkSpec, do you know if the older copy of the test, (before #445) that was in FileAndResourceDirectivesSpec, passed? In the end of the day. we can probably treat this as something to worry about after the pekko-http 1.0.1 release but we can wait a few days to see if we can make progress on the Windows build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org