You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by GitBox <gi...@apache.org> on 2022/07/28 00:53:54 UTC
[GitHub] [jena] jamiefeiss opened a new pull request, #1459: JENA-2282: Fuseki2 Query Store
jamiefeiss opened a new pull request, #1459:
URL: https://github.com/apache/jena/pull/1459
Jira issue: https://issues.apache.org/jira/browse/JENA-2282
Pull request Description:
An initial implementation of a query library for the Fuseki2 Vue UI using Vuex. Adds two buttons to the dataset query page for saving & loading queries. From there, users can save queries to a query library that persists in local storage in the browser.
----
- [ ] Tests are included.
- [ ] Documentation change and updates are provided for the [Apache Jena website](https://github.com/apache/jena-site/)
- [ ] Commits have been squashed to remove intermediate development commit messages.
- [ ] Key commit messages start with the issue number (GH-xxxx or JENA-xxxx)
By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the [Contributor's Agreement](https://www.apache.org/licenses/contributor-agreements.html).
----
See the [Apache Jena "Contributing" guide](https://github.com/apache/jena/blob/main/CONTRIBUTING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] jamiefeiss commented on pull request #1459: JENA-2282: Fuseki2 Query Store
Posted by GitBox <gi...@apache.org>.
jamiefeiss commented on PR #1459:
URL: https://github.com/apache/jena/pull/1459#issuecomment-1203420959
Thanks @afs & @kinow.
I'm fine with waiting for the other PR first. Once the other PR is done, I'll get this PR up to date with main, update my code to use Bootstrap 5 and write some tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
Re: [PR] JENA-2282: Fuseki2 Query Store [jena]
Posted by "ThomasThelen (via GitHub)" <gi...@apache.org>.
ThomasThelen commented on PR #1459:
URL: https://github.com/apache/jena/pull/1459#issuecomment-5246348041
I'm looking at this issue having since reflected on the prefix service fuseki-ui work. In addition to storing the queries on local storage, what if we created a new query service for users with rw permissions to persist the queries across the repository? This would bring a model similar to GraphDB where there's local "scratch" queries and also global repository level queries.
Users with rw access would be able to write and create new queries, while read only users wouldn't be able to persist their queries beyond local storage.
I think the changes in this PR would still be relevant because would form the backbone for the local storage cache feature. If there's still interest in this pull request I can try resolving the merge conflicts in this branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
Re: [PR] JENA-2282: Fuseki2 Query Store [jena]
Posted by "kinow (via GitHub)" <gi...@apache.org>.
kinow commented on PR #1459:
URL: https://github.com/apache/jena/pull/1459#issuecomment-5251358554
That sounds like a good plan, @ThomasThelen . Probably the hardest here would be to implement this service (in a secure, and optimal way). The UI shouldn't be too difficult, but it'd be great to have a few persisted queries as a user :) thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
Re: [PR] JENA-2282: Fuseki2 Query Store [jena]
Posted by "ThomasThelen (via GitHub)" <gi...@apache.org>.
ThomasThelen commented on PR #1459:
URL: https://github.com/apache/jena/pull/1459#issuecomment-5381394150
> I'm not keen on using the server for storage because it overloads what "RW" access means.
>
> It feels like the tip of collaborative development which is something bigger and collaborative development might be between users with only "R" permission on a dataset.
I appreciate the insight on an area I'm definitely murky in, certainly the semantics of RW. I'll read around a little more and try to fill that knowledge gap.
In the meantime, what do you think the best route is for unsticking this pull request? If @jamiefeiss is up to it, I can fork their branch, merge with upstream and PR into their branch, and show a demo video here after
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
Re: [PR] JENA-2282: Fuseki2 Query Store [jena]
Posted by "kinow (via GitHub)" <gi...@apache.org>.
kinow commented on PR #1459:
URL: https://github.com/apache/jena/pull/1459#issuecomment-2408569337
> You mentioned above (in 2022!) that you might "convert it and finish testing this new feature", could you still do that?
Sorry the delay. I think there are no other pressing issues for Jena UI, so perfect time to get this one sorted out and merged. I can review the conflicts and push a separate commit with the conflict fixes and test it and maybe write tests if pending (or provide a skeleton if it's too complex to test). Then you can review my commit and we squash it later if the changes look good to you. Or if you prefer to fix the conflicts, that's fine by me too. I'll be overseas for 1 week, but have one week per month now to work on Jena (3 in Dec/Jan :grimacing: :tada: ), so quite sure we can get this reviewed/merged in one of these weeks/months.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] kinow commented on pull request #1459: JENA-2282: Fuseki2 Query Store
Posted by GitBox <gi...@apache.org>.
kinow commented on PR #1459:
URL: https://github.com/apache/jena/pull/1459#issuecomment-1202296173
>@kinow what order of PRs should we work with?
If @jamiefeiss doesn't mind, I think it'd be easier to get the #1307 in first, as that one also adds the e2e tests. Later, if needed, I can help converting this PR from Bootstrap 4 to Bootstrap 5, and help with e2e tests as well. I haven't reviewed the code yet, but if it changes the Query editor we can add some tests first to `main`, and then confirm this change doesn't add any regression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on pull request #1459: JENA-2282: Fuseki2 Query Store
Posted by GitBox <gi...@apache.org>.
afs commented on PR #1459:
URL: https://github.com/apache/jena/pull/1459#issuecomment-1216911664
#1307 has merged.
I'd like to get a Jena release because it has been slipping for multiple reasons, none due to any UI work.
There are several PRs queued and we can't wait for them to complete because while that happens, others appear!
So I'll wait a few days then release what is ready at the time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
Re: [PR] JENA-2282: Fuseki2 Query Store [jena]
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on PR #1459:
URL: https://github.com/apache/jena/pull/1459#issuecomment-5359980160
I'm not keen on using the server for storage because it overloads what "RW" access means.
It feels like the tip of collaborative development which is something bigger and collaborative development might be between users with only "R" permission on a dataset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on pull request #1459: JENA-2282: Fuseki2 Query Store
Posted by GitBox <gi...@apache.org>.
afs commented on PR #1459:
URL: https://github.com/apache/jena/pull/1459#issuecomment-1299173210
The Vue 3 work (issue #1306 PR #1480) has been completed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
Re: [PR] JENA-2282: Fuseki2 Query Store [jena]
Posted by "nicholascar (via GitHub)" <gi...@apache.org>.
nicholascar commented on PR #1459:
URL: https://github.com/apache/jena/pull/1459#issuecomment-2337612614
@kinow does this PR need anything other than the obvious merge conflict to progress? You mentioned above (in 2022!) that you might "convert it and finish testing this new feature", could you still do that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on pull request #1459: JENA-2282: Fuseki2 Query Store
Posted by GitBox <gi...@apache.org>.
afs commented on PR #1459:
URL: https://github.com/apache/jena/pull/1459#issuecomment-1197894794
Hi @jamiefeiss!
Great to see this!
It is showing as having a conflict with the main branch of the codebase. There is major maintenance PR #1307and we've made some version upgrades due to a security alert.
Your PR branch is showing as 77 commits behind main so it looks (please confirm) that it is just behind on main and isn't a PR relative to the Vue upgrade work.
@kinow what order of PRs should we work with?
We're approaching a release (early August?) - I'm neutral as to whether this goes in before or after. Mostly, Jena releases are done on a regular tick, and not feature driven. Features take the time they take!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] kinow commented on pull request #1459: JENA-2282: Fuseki2 Query Store
Posted by GitBox <gi...@apache.org>.
kinow commented on PR #1459:
URL: https://github.com/apache/jena/pull/1459#issuecomment-1299542759
Happy to help with the conflicts if needed 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] kinow commented on a diff in pull request #1459: JENA-2282: Fuseki2 Query Store
Posted by GitBox <gi...@apache.org>.
kinow commented on code in PR #1459:
URL: https://github.com/apache/jena/pull/1459#discussion_r1038870792
##########
jena-fuseki2/jena-fuseki-ui/src/store/index.js:
##########
@@ -0,0 +1,13 @@
+import { createStore } from 'vuex'
+import VuexPersistence from 'vuex-persist'
+import { queryLibraryStore } from './queryLibraryStore'
+
+export default createStore({
Review Comment:
Used `createStore` (Vuex 4.x + Vue 3)
##########
jena-fuseki2/jena-fuseki-ui/src/main.js:
##########
@@ -18,12 +18,14 @@
import { createApp, h } from 'vue'
import App from './App.vue'
import router from './router'
+import store from './store'
import 'bootstrap/dist/js/bootstrap.bundle.min'
import { FusekiServicePlugin, ToastPlugin } from '@/plugins/index'
const app = createApp(App)
app.use(router)
+app.use(store)
Review Comment:
https://vuex.vuejs.org/guide/#the-simplest-store
##########
jena-fuseki2/jena-fuseki-ui/package.json:
##########
@@ -30,9 +30,12 @@
"follow-redirects": "^1.15.2",
"mitt": "^3.0.0",
"nanoid": "^4.0.0",
+ "uuid": "^3.4.0",
"vue": "^3.2.39",
"vue-router": "^4.1.5",
- "vue-upload-component": "^3.1.2"
+ "vue-upload-component": "^3.1.2",
+ "vuex": "^4.1.0",
Review Comment:
Updated the version of Vuex as we are using Vue 3 now too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
Re: [PR] JENA-2282: Fuseki2 Query Store [jena]
Posted by "ThomasThelen (via GitHub)" <gi...@apache.org>.
ThomasThelen commented on PR #1459:
URL: https://github.com/apache/jena/pull/1459#issuecomment-5259793898
@OyvindLGjesdal - would you be up for a bit of a partnership on this one? I see you're an active committer and it could be fun to do some work together. You have more experience with the codebase and from @kinow, it sounds like there are some blind spots that I'll have when implementing the service portion. I think an ideal pairup would be you building the store and I hook it up in fuseki-ui.
Then again, I'd be passing the more difficult portion to you. If you're currently busy though, no worries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org