[GitHub] [iceberg] snazy commented on a change in pull request #4210: Infra - Trigger CI using on pull_request, saving push for master branch only

[GitBox <gi...@apache.org>]

snazy commented on a change in pull request #4210:
URL: https://github.com/apache/iceberg/pull/4210#discussion_r814642358



##########
File path: .github/workflows/flink-ci.yml
##########
@@ -20,25 +20,8 @@
 name: "Flink CI"
 on:
   push:
-    paths-ignore:
-    - '.github/workflows/python-ci.yml'
-    - '.github/workflows/spark-ci.yml'
-    - '.github/workflows/hive-ci.yml'
-    - '.github/workflows/cancel-duplicate-workflow-runs.yml'
-    - '.gitignore'
-    - 'dev/**'
-    - 'mr/**'
-    - 'hive3/**'
-    - 'hive3-orc-bundle/**'
-    - 'hive-runtime/**'
-    - 'spark/**'
-    - 'pig/**'
-    - 'python/**'
-    - 'python_legacy/**'
-    - 'docs/**'
-    - '.gitattributes'
-    - 'README.md'
-    - 'CONTRIBUTING.md'
+    branches:
+    - 'master'

Review comment:
       I suspect that adding
   ```
       - '*.x'
   ```
   could work to have CI run on release branches. If it might make sense to move to a different naming pattern for release branches (like `release-x.y.z`).
   

##########
File path: .github/workflows/flink-ci.yml
##########
@@ -20,25 +20,8 @@
 name: "Flink CI"
 on:
   push:
-    paths-ignore:
-    - '.github/workflows/python-ci.yml'
-    - '.github/workflows/spark-ci.yml'
-    - '.github/workflows/hive-ci.yml'
-    - '.github/workflows/cancel-duplicate-workflow-runs.yml'
-    - '.gitignore'
-    - 'dev/**'
-    - 'mr/**'
-    - 'hive3/**'
-    - 'hive3-orc-bundle/**'
-    - 'hive-runtime/**'
-    - 'spark/**'
-    - 'pig/**'
-    - 'python/**'
-    - 'python_legacy/**'
-    - 'docs/**'
-    - '.gitattributes'
-    - 'README.md'
-    - 'CONTRIBUTING.md'
+    branches:

Review comment:
       Adding this should work for tags, but I that's not necessary when CI's run on release branches as well and the tag is on a release branch.
   ```
     tags:
     - 'apache-iceberg-*'
   ```

##########
File path: .github/workflows/flink-ci.yml
##########
@@ -19,27 +19,13 @@
 
 name: "Flink CI"
 on:
-  push:

Review comment:
       For master/release-branch builds that makes sense to me.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org