You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@velocity.apache.org by "Nathan Bubna (JIRA)" <ve...@apache.org> on 2006/11/16 00:02:39 UTC
[jira] Resolved: (VELTOOLS-69) ValueParserSub generic getter never
worked
[ http://issues.apache.org/jira/browse/VELTOOLS-69?page=all ]
Nathan Bubna resolved VELTOOLS-69.
----------------------------------
Fix Version/s: 1.3
Resolution: Fixed
Ok, the sub is gone as of revision 475480.
> ValueParserSub generic getter never worked
> ------------------------------------------
>
> Key: VELTOOLS-69
> URL: http://issues.apache.org/jira/browse/VELTOOLS-69
> Project: VelocityTools
> Issue Type: Bug
> Components: VelocityView
> Affects Versions: 1.3
> Reporter: Claude Brisson
> Fix For: 1.3
>
> Attachments: valueparser.patch
>
>
> (I attach this issue to the VelocityView component but we may need a Generic component in Jira)
> When $query is the ValueParser object for the query string http://...?foo=5,
> then $query.foo.int is an invalid reference.
> Why? Because there is a collision of variable names in ValueParserSub.get(Object key).
> I profit of this opportunity to state that I really don't like the ValueParserSub class, because it breaks the "#if($query.foo)" syntax. Hence, it is not backward compatible. Or at least, it could return null for an unexistant key.
> Is it really usefull to keep it now that Velocity handles conversions much better? Since obviously nobody used the $query.foo.int feature, it is still time to remove it... Also, since the need to convert between types can emerge elsewhere, it would be much cleaner to have a standalone converter object. Yes, we loose the syntax $query.foo.int, but is it that nice a syntax?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org