You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Anthony Baker <ab...@apache.org> on 2016/09/20 22:44:20 UTC
Review Request 52101: GEODE-1791: Update LICENSE
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52101/
-----------------------------------------------------------
Review request for geode, Jens Deppe and Joey McAllister.
Repository: geode
Description
-------
Edit LICENSE files to add jQuery version, MooTools, and sizzle.js.
GEODE-1791: update mbean src headers
Add src header for mbeans-descriptors.dtd and mbeans-descriptors.xml.
The dtd is from an ASF project and the xml file is specific for
geode--both of these require the standard ASF source header.
Diffs
-----
LICENSE 8109496d46f62cadfcf9159bf1f82a3b4cc3d3be
geode-assembly/src/main/dist/LICENSE 375521ee29599898bc3a3434adffa6e8d2ea651f
geode-core/src/main/resources/org/apache/geode/admin/jmx/internal/doc-files/mbeans-descriptors.dtd 2a8b7b4fae8890769eea22156c234d899f7b2809
geode-core/src/main/resources/org/apache/geode/admin/jmx/mbeans-descriptors.xml 24086419319dd41f5daaf9db3f6c027b117e131d
gradle/rat.gradle fc1ef40beb329681326c080430265ff9af5b2dc6
Diff: https://reviews.apache.org/r/52101/diff/
Testing
-------
Thanks,
Anthony Baker
Re: Review Request 52101: GEODE-1791: Update LICENSE
Posted by Joey McAllister <jm...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52101/#review149751
-----------------------------------------------------------
LICENSE (line 330)
<https://reviews.apache.org/r/52101/#comment217436>
v1.8.0
LICENSE (line 364)
<https://reviews.apache.org/r/52101/#comment217438>
Add comma to "(http://sizzlejs.com/), Copyright"
geode-assembly/src/main/dist/LICENSE (line 676)
<https://reviews.apache.org/r/52101/#comment217439>
v1.8.0
geode-assembly/src/main/dist/LICENSE (line 711)
<https://reviews.apache.org/r/52101/#comment217440>
Add comma to "(http://sizzlejs.com/), Copyright"
Fix, then ship \U0001f44d
- Joey McAllister
On Sept. 20, 2016, 10:44 p.m., Anthony Baker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52101/
> -----------------------------------------------------------
>
> (Updated Sept. 20, 2016, 10:44 p.m.)
>
>
> Review request for geode, Jens Deppe and Joey McAllister.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Edit LICENSE files to add jQuery version, MooTools, and sizzle.js.
>
> GEODE-1791: update mbean src headers
>
> Add src header for mbeans-descriptors.dtd and mbeans-descriptors.xml.
> The dtd is from an ASF project and the xml file is specific for
> geode--both of these require the standard ASF source header.
>
>
> Diffs
> -----
>
> LICENSE 8109496d46f62cadfcf9159bf1f82a3b4cc3d3be
> geode-assembly/src/main/dist/LICENSE 375521ee29599898bc3a3434adffa6e8d2ea651f
> geode-core/src/main/resources/org/apache/geode/admin/jmx/internal/doc-files/mbeans-descriptors.dtd 2a8b7b4fae8890769eea22156c234d899f7b2809
> geode-core/src/main/resources/org/apache/geode/admin/jmx/mbeans-descriptors.xml 24086419319dd41f5daaf9db3f6c027b117e131d
> gradle/rat.gradle fc1ef40beb329681326c080430265ff9af5b2dc6
>
> Diff: https://reviews.apache.org/r/52101/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anthony Baker
>
>
Re: Review Request 52101: GEODE-1791: Update LICENSE
Posted by Jinmei Liao <ji...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52101/#review149750
-----------------------------------------------------------
Ship it!
Ship It!
- Jinmei Liao
On Sept. 20, 2016, 10:44 p.m., Anthony Baker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52101/
> -----------------------------------------------------------
>
> (Updated Sept. 20, 2016, 10:44 p.m.)
>
>
> Review request for geode, Jens Deppe and Joey McAllister.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Edit LICENSE files to add jQuery version, MooTools, and sizzle.js.
>
> GEODE-1791: update mbean src headers
>
> Add src header for mbeans-descriptors.dtd and mbeans-descriptors.xml.
> The dtd is from an ASF project and the xml file is specific for
> geode--both of these require the standard ASF source header.
>
>
> Diffs
> -----
>
> LICENSE 8109496d46f62cadfcf9159bf1f82a3b4cc3d3be
> geode-assembly/src/main/dist/LICENSE 375521ee29599898bc3a3434adffa6e8d2ea651f
> geode-core/src/main/resources/org/apache/geode/admin/jmx/internal/doc-files/mbeans-descriptors.dtd 2a8b7b4fae8890769eea22156c234d899f7b2809
> geode-core/src/main/resources/org/apache/geode/admin/jmx/mbeans-descriptors.xml 24086419319dd41f5daaf9db3f6c027b117e131d
> gradle/rat.gradle fc1ef40beb329681326c080430265ff9af5b2dc6
>
> Diff: https://reviews.apache.org/r/52101/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anthony Baker
>
>