[GitHub] [kafka] chia7712 commented on a change in pull request #8530: KAFKA-9388: Refactor integration tests to always use different application ids

[GitBox <gi...@apache.org>]

chia7712 commented on a change in pull request #8530:
URL: https://github.com/apache/kafka/pull/8530#discussion_r412959693



##########
File path: streams/src/test/java/org/apache/kafka/streams/integration/RestoreIntegrationTest.java
##########
@@ -119,7 +124,7 @@ public void shouldRestoreStateFromSourceTopic() throws Exception {
         final AtomicInteger numReceived = new AtomicInteger(0);
         final StreamsBuilder builder = new StreamsBuilder();
 
-        final Properties props = props(APPID);
+        final Properties props = props(APPID + name.getMethodName());

Review comment:
       the following app id should be changed as well. (I can't add comment to the line for this PR)
   ```scala
       private void setCommittedOffset(final String topic, final int limitDelta) {
           final Properties consumerConfig = new Properties();	        final Properties consumerConfig = new Properties();
           consumerConfig.put(ConsumerConfig.BOOTSTRAP_SERVERS_CONFIG, CLUSTER.bootstrapServers());	        consumerConfig.put(ConsumerConfig.BOOTSTRAP_SERVERS_CONFIG, CLUSTER.bootstrapServers());
           consumerConfig.put(ConsumerConfig.GROUP_ID_CONFIG, APPID);	        consumerConfig.put(ConsumerConfig.GROUP_ID_CONFIG, APPID);
   ```

##########
File path: streams/src/test/java/org/apache/kafka/streams/integration/RestoreIntegrationTest.java
##########
@@ -107,6 +109,9 @@ private Properties props(final String applicationId) {
         return streamsConfiguration;
     }
 
+    @Rule
+    public TestName name = new TestName();

Review comment:
       the changelog topics are created by ```BeforeClass``` so it seems we need to add ```Before``` to create changelog for different *method name*.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org