You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/17 00:36:52 UTC

[GitHub] [spark] zero323 commented on a change in pull request #34926: [SPARK-37669][PYTHON] Remove unnecessary usages of OrderedDict

zero323 commented on a change in pull request #34926:
URL: https://github.com/apache/spark/pull/34926#discussion_r771014700



##########
File path: python/pyspark/pandas/frame.py
##########
@@ -9651,7 +9651,7 @@ def stack(self) -> DataFrameOrSeries:
                 ).with_filter(SF.lit(False))
             )
 
-        column_labels: Union[defaultdict, OrderedDict] = defaultdict(dict)
+        column_labels: Dict[Label, Dict[Any, Column]] = defaultdict(dict)

Review comment:
       Should we use [`DefaultDict`](https://docs.python.org/3/library/typing.html#typing.DefaultDict) here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org