You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "David Smiley (JIRA)" <ji...@apache.org> on 2019/07/09 03:56:00 UTC
[jira] [Updated] (LUCENE-8883) CHANGES.txt: Auto add issue
categories on new releases
[ https://issues.apache.org/jira/browse/LUCENE-8883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Smiley updated LUCENE-8883:
---------------------------------
Attachment: LUCENE-8883.patch
Status: Open (was: Open)
Here's the patch. Note I have never written Python code before so it'd be helpful if someone who has might eyeball these changes. I think the changes were simple enough and there was enough existing Python code here for me to learn from that I did it right. I did run the changes and saw it work as I intended.
All the patch does is add the names of the headers with a blank line in-between. I did not add a "------" line below each; I see Lucene hasn't been doing this but Solr has, and I like Lucene's approach better just barely. Also I didn't add "(No changes)"; seems needless / self-evident. I could have added an "Upgrade Notes" section but opted not to... I think this won't be as much of an issue but I could easily go either way.
Alexandre: Are you proposing additional python scripts to basically do all CHANGES.txt manipulation? I'm not sure what to think of that... I'm lukewarm I guess.
> CHANGES.txt: Auto add issue categories on new releases
> ------------------------------------------------------
>
> Key: LUCENE-8883
> URL: https://issues.apache.org/jira/browse/LUCENE-8883
> Project: Lucene - Core
> Issue Type: Task
> Components: general/build
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Minor
> Attachments: LUCENE-8883.patch
>
>
> As I write this, looking at Solr's CHANGES.txt for 8.2 I see we have some sections: "Upgrade Notes", "New Features", "Bug Fixes", and "Other Changes". There is no "Improvements".... so no surprise here, the New Features category has issues that ought to be listed as such. I think the order vary as well. I propose that on new releases, the initial state of the next release in CHANGES.txt have these sections. They can easily be removed at the upcoming release if there are no such sections, or they could stay as empty. It seems addVersion.py is the code that sets this up and it could be enhanced.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org