You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "roeap (via GitHub)" <gi...@apache.org> on 2023/10/17 19:05:46 UTC
[PR] feat: allow configuring labels on init job [superset]
roeap opened a new pull request, #25681:
URL: https://github.com/apache/superset/pull/25681
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
Allows to configure labels on init-job pods.
At my work we encourage use of Azure Workload identities. These require to set the `azure.workload.identity/use: "true"` label for the federated credential file to get mounted.
With these changes AAD enabled databases can be used requiring no additional credentials
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
Haven't seen any means of testing the helm chart in the repo, but we deployed superset with the current changes, and it worked fine.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: allow configuring labels on init job [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #25681:
URL: https://github.com/apache/superset/pull/25681#issuecomment-2303799502
This one seems to have fallen off the map. Sorry about that. @roeap would you mind rebasing, and bumping the docs again? Hopefully we can finally get this through ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: allow configuring labels on init job [superset]
Posted by "roeap (via GitHub)" <gi...@apache.org>.
roeap commented on PR #25681:
URL: https://github.com/apache/superset/pull/25681#issuecomment-1778508007
Sorry I missed that ... docs are updated now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: allow configuring labels on init job [superset]
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on PR #25681:
URL: https://github.com/apache/superset/pull/25681#issuecomment-2483629238
So sorry about letting this one fall through the cracks 🙁 I'm closing this in favor of #25681 to get this improvement pushed through ASAP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: allow configuring labels on init job [superset]
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro closed pull request #25681: feat: allow configuring labels on init job
URL: https://github.com/apache/superset/pull/25681
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org