You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "epugh (via GitHub)" <gi...@apache.org> on 2025/11/30 23:42:26 UTC

[PR] SOLR-16082: Move internal variable to private to facilitate removing deprecation. [solr]

epugh opened a new pull request, #3911:
URL: https://github.com/apache/solr/pull/3911

   
   
   https://issues.apache.org/jira/browse/SOLR-16082
   
   
   
   # Description
   
   Change visibility of internal variable.
   
   # Solution
   
   Go from protected to private, and add a comment of what to use instead.
   
   # Tests
   
   Reran them.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


Re: [PR] SOLR-16082: Move internal variable to private to facilitate removing deprecation. [solr]

Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh merged PR #3911:
URL: https://github.com/apache/solr/pull/3911


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


Re: [PR] SOLR-16082: Move internal variable to private to facilitate removing deprecation. [solr]

Posted by "madrob (via GitHub)" <gi...@apache.org>.
madrob commented on PR #3911:
URL: https://github.com/apache/solr/pull/3911#issuecomment-3597203824

   LGTM, aside from the pre-commit failure and formatting suggestion.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org