You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@click.apache.org by "Ryan Holmes (JIRA)" <ji...@apache.org> on 2010/09/07 04:58:33 UTC

[jira] Created: (CLK-717) Click 2.2 DTD does not allow a custom Format class

Click 2.2 DTD does not allow a custom Format class
--------------------------------------------------

                 Key: CLK-717
                 URL: https://issues.apache.org/jira/browse/CLK-717
             Project: Click
          Issue Type: Bug
          Components: core
    Affects Versions: 2.2.0
         Environment: Java 1.6, Jetty, Mac OS X
            Reporter: Ryan Holmes
            Priority: Minor


The DTD for Click 2.2 has a fixed value for the format classname. This results in an XML validation error when attempting to specify a custom Format class.


  <!-- Page template formatter class. An new format object added to
       the Velocity context under the key: "format". -->
  <!ELEMENT format (#PCDATA)>
   <!ATTLIST format classname CDATA #FIXED "org.apache.click.util.Format">


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CLK-717) Click 2.2 DTD does not allow a custom Format class

Posted by "Bob Schellink (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CLK-717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bob Schellink updated CLK-717:
------------------------------

         Assignee: Bob Schellink
    Fix Version/s: 2.3.0-M1

Fixed in trunk. Needs to be updated on the website though.

> Click 2.2 DTD does not allow a custom Format class
> --------------------------------------------------
>
>                 Key: CLK-717
>                 URL: https://issues.apache.org/jira/browse/CLK-717
>             Project: Click
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 2.2.0
>         Environment: Java 1.6, Jetty, Mac OS X
>            Reporter: Ryan Holmes
>            Assignee: Bob Schellink
>            Priority: Minor
>             Fix For: 2.3.0-M1
>
>
> The DTD for Click 2.2 has a fixed value for the format classname. This results in an XML validation error when attempting to specify a custom Format class.
>   <!-- Page template formatter class. An new format object added to
>        the Velocity context under the key: "format". -->
>   <!ELEMENT format (#PCDATA)>
>    <!ATTLIST format classname CDATA #FIXED "org.apache.click.util.Format">

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (CLK-717) Click 2.2 DTD does not allow a custom Format class

Posted by "Bob Schellink (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CLK-717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bob Schellink resolved CLK-717.
-------------------------------

    Resolution: Fixed

Fixed in trunk and updated website. Should be live in an hour or so

> Click 2.2 DTD does not allow a custom Format class
> --------------------------------------------------
>
>                 Key: CLK-717
>                 URL: https://issues.apache.org/jira/browse/CLK-717
>             Project: Click
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 2.2.0
>         Environment: Java 1.6, Jetty, Mac OS X
>            Reporter: Ryan Holmes
>            Assignee: Bob Schellink
>            Priority: Minor
>             Fix For: 2.3.0-M1
>
>
> The DTD for Click 2.2 has a fixed value for the format classname. This results in an XML validation error when attempting to specify a custom Format class.
>   <!-- Page template formatter class. An new format object added to
>        the Velocity context under the key: "format". -->
>   <!ELEMENT format (#PCDATA)>
>    <!ATTLIST format classname CDATA #FIXED "org.apache.click.util.Format">

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CLK-717) Click 2.2 DTD does not allow a custom Format class

Posted by "Ryan Holmes (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CLK-717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12906703#action_12906703 ] 

Ryan Holmes commented on CLK-717:
---------------------------------

I'm not a DTD expert either, but according to the ATTLIST tutorial at http://www.w3schools.com/dtd/dtd_attributes.asp, yes, #FIXED can simply be removed and "org.apache.click.util.Format" will be the default value. 

> Click 2.2 DTD does not allow a custom Format class
> --------------------------------------------------
>
>                 Key: CLK-717
>                 URL: https://issues.apache.org/jira/browse/CLK-717
>             Project: Click
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 2.2.0
>         Environment: Java 1.6, Jetty, Mac OS X
>            Reporter: Ryan Holmes
>            Priority: Minor
>
> The DTD for Click 2.2 has a fixed value for the format classname. This results in an XML validation error when attempting to specify a custom Format class.
>   <!-- Page template formatter class. An new format object added to
>        the Velocity context under the key: "format". -->
>   <!ELEMENT format (#PCDATA)>
>    <!ATTLIST format classname CDATA #FIXED "org.apache.click.util.Format">

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CLK-717) Click 2.2 DTD does not allow a custom Format class

Posted by "Bob Schellink (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CLK-717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12906695#action_12906695 ] 

Bob Schellink commented on CLK-717:
-----------------------------------

I don't know much about DTD's, but can we remove the #FIXED attribe from the various elements? Is there another reason for it?

> Click 2.2 DTD does not allow a custom Format class
> --------------------------------------------------
>
>                 Key: CLK-717
>                 URL: https://issues.apache.org/jira/browse/CLK-717
>             Project: Click
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 2.2.0
>         Environment: Java 1.6, Jetty, Mac OS X
>            Reporter: Ryan Holmes
>            Priority: Minor
>
> The DTD for Click 2.2 has a fixed value for the format classname. This results in an XML validation error when attempting to specify a custom Format class.
>   <!-- Page template formatter class. An new format object added to
>        the Velocity context under the key: "format". -->
>   <!ELEMENT format (#PCDATA)>
>    <!ATTLIST format classname CDATA #FIXED "org.apache.click.util.Format">

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.