You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/07/15 19:08:50 UTC

[GitHub] [beam] Abacn opened a new pull request, #22304: [WIP] Fix JDBCIOIT

Abacn opened a new pull request, #22304:
URL: https://github.com/apache/beam/pull/22304

   **Please** add a meaningful description for your change here
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] Abacn commented on pull request #22304: Fix JDBCIOIT

Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #22304:
URL: https://github.com/apache/beam/pull/22304#issuecomment-1190302460

   CC: @pabloem 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] Abacn commented on pull request #22304: [WIP] Fix JDBCIOIT

Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #22304:
URL: https://github.com/apache/beam/pull/22304#issuecomment-1185896258

   Default number of records causing "pipeline too large" exception, likely the records used for assertion also embedded in pipeline json?
   Setting number of records to 5000, the pipeline can run, but keeps bumping 
   ```
   java.lang.NullPointerException
   16:32:18             org.apache.beam.sdk.io.jdbc.JdbcIO$WriteFn.getConnection(JdbcIO.java:2325)
   16:32:18             org.apache.beam.sdk.io.jdbc.JdbcIO$WriteFn.executeBatch(JdbcIO.java:2375)
   16:32:18             org.apache.beam.sdk.io.jdbc.JdbcIO$WriteFn.processElement(JdbcIO.java:2334)
   ```
   changing getConnection to synchronized, this problem persists. Likely dataSource not configured properly and dataSource.getConnection() returned null


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] johnjcasey commented on pull request #22304: Fix JDBCIOIT

Posted by GitBox <gi...@apache.org>.
johnjcasey commented on PR #22304:
URL: https://github.com/apache/beam/pull/22304#issuecomment-1201637385

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] github-actions[bot] commented on pull request #22304: Fix JDBCIOIT

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22304:
URL: https://github.com/apache/beam/pull/22304#issuecomment-1189659416

   Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] Abacn commented on pull request #22304: [WIP] Fix JDBCIOIT

Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #22304:
URL: https://github.com/apache/beam/pull/22304#issuecomment-1188557132

   Run Java JdbcIO Performance Test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] Abacn commented on pull request #22304: [WIP] Fix JDBCIOIT

Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #22304:
URL: https://github.com/apache/beam/pull/22304#issuecomment-1185829883

   Run Java JdbcIO Performance Test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] Abacn commented on pull request #22304: Fix JDBCIOIT

Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #22304:
URL: https://github.com/apache/beam/pull/22304#issuecomment-1190369806

   Run Java PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] Abacn commented on pull request #22304: Fix JDBCIOIT

Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #22304:
URL: https://github.com/apache/beam/pull/22304#issuecomment-1189655150

   Run Java JdbcIO Performance Test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] Abacn commented on pull request #22304: Fix JDBCIOIT

Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #22304:
URL: https://github.com/apache/beam/pull/22304#issuecomment-1189538304

   Run Java JdbcIO Performance Test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] Abacn commented on pull request #22304: [WIP] Fix JDBCIOIT

Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #22304:
URL: https://github.com/apache/beam/pull/22304#issuecomment-1189444084

   Run Java JdbcIO Performance Test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] johnjcasey merged pull request #22304: Fix JDBCIOIT

Posted by GitBox <gi...@apache.org>.
johnjcasey merged PR #22304:
URL: https://github.com/apache/beam/pull/22304


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] Abacn commented on pull request #22304: Fix JDBCIOIT

Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #22304:
URL: https://github.com/apache/beam/pull/22304#issuecomment-1189658999

   R: @chamikaramj 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] Abacn commented on pull request #22304: Fix JDBCIOIT

Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #22304:
URL: https://github.com/apache/beam/pull/22304#issuecomment-1189453696

   Run Java JdbcIO Performance Test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] Abacn commented on pull request #22304: [WIP] Fix JDBCIOIT

Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #22304:
URL: https://github.com/apache/beam/pull/22304#issuecomment-1185842694

   Run Java JdbcIO Performance Test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] Abacn commented on pull request #22304: [WIP] Fix JDBCIOIT

Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #22304:
URL: https://github.com/apache/beam/pull/22304#issuecomment-1185861333

   Run Java JdbcIO Performance Test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] Abacn commented on pull request #22304: [WIP] Fix JDBCIOIT

Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #22304:
URL: https://github.com/apache/beam/pull/22304#issuecomment-1189336542

   Run Java JdbcIO Performance Test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] Abacn commented on pull request #22304: [WIP] Fix JDBCIOIT

Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #22304:
URL: https://github.com/apache/beam/pull/22304#issuecomment-1185918297

   Run Java JdbcIO Performance Test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] Abacn commented on pull request #22304: Fix JDBCIOIT

Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #22304:
URL: https://github.com/apache/beam/pull/22304#issuecomment-1189629569

   Run Java JdbcIO Performance Test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] Abacn commented on pull request #22304: Fix JDBCIOIT

Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #22304:
URL: https://github.com/apache/beam/pull/22304#issuecomment-1189537327

   Run Java JdbcIO Performance Test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org