You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/08/31 14:38:50 UTC
[GitHub] [superset] michael-s-molina opened a new pull request, #21269: feat: Adds a helper text option to the Select component
michael-s-molina opened a new pull request, #21269:
URL: https://github.com/apache/superset/pull/21269
### SUMMARY
Adds a helper text option to the Select component to aid users when dealing with more complex flows.
@kasiazjc @codyml @cccs-RyanK
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
https://user-images.githubusercontent.com/70410625/187705070-37e6d0da-9e03-42ea-87c5-8fe2544896b7.mov
### TESTING INSTRUCTIONS
Check the video for instructions.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [x] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on a diff in pull request #21269: feat: Adds a helper text option to the Select component
Posted by GitBox <gi...@apache.org>.
geido commented on code in PR #21269:
URL: https://github.com/apache/superset/pull/21269#discussion_r960527594
##########
superset-frontend/src/components/Select/AsyncSelect.test.tsx:
##########
@@ -750,6 +722,20 @@ test('fires a new request if all values have not been fetched', async () => {
expect(mock).toHaveBeenCalledTimes(2);
});
+test('does not renders a helper text by default', async () => {
Review Comment:
```suggestion
test('does not render a helper text by default', async () => {
```
##########
superset-frontend/src/components/Select/Select.test.tsx:
##########
@@ -535,6 +535,20 @@ test('triggers getPopupContainer if passed', async () => {
expect(getPopupContainer).toHaveBeenCalled();
});
+test('does not renders a helper text by default', async () => {
Review Comment:
```suggestion
test('does not render a helper text by default', async () => {
```
##########
superset-frontend/src/components/Select/Select.tsx:
##########
@@ -162,6 +170,16 @@ const StyledLoadingText = styled.div`
`}
`;
+const StyledHelperText = styled.div`
Review Comment:
This looks identical to the AsyncSelect one. Should we put in a common file and import it from there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a diff in pull request #21269: feat: Adds a helper text option to the Select component
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on code in PR #21269:
URL: https://github.com/apache/superset/pull/21269#discussion_r960555342
##########
superset-frontend/src/components/Select/Select.tsx:
##########
@@ -162,6 +170,16 @@ const StyledLoadingText = styled.div`
`}
`;
+const StyledHelperText = styled.div`
Review Comment:
Yes. I left it duplicated on purpose in this PR because @cccs-RyanK is already working on the common file in https://github.com/apache/superset/pull/21094
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #21269: feat: Adds a helper text option to the Select component
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #21269:
URL: https://github.com/apache/superset/pull/21269#issuecomment-1233108022
# [Codecov](https://codecov.io/gh/apache/superset/pull/21269?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21269](https://codecov.io/gh/apache/superset/pull/21269?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e4bbfee) into [master](https://codecov.io/gh/apache/superset/commit/622304205058d31b34a6590f4c0d652421730464?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6223042) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #21269 +/- ##
=======================================
Coverage 66.43% 66.43%
=======================================
Files 1784 1784
Lines 68185 68193 +8
Branches 7265 7267 +2
=======================================
+ Hits 45298 45306 +8
Misses 21018 21018
Partials 1869 1869
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `52.50% <100.00%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/21269?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/components/Select/AsyncSelect.tsx](https://codecov.io/gh/apache/superset/pull/21269/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L0FzeW5jU2VsZWN0LnRzeA==) | `83.47% <100.00%> (+0.21%)` | :arrow_up: |
| [superset-frontend/src/components/Select/Select.tsx](https://codecov.io/gh/apache/superset/pull/21269/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1NlbGVjdC50c3g=) | `87.41% <100.00%> (+0.25%)` | :arrow_up: |
| [...-frontend/src/components/FilterableTable/index.tsx](https://codecov.io/gh/apache/superset/pull/21269/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmlsdGVyYWJsZVRhYmxlL2luZGV4LnRzeA==) | `72.63% <0.00%> (+0.29%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina merged pull request #21269: feat: Adds a helper text option to the Select component
Posted by GitBox <gi...@apache.org>.
michael-s-molina merged PR #21269:
URL: https://github.com/apache/superset/pull/21269
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org