[jira] [Commented] (PIO-35) Add integration tests for major templates

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PIO-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15511849#comment-15511849 ] 

ASF GitHub Bot commented on PIO-35:
-----------------------------------

GitHub user chanlee514 opened a pull request:

    https://github.com/apache/incubator-predictionio/pull/300

    [PIO-35] Add integration tests for official templates

    **Changes:**
    
    - Integration test fetches templates from Github, instead of storing local copy.
    - Install git in Docker image.
    
    **Notes**
    
    - As can be seen in `tests.py`,  3 tests are run by default on Travis: *['BasicAppUsecases', 'EventserverTest', 'ScalaParallelRecommendationTest']*. One can change this using `TEST_NAMES` param in `.travis.yml` 
    - Each scenario should be updated to use standalone Spark cluster for more stable behavior ([https://issues.apache.org/jira/browse/PIO-36](url)). I've done some work on this, and will update as [PIO-36].
    - I've excluded 'JavaParallelEcommercerecommendationTest' for now since the template fails to load org.jblas dependency before test execution.
     

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chanlee514/incubator-predictionio develop

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-predictionio/pull/300.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #300
    
----
commit bfa6fdb0b27eb1366bba8d1a550647dbdd436642
Author: Chan Lee <ch...@gmail.com>
Date:   2016-09-22T00:27:04Z

    Add integration tests for all official templates
    
    - Fetch engine code from Github instead of storing local copy
    - Some structural refactoring

commit f4671ef149f7cb9ee95aabaa3dd8d9c43ce65a1d
Author: Chan Lee <ch...@gmail.com>
Date:   2016-09-22T00:41:08Z

    Add data for template integration testing

----


> Add integration tests for major templates
> -----------------------------------------
>
>                 Key: PIO-35
>                 URL: https://issues.apache.org/jira/browse/PIO-35
>             Project: PredictionIO
>          Issue Type: Improvement
>            Reporter: Chan
>
> Developers of engine templates should be able to test that their template works with the latest changes in PredictionIO. As a starting point, we can expand the integration test suite to all previously "official" templates.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)