[GitHub] [nifi] MikeThomsen commented on a change in pull request #3953: NIFI-5901 Added JSON/JSONB support to PutDatabaseRecord

[GitBox <gi...@apache.org>]

MikeThomsen commented on a change in pull request #3953: NIFI-5901 Added JSON/JSONB support to PutDatabaseRecord
URL: https://github.com/apache/nifi/pull/3953#discussion_r363913788
 
 

 ##########
 File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutDatabaseRecord.java
 ##########
 @@ -252,6 +258,16 @@
             .defaultValue("false")
             .build();
 
+    static final PropertyDescriptor MAP_RECORD_TO_JSON = new PropertyDescriptor.Builder()
+            .name("put-db-record-map-record-to-json")
+            .displayName("Map \"record\" types to JSON")
 
 Review comment:
   The JSON support is implemented using the MapRecord API that converts the Record to JSON without having to use a record writer. Since nothing like that exists for XML, how do you want to handle it? I suppose we could allow a writer to be specified and have the writer simply take the schema from the Record field.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services