You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/04/06 19:20:38 UTC
[GitHub] [incubator-gobblin] arjun4084346 opened a new pull request #2950:
[GOBBLIN-1110] Task driver stop
arjun4084346 opened a new pull request #2950: [GOBBLIN-1110] Task driver stop
URL: https://github.com/apache/incubator-gobblin/pull/2950
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1110
### Description
- [x] Here are some details about my PR, including screenshots (if applicable):
handle runtime exceptions in executeCancellation implementation of GobblinHelixJobLauncher
if all the exceptions are not caught, cancellation executor thread in abstract job launcher may die and may not notify other threads waiting for a conditional object (AbstractJobLauncher.this.cancellationExecution specifically)
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
NA
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] codecov-io commented on issue #2950:
[GOBBLIN-1110] Task driver stop
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #2950: [GOBBLIN-1110] Task driver stop
URL: https://github.com/apache/incubator-gobblin/pull/2950#issuecomment-610139074
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2950?src=pr&el=h1) Report
> Merging [#2950](https://codecov.io/gh/apache/incubator-gobblin/pull/2950?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/974fcaf804278459b28ab1d1ef0b9cdd5b5b1517&el=desc) will **decrease** coverage by `0.93%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2950?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2950 +/- ##
============================================
- Coverage 45.57% 44.64% -0.94%
+ Complexity 9157 8987 -170
============================================
Files 1936 1936
Lines 73295 73298 +3
Branches 8088 8089 +1
============================================
- Hits 33405 32722 -683
- Misses 36794 37524 +730
+ Partials 3096 3052 -44
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2950?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...a/org/apache/gobblin/aws/GobblinAWSTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2950/diff?src=pr&el=tree#diff-Z29iYmxpbi1hd3Mvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vYXdzL0dvYmJsaW5BV1NUYXNrUnVubmVyLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...pache/gobblin/cluster/GobblinHelixJobLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2950/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4Sm9iTGF1bmNoZXIuamF2YQ==) | `81.28% <0.00%> (ø)` | `27.00 <0.00> (ø)` | |
| [...ava/org/apache/gobblin/metrics/GobblinMetrics.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2950/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL21ldHJpY3MvR29iYmxpbk1ldHJpY3MuamF2YQ==) | `18.80% <0.00%> (ø)` | `15.00 <0.00> (ø)` | |
| [...rg/apache/gobblin/runtime/AbstractJobLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2950/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvQWJzdHJhY3RKb2JMYXVuY2hlci5qYXZh) | `59.58% <ø> (-0.78%)` | `35.00 <0.00> (-2.00)` | |
| [...org/apache/gobblin/yarn/GobblinYarnTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2950/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vR29iYmxpbllhcm5UYXNrUnVubmVyLmphdmE=) | `2.89% <0.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2950/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==) | `67.91% <77.77%> (+0.86%)` | `33.00 <3.00> (ø)` | |
| [...gobblin/runtime/mapreduce/GobblinOutputFormat.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2950/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbWFwcmVkdWNlL0dvYmJsaW5PdXRwdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...askStateCollectorServiceHiveRegHandlerFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2950/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvVGFza1N0YXRlQ29sbGVjdG9yU2VydmljZUhpdmVSZWdIYW5kbGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...re/filesystem/FsDatasetStateStoreEntryManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2950/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbWV0YXN0b3JlL2ZpbGVzeXN0ZW0vRnNEYXRhc2V0U3RhdGVTdG9yZUVudHJ5TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...in/runtime/mapreduce/CustomizedProgresserBase.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2950/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbWFwcmVkdWNlL0N1c3RvbWl6ZWRQcm9ncmVzc2VyQmFzZS5qYXZh) | `0.00% <0.00%> (-83.34%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [47 more](https://codecov.io/gh/apache/incubator-gobblin/pull/2950/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2950?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2950?src=pr&el=footer). Last update [974fcaf...2fe0bf8](https://codecov.io/gh/apache/incubator-gobblin/pull/2950?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] yukuai518 commented on issue #2950:
[GOBBLIN-1110] Task driver stop
Posted by GitBox <gi...@apache.org>.
yukuai518 commented on issue #2950: [GOBBLIN-1110] Task driver stop
URL: https://github.com/apache/incubator-gobblin/pull/2950#issuecomment-610649504
+1 LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] asfgit closed pull request #2950:
[GOBBLIN-1110] Task driver stop
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #2950: [GOBBLIN-1110] Task driver stop
URL: https://github.com/apache/incubator-gobblin/pull/2950
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services