You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "cnauroth (via GitHub)" <gi...@apache.org> on 2026/01/05 23:04:07 UTC
[PR] HADOOP-19776: trunk pre-commits for native code still try to use Java 8 [hadoop]
cnauroth opened a new pull request, #8166:
URL: https://github.com/apache/hadoop/pull/8166
### Description of PR
Pre-commits contain some steps specifically triggered for native code patches to check cross-platform compatibility. These are still trying to run with Java 8 targets. (Example: #8151 .) This patch removes these pre-commit steps for Rocky 8 and Debian 11, which both use Java 8. Instead, we now trigger these steps for Debian 12, Debian 13 and Ubuntu 24, all of which use Java 17. From recent commits, it seems these are the OSes we've agreed to target on trunk/Hadoop 3.5.
### How was this patch tested?
Relying on pre-submit results. I'm temporarily including the native code change from #8151 to try to trigger it. I won't include that when I commit this.
### For code changes:
- [X] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
Re: [PR] HADOOP-19776: trunk pre-commits for native code still try to use Java 8 [hadoop]
Posted by "cnauroth (via GitHub)" <gi...@apache.org>.
cnauroth commented on PR #8166:
URL: https://github.com/apache/hadoop/pull/8166#issuecomment-3739808381
@pan3793 and @ayushtkn , thank you for the reviews. I committed this to trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
Re: [PR] HADOOP-19776: trunk pre-commits for native code still try to use Java 8 [hadoop]
Posted by "edwardcapriolo (via GitHub)" <gi...@apache.org>.
edwardcapriolo commented on PR #8166:
URL: https://github.com/apache/hadoop/pull/8166#issuecomment-3730550129
Modern maven seems to leverage:
~/.m2/toolchains.xml
However based on maven versions it is no magic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
Re: [PR] HADOOP-19776: trunk pre-commits for native code still try to use Java 8 [hadoop]
Posted by "hadoop-yetus (via GitHub)" <gi...@apache.org>.
hadoop-yetus commented on PR #8166:
URL: https://github.com/apache/hadoop/pull/8166#issuecomment-3712814066
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 33m 51s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +0 :ok: | shelldocs | 0m 0s | | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
|||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 44m 12s | | trunk passed |
| -1 :x: | compile | 3m 17s | [/branch-compile-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8166/1/artifact/out/branch-compile-root.txt) | root in trunk failed. |
| +1 :green_heart: | mvnsite | 1m 45s | | trunk passed |
| +1 :green_heart: | shadedclient | 30m 13s | | branch has no errors when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 9s | | the patch passed |
| -1 :x: | compile | 3m 6s | [/patch-compile-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8166/1/artifact/out/patch-compile-root.txt) | root in the patch failed. |
| -1 :x: | cc | 3m 6s | [/patch-compile-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8166/1/artifact/out/patch-compile-root.txt) | root in the patch failed. |
| -1 :x: | golang | 3m 6s | [/patch-compile-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8166/1/artifact/out/patch-compile-root.txt) | root in the patch failed. |
| -1 :x: | javac | 3m 6s | [/patch-compile-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8166/1/artifact/out/patch-compile-root.txt) | root in the patch failed. |
| -1 :x: | blanks | 0m 0s | [/blanks-eol.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8166/1/artifact/out/blanks-eol.txt) | The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply |
| +1 :green_heart: | mvnsite | 1m 30s | | the patch passed |
| +1 :green_heart: | shellcheck | 0m 0s | | No new issues. |
| +1 :green_heart: | shadedclient | 30m 25s | | patch has no errors when building and testing our client artifacts. |
|||| _ Other Tests _ |
| -1 :x: | unit | 27m 8s | [/patch-unit-hadoop-common-project_hadoop-common.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8166/1/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt) | hadoop-common in the patch passed. |
| +1 :green_heart: | asflicense | 0m 37s | | The patch does not generate ASF License warnings. |
| | | 180m 19s | | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.security.token.delegation.TestZKDelegationTokenSecretManager |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.52 ServerAPI=1.52 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8166/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/8166 |
| Optional Tests | dupname asflicense codespell detsecrets shellcheck shelldocs compile cc mvnsite javac unit golang |
| uname | Linux c7d8ae3cf4b3 5.15.0-160-generic #170-Ubuntu SMP Wed Oct 1 10:06:56 UTC 2025 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 2653f7bfabb3de34acc2864c16e0900de0f31cd4 |
| Default Java | Debian-17.0.17+10-Debian-1deb12u1 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8166/1/testReport/ |
| Max. process+thread count | 1271 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8166/1/console |
| versions | git=2.39.5 maven=3.9.11 shellcheck=0.9.0 |
| Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
Re: [PR] HADOOP-19776: trunk pre-commits for native code still try to use Java 8 [hadoop]
Posted by "hadoop-yetus (via GitHub)" <gi...@apache.org>.
hadoop-yetus commented on PR #8166:
URL: https://github.com/apache/hadoop/pull/8166#issuecomment-3730251125
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 34m 58s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +0 :ok: | shellcheck | 0m 0s | | Shellcheck was not available. |
| +0 :ok: | shelldocs | 0m 0s | | Shelldocs was not available. |
| +0 :ok: | hadolint | 0m 0s | | hadolint was not available. |
| +0 :ok: | jsonlint | 0m 0s | | jsonlint was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
|||| _ trunk Compile Tests _ |
| -1 :x: | mvninstall | 1m 46s | [/branch-mvninstall-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8166/2/artifact/out/branch-mvninstall-root.txt) | root in trunk failed. |
| -1 :x: | compile | 0m 32s | [/branch-compile-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8166/2/artifact/out/branch-compile-root.txt) | root in trunk failed. |
| +1 :green_heart: | mvnsite | 2m 38s | | trunk passed |
| -1 :x: | shadedclient | 6m 36s | | branch has errors when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 12s | | the patch passed |
| -1 :x: | compile | 0m 32s | [/patch-compile-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8166/2/artifact/out/patch-compile-root.txt) | root in the patch failed. |
| -1 :x: | cc | 0m 32s | [/patch-compile-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8166/2/artifact/out/patch-compile-root.txt) | root in the patch failed. |
| -1 :x: | golang | 0m 32s | [/patch-compile-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8166/2/artifact/out/patch-compile-root.txt) | root in the patch failed. |
| -1 :x: | javac | 0m 32s | [/patch-compile-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8166/2/artifact/out/patch-compile-root.txt) | root in the patch failed. |
| -1 :x: | blanks | 0m 0s | [/blanks-eol.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8166/2/artifact/out/blanks-eol.txt) | The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply |
| +1 :green_heart: | mvnsite | 1m 31s | | the patch passed |
| -1 :x: | shadedclient | 3m 4s | | patch has errors when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 22m 26s | | hadoop-common in the patch passed. |
| +1 :green_heart: | asflicense | 0m 49s | | The patch does not generate ASF License warnings. |
| | | 72m 3s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.52 ServerAPI=1.52 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8166/2/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/8166 |
| Optional Tests | dupname asflicense codespell detsecrets shellcheck shelldocs hadolint jsonlint compile cc mvnsite javac unit golang |
| uname | Linux dbaeb456cb0d 5.15.0-160-generic #170-Ubuntu SMP Wed Oct 1 10:06:56 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 0aa091258990f2f8eb54c5b00c5e1ba008870771 |
| Default Java | Red Hat, Inc.-1.8.0_472-b08 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8166/2/testReport/ |
| Max. process+thread count | 3097 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8166/2/console |
| versions | git=2.43.7 maven=3.9.11 |
| Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
Re: [PR] HADOOP-19776: trunk pre-commits for native code still try to use Java 8 [hadoop]
Posted by "cnauroth (via GitHub)" <gi...@apache.org>.
cnauroth commented on PR #8166:
URL: https://github.com/apache/hadoop/pull/8166#issuecomment-3730500927
jenkins.sh overrides the Yetus `--java-home` to a path with a `-amd64` suffix, which doesn't exist in the Rocky image. Then it ends up defaulting back to Java 8. I might have to fake this with symlinks.
```
[2026-01-09T18:38:26.880Z] WARNING: JAVA_HOME=/usr/lib/jvm/java-17-openjdk-amd64 does not exist. Dockermode: attempting to switch to another.
[2026-01-09T18:38:26.880Z] WARNING: Setting /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.472.b08-1.el8.x86_64 as the JAVA_HOME.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
Re: [PR] HADOOP-19776: trunk pre-commits for native code still try to use Java 8 [hadoop]
Posted by "hadoop-yetus (via GitHub)" <gi...@apache.org>.
hadoop-yetus commented on PR #8166:
URL: https://github.com/apache/hadoop/pull/8166#issuecomment-3731325307
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 32m 16s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +0 :ok: | shellcheck | 0m 0s | | Shellcheck was not available. |
| +0 :ok: | shelldocs | 0m 0s | | Shelldocs was not available. |
| +0 :ok: | hadolint | 0m 0s | | hadolint was not available. |
| +0 :ok: | jsonlint | 0m 0s | | jsonlint was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
|||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 43m 40s | | trunk passed |
| +1 :green_heart: | compile | 19m 19s | | trunk passed with JDK Red Hat, Inc.-21.0.9+10-LTS |
| +1 :green_heart: | compile | 20m 9s | | trunk passed with JDK Red Hat, Inc.-17.0.17+10-LTS |
| +1 :green_heart: | mvnsite | 3m 4s | | trunk passed |
| +1 :green_heart: | shadedclient | 120m 55s | | branch has no errors when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 24s | | the patch passed |
| +1 :green_heart: | compile | 17m 56s | | the patch passed with JDK Red Hat, Inc.-21.0.9+10-LTS |
| +1 :green_heart: | cc | 17m 56s | | the patch passed |
| +1 :green_heart: | golang | 17m 56s | | the patch passed |
| +1 :green_heart: | javac | 17m 56s | | the patch passed |
| +1 :green_heart: | compile | 20m 7s | | the patch passed with JDK Red Hat, Inc.-17.0.17+10-LTS |
| +1 :green_heart: | cc | 20m 7s | | the patch passed |
| +1 :green_heart: | golang | 20m 7s | | the patch passed |
| +1 :green_heart: | javac | 20m 7s | | the patch passed |
| -1 :x: | blanks | 0m 0s | [/blanks-eol.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8166/3/artifact/out/blanks-eol.txt) | The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply |
| +1 :green_heart: | mvnsite | 3m 6s | | the patch passed |
| +1 :green_heart: | shadedclient | 37m 59s | | patch has no errors when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 23m 39s | | hadoop-common in the patch passed. |
| +1 :green_heart: | asflicense | 2m 19s | | The patch does not generate ASF License warnings. |
| | | 260m 28s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.52 ServerAPI=1.52 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8166/3/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/8166 |
| Optional Tests | dupname asflicense codespell detsecrets shellcheck shelldocs hadolint jsonlint compile cc mvnsite javac unit golang |
| uname | Linux 43372fbc8381 5.15.0-160-generic #170-Ubuntu SMP Wed Oct 1 10:06:56 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / e256ba6ea73bb34d1925416972298f2800a48904 |
| Default Java | Red Hat, Inc.-17.0.17+10-LTS |
| Multi-JDK versions | /usr/lib/jvm/java-21-openjdk-21.0.9.0.10-1.el8.x86_64:Red Hat, Inc.-21.0.9+10-LTS /usr/lib/jvm/java-17-openjdk-17.0.17.0.10-1.el8.x86_64:Red Hat, Inc.-17.0.17+10-LTS |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8166/3/testReport/ |
| Max. process+thread count | 3109 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8166/3/console |
| versions | git=2.43.7 maven=3.9.11 |
| Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
Re: [PR] HADOOP-19776: trunk pre-commits for native code still try to use Java 8 [hadoop]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #8166:
URL: https://github.com/apache/hadoop/pull/8166#discussion_r2663534445
##########
dev-support/Jenkinsfile:
##########
@@ -111,12 +118,12 @@ pipeline {
// C++/C++ build/platform.
// This stage serves as a means of cross platform validation, which is
// really needed to ensure that any C++ related/platform change doesn't
- // break the Hadoop build on Rocky Linux 8.
- stage ('precommit-run Rocky Linux 8') {
Review Comment:
can we install openjdk 17 instead of removing rocky linux 8? I think we should at least keep one rhel-like OS in pre-commit, along-side with other debian-like OS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
Re: [PR] HADOOP-19776: trunk pre-commits for native code still try to use Java 8 [hadoop]
Posted by "cnauroth (via GitHub)" <gi...@apache.org>.
cnauroth commented on PR #8166:
URL: https://github.com/apache/hadoop/pull/8166#issuecomment-3739819977
I forgot to remove the exception.c change that was only part of testing, so you'll see one extra commit. I reverted it so I can give the real author proper credit in a separate commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
Re: [PR] HADOOP-19776: trunk pre-commits for native code still try to use Java 8 [hadoop]
Posted by "cnauroth (via GitHub)" <gi...@apache.org>.
cnauroth commented on code in PR #8166:
URL: https://github.com/apache/hadoop/pull/8166#discussion_r2677120214
##########
dev-support/Jenkinsfile:
##########
@@ -111,12 +118,12 @@ pipeline {
// C++/C++ build/platform.
// This stage serves as a means of cross platform validation, which is
// really needed to ensure that any C++ related/platform change doesn't
- // break the Hadoop build on Rocky Linux 8.
- stage ('precommit-run Rocky Linux 8') {
Review Comment:
I've updated the patch to keep Rocky 8 and install Java 17. We can reconsider modernizing the OS targets separately from this patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
Re: [PR] HADOOP-19776: trunk pre-commits for native code still try to use Java 8 [hadoop]
Posted by "hadoop-yetus (via GitHub)" <gi...@apache.org>.
hadoop-yetus commented on PR #8166:
URL: https://github.com/apache/hadoop/pull/8166#issuecomment-3730592860
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8166/3/console in case of problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
Re: [PR] HADOOP-19776: trunk pre-commits for native code still try to use Java 8 [hadoop]
Posted by "edwardcapriolo (via GitHub)" <gi...@apache.org>.
edwardcapriolo commented on code in PR #8166:
URL: https://github.com/apache/hadoop/pull/8166#discussion_r2673636948
##########
dev-support/Jenkinsfile:
##########
@@ -136,7 +143,53 @@ pipeline {
failure {
sh '''#!/usr/bin/env bash
- cp -Rp "${WORKSPACE}/rockylinux-8/out" "${WORKSPACE}"
+ cp -Rp "${WORKSPACE}/debian-12/out" "${WORKSPACE}"
+ '''
+ archiveArtifacts "out/**"
+ }
+
+ cleanup() {
+ script {
+ sh '''#!/usr/bin/env bash
+
+ chmod u+x "${SOURCEDIR}/dev-support/jenkins.sh"
+ "${SOURCEDIR}/dev-support/jenkins.sh" cleanup_ci_proc
+ '''
+ }
+ }
+ }
+ }
+
+ // This is an optional stage which runs only when there's a change in
+ // C++/C++ build/platform.
+ // This stage serves as a means of cross platform validation, which is
+ // really needed to ensure that any C++ related/platform change doesn't
+ // break the Hadoop build on Debian 13.
+ stage ('precommit-run Debian 13') {
Review Comment:
For reference. I am building locally on alpine. https://github.com/edwardcapriolo/edgy-ansible/tree/main/imaging/hadoop I am a great canary. I find all types of interesting things, reliance on ncurses, gnu find.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
Re: [PR] HADOOP-19776: trunk pre-commits for native code still try to use Java 8 [hadoop]
Posted by "cnauroth (via GitHub)" <gi...@apache.org>.
cnauroth commented on PR #8166:
URL: https://github.com/apache/hadoop/pull/8166#issuecomment-3729999601
I have updated this patch to stick with the original build targets, but make sure they are using Java 17.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
Re: [PR] HADOOP-19776: trunk pre-commits for native code still try to use Java 8 [hadoop]
Posted by "ayushtkn (via GitHub)" <gi...@apache.org>.
ayushtkn commented on code in PR #8166:
URL: https://github.com/apache/hadoop/pull/8166#discussion_r2678374938
##########
hadoop-common-project/hadoop-common/src/main/native/src/exception.c:
##########
@@ -110,15 +110,18 @@ jthrowable newIOException(JNIEnv* env, const char *fmt, ...)
const char* terror(int errnum)
{
-// MT-Safe under Solaris or glibc >= 2.32 not supporting sys_errlist/sys_nerr
-#if defined(__sun)
- #define USE_STR_ERROR
-#elif defined(__GLIBC_PREREQ)
- #if __GLIBC_PREREQ(2, 32)
- #define USE_STR_ERROR
+/* STD_ERROR is the new standard. Alpine musc does not want to be 'detected' it want to be pure and modern. Thus we detect the old glib and handle. */
+#ifdef __GLIBC__
+ #if defined(__GLIBC_PREREQ)
+ #if __GLIBC_PREREQ(2, 32)
+ #define USE_STR_ERROR
+ #endif
#endif
+#else
+ #define USE_STR_ERROR
#endif
+
#if defined(USE_STR_ERROR)
return strerror(errnum);
Review Comment:
are we overlapping with:
https://github.com/apache/hadoop/pull/8151
@edwardcapriolo can you check once?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
Re: [PR] HADOOP-19776: trunk pre-commits for native code still try to use Java 8 [hadoop]
Posted by "cnauroth (via GitHub)" <gi...@apache.org>.
cnauroth closed pull request #8166: HADOOP-19776: trunk pre-commits for native code still try to use Java 8
URL: https://github.com/apache/hadoop/pull/8166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
Re: [PR] HADOOP-19776: trunk pre-commits for native code still try to use Java 8 [hadoop]
Posted by "cnauroth (via GitHub)" <gi...@apache.org>.
cnauroth commented on code in PR #8166:
URL: https://github.com/apache/hadoop/pull/8166#discussion_r2683342123
##########
hadoop-common-project/hadoop-common/src/main/native/src/exception.c:
##########
@@ -110,15 +110,18 @@ jthrowable newIOException(JNIEnv* env, const char *fmt, ...)
const char* terror(int errnum)
{
-// MT-Safe under Solaris or glibc >= 2.32 not supporting sys_errlist/sys_nerr
-#if defined(__sun)
- #define USE_STR_ERROR
-#elif defined(__GLIBC_PREREQ)
- #if __GLIBC_PREREQ(2, 32)
- #define USE_STR_ERROR
+/* STD_ERROR is the new standard. Alpine musc does not want to be 'detected' it want to be pure and modern. Thus we detect the old glib and handle. */
+#ifdef __GLIBC__
+ #if defined(__GLIBC_PREREQ)
+ #if __GLIBC_PREREQ(2, 32)
+ #define USE_STR_ERROR
+ #endif
#endif
+#else
+ #define USE_STR_ERROR
#endif
+
#if defined(USE_STR_ERROR)
return strerror(errnum);
Review Comment:
Edward's PR is what made me first notice this problem. I had temporarily included it here just so Yetus would trigger a native code patch run. I'm going to commit #8151 separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
Re: [PR] HADOOP-19776: trunk pre-commits for native code still try to use Java 8 [hadoop]
Posted by "cnauroth (via GitHub)" <gi...@apache.org>.
cnauroth commented on PR #8166:
URL: https://github.com/apache/hadoop/pull/8166#issuecomment-3726514017
These new build targets I'm trying to set up are failing, related to the Fuse dependency:
```
[WARNING] -- Package 'fuse', required by 'virtual:world', not found
[WARNING] -- Failed to find Linux FUSE libraries or include files. Will not build FUSE client.
[WARNING] CMake Error at CMakeLists.txt:215 (message):
[WARNING] Required component fuse_dfs could not be built.
```
I think I'm going to switch gears to take the simplest path to fixing pre-submit by getting Java 17 into the existing build targets. Then, we can look at modernizing the platforms in a subsequent patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
Re: [PR] HADOOP-19776: trunk pre-commits for native code still try to use Java 8 [hadoop]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #8166:
URL: https://github.com/apache/hadoop/pull/8166#discussion_r2663536531
##########
dev-support/Jenkinsfile:
##########
@@ -136,7 +143,53 @@ pipeline {
failure {
sh '''#!/usr/bin/env bash
- cp -Rp "${WORKSPACE}/rockylinux-8/out" "${WORKSPACE}"
+ cp -Rp "${WORKSPACE}/debian-12/out" "${WORKSPACE}"
+ '''
+ archiveArtifacts "out/**"
+ }
+
+ cleanup() {
+ script {
+ sh '''#!/usr/bin/env bash
+
+ chmod u+x "${SOURCEDIR}/dev-support/jenkins.sh"
+ "${SOURCEDIR}/dev-support/jenkins.sh" cleanup_ci_proc
+ '''
+ }
+ }
+ }
+ }
+
+ // This is an optional stage which runs only when there's a change in
+ // C++/C++ build/platform.
+ // This stage serves as a means of cross platform validation, which is
+ // really needed to ensure that any C++ related/platform change doesn't
+ // break the Hadoop build on Debian 13.
+ stage ('precommit-run Debian 13') {
Review Comment:
to reduce maintainance effort, maybe it's sufficent to keep only one version of debian, either 12 or 13 is fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
Re: [PR] HADOOP-19776: trunk pre-commits for native code still try to use Java 8 [hadoop]
Posted by "hadoop-yetus (via GitHub)" <gi...@apache.org>.
hadoop-yetus commented on PR #8166:
URL: https://github.com/apache/hadoop/pull/8166#issuecomment-3730013023
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8166/2/console in case of problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org