You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "RatulDawar (via GitHub)" <gi...@apache.org> on 2025/11/18 22:35:04 UTC
[PR] feat: update dependencies and to make trino-hudi-plugin compatible with trino 478. [hudi]
RatulDawar opened a new pull request, #14299:
URL: https://github.com/apache/hudi/pull/14299
### Describe the issue this Pull Request addresses
<!-- Either describe the issue inline here with motivation behind the changes
(or) link to an issue by including `Closes #<issue-number>` for context.
If this PR includes changes to the storage format, public APIs,
or has breaking changes, use `!` (e.g., feat!: ...) -->
### Summary and Changelog
<!-- Short, plain-English summary of what users gain or what changed in behavior.
Followed by a detailed log of all the changes. Highlight if any code was copied. -->
### Impact
<!-- Describe any public API or user-facing feature change or any performance impact. -->
### Risk Level
<!-- Accepted values: none, low, medium or high. Other than `none`, explain the risk.
If medium or high, explain what verification was done to mitigate the risks. -->
### Documentation Update
<!-- Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
- The config description must be updated if new configs are added or the default value of the configs are changed.
- Any new feature or user-facing change requires updating the Hudi website. Please follow the
[instruction](https://hudi.apache.org/contribute/developer-setup#website) to make changes to the website. -->
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Enough context is provided in the sections above
- [ ] Adequate tests were added if applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: update dependencies and to make trino-hudi-plugin compatible with trino 478. [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #14299:
URL: https://github.com/apache/hudi/pull/14299#issuecomment-3558978936
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4ba9cb908baee11a25ee584d53b848daf1a8e000",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9600",
"triggerID" : "4ba9cb908baee11a25ee584d53b848daf1a8e000",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4ba9cb908baee11a25ee584d53b848daf1a8e000 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9600)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: update dependencies and to make trino-hudi-plugin compatible with trino 478. [hudi]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #14299:
URL: https://github.com/apache/hudi/pull/14299#discussion_r2569899801
##########
hudi-trino-plugin/src/main/java/io/trino/plugin/hudi/HudiModule.java:
##########
@@ -59,7 +58,6 @@ public void configure(Binder binder)
configBinder(binder).bindConfig(HudiConfig.class);
- binder.bind(boolean.class).annotatedWith(TranslateHiveViews.class).toInstance(false);
Review Comment:
cc @voonhous @vamsikarnika
I think it requires more thoughts on how to let the OSS Trino repo use the connector code here. I agree that there should only one place the Hudi connector code is maintained. Ideally, that single place should be the OSS Trino repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: update dependencies and to make trino-hudi-plugin compatible with trino 478. [hudi]
Posted by "voonhous (via GitHub) via commits" <co...@hudi.apache.org>.
voonhous closed pull request #14299: feat: update dependencies and to make trino-hudi-plugin compatible with trino 478.
URL: https://github.com/apache/hudi/pull/14299
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: update dependencies and to make trino-hudi-plugin compatible with trino 478. [hudi]
Posted by "vinothchandar (via GitHub)" <gi...@apache.org>.
vinothchandar commented on PR #14299:
URL: https://github.com/apache/hudi/pull/14299#issuecomment-3555017814
@voonhous @yihua Can one of you review this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: update dependencies and to make trino-hudi-plugin compatible with trino 478. [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #14299:
URL: https://github.com/apache/hudi/pull/14299#issuecomment-3559590048
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4ba9cb908baee11a25ee584d53b848daf1a8e000",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9600",
"triggerID" : "4ba9cb908baee11a25ee584d53b848daf1a8e000",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4ba9cb908baee11a25ee584d53b848daf1a8e000 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=9600)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: update dependencies and to make trino-hudi-plugin compatible with trino 478. [hudi]
Posted by "RatulDawar (via GitHub)" <gi...@apache.org>.
RatulDawar commented on code in PR #14299:
URL: https://github.com/apache/hudi/pull/14299#discussion_r2565950361
##########
hudi-trino-plugin/src/main/java/io/trino/plugin/hudi/HudiModule.java:
##########
@@ -59,7 +58,6 @@ public void configure(Binder binder)
configBinder(binder).bindConfig(HudiConfig.class);
- binder.bind(boolean.class).annotatedWith(TranslateHiveViews.class).toInstance(false);
Review Comment:
https://github.com/trinodb/trino/pull/25284
Yes in the above PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: update dependencies and to make trino-hudi-plugin compatible with trino 478. [hudi]
Posted by "RatulDawar (via GitHub)" <gi...@apache.org>.
RatulDawar commented on code in PR #14299:
URL: https://github.com/apache/hudi/pull/14299#discussion_r2565932235
##########
hudi-trino-plugin/src/main/java/io/trino/plugin/hudi/HudiBaseFileOnlyPageSource.java:
##########
@@ -84,9 +85,10 @@ public boolean isFinished()
}
@Override
- public Page getNextPage()
+ public SourcePage getNextSourcePage()
{
- Page physicalSourcePage = dataPageSource.getNextPage();
+ //TODO hudi can have it's own lazy loading Implementation for further optimization of data scan
Review Comment:
Sure, @yihua creating a same for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: update dependencies and to make trino-hudi-plugin compatible with trino 478. [hudi]
Posted by "voonhous (via GitHub) via commits" <co...@hudi.apache.org>.
voonhous commented on PR #14299:
URL: https://github.com/apache/hudi/pull/14299#issuecomment-6700829038
Temporarily closing this PR while we debug a GitHub settings error on master (#20471); it will be reopened shortly, no action needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: update dependencies and to make trino-hudi-plugin compatible with trino 478. [hudi]
Posted by "RatulDawar (via GitHub)" <gi...@apache.org>.
RatulDawar commented on code in PR #14299:
URL: https://github.com/apache/hudi/pull/14299#discussion_r2569945095
##########
hudi-trino-plugin/src/main/java/io/trino/plugin/hudi/HudiModule.java:
##########
@@ -59,7 +58,6 @@ public void configure(Binder binder)
configBinder(binder).bindConfig(HudiConfig.class);
- binder.bind(boolean.class).annotatedWith(TranslateHiveViews.class).toInstance(false);
Review Comment:
@yihua So we were having this discussion here -> [Slack thread](https://apache-hudi.slack.com/archives/C4D716NPQ/p1762846511135559)
I am open to discuss this. I as a trino user want all the functionality that this plugin provides with latest trino version. Which this divergence makes it difficult to do so.
Anyways we can discuss this parallely after making this compatibilty work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: update dependencies and to make trino-hudi-plugin compatible with trino 478. [hudi]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #14299:
URL: https://github.com/apache/hudi/pull/14299#discussion_r2547779915
##########
hudi-trino-plugin/src/main/java/io/trino/plugin/hudi/HudiBaseFileOnlyPageSource.java:
##########
@@ -84,9 +85,10 @@ public boolean isFinished()
}
@Override
- public Page getNextPage()
+ public SourcePage getNextSourcePage()
{
- Page physicalSourcePage = dataPageSource.getNextPage();
+ //TODO hudi can have it's own lazy loading Implementation for further optimization of data scan
Review Comment:
@RatulDawar thanks for bringing this up. Could you file a GH issue to track this?
##########
hudi-trino-plugin/src/main/java/io/trino/plugin/hudi/HudiModule.java:
##########
@@ -59,7 +58,6 @@ public void configure(Binder binder)
configBinder(binder).bindConfig(HudiConfig.class);
- binder.bind(boolean.class).annotatedWith(TranslateHiveViews.class).toInstance(false);
Review Comment:
Is `TranslateHiveViews` no longer used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: update dependencies and to make trino-hudi-plugin compatible with trino 478. [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #14299:
URL: https://github.com/apache/hudi/pull/14299#issuecomment-3549717747
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4ba9cb908baee11a25ee584d53b848daf1a8e000",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4ba9cb908baee11a25ee584d53b848daf1a8e000",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4ba9cb908baee11a25ee584d53b848daf1a8e000 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: update dependencies and to make trino-hudi-plugin compatible with trino 478. [hudi]
Posted by "RatulDawar (via GitHub)" <gi...@apache.org>.
RatulDawar commented on PR #14299:
URL: https://github.com/apache/hudi/pull/14299#issuecomment-3549727842
Related issue : https://github.com/apache/hudi/pull/14299
@voonhous This PR makes hudi-plugin compatible with 478.
Steps after this.
1. Add features that are in trino-plugin but not in hudi.
2. Final changes in trino
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: update dependencies and to make trino-hudi-plugin compatible with trino 478. [hudi]
Posted by "RatulDawar (via GitHub)" <gi...@apache.org>.
RatulDawar commented on code in PR #14299:
URL: https://github.com/apache/hudi/pull/14299#discussion_r2565965257
##########
hudi-trino-plugin/src/main/java/io/trino/plugin/hudi/HudiModule.java:
##########
@@ -59,7 +58,6 @@ public void configure(Binder binder)
configBinder(binder).bindConfig(HudiConfig.class);
- binder.bind(boolean.class).annotatedWith(TranslateHiveViews.class).toInstance(false);
Review Comment:
Also @yihua the purpose of this was to make this repo the source of truth of trino-hudi-plugin. I wanted your opinion on how to to it. What I want to achieve is that the original trino repo imports from the master of this branch.
Can we discuss the best way to this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org