You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jetspeed-dev@portals.apache.org by Santiago Gala <sg...@hisitech.com> on 2001/04/23 18:49:15 UTC

Re: Jakarta-Jetspeed Bug in

Turpin, Jay wrote:

> Hello,
> 
> I am not sure about the proper way to submit a bug found in the latest CVS
> code. Please educate.
> 
> However, in the following files:
> 
> jakarta-jetspeed\bin\webapp\WEB-INF\templates\jsp\screens\html\de\EditAccoun
> t.jsp
> jakarta-jetspeed\bin\webapp\WEB-INF\templates\jsp\screens\html\en\EditAccoun
> t.jsp
> 
> Line 20 need to be changed from:
> 
>         <%@ include file="ErrorNoScreenData.inc" %>
> 
> to
> 
>         <%@ include file="../ErrorNoScreenData.inc" %>
> 

I think it is not that simple. Ideally, the include should be given a 
path after passing through the hierarchical path resolution strategy 
aimed to resolve language and media dependencies. Possibly something 
like having a taglib that would locate the most "local" included file 
first...

I'm not sure on how to do this in a way that is compatible with turbine, 
jsp, velocity and xslt. In the case of xslt there is a handy shortcut in 
the EntityResolver, which is called for all resources that the 
stylesheet needs to fetch.

Any ideas?


> Regards,
> Jay Turpin
> Intel Corporation
> 
> 
> -----Original Message-----
> From: taylor@apache.org [mailto:taylor@apache.org]
> Sent: Sunday, April 22, 2001 10:19 PM
> To: jakarta-jetspeed-cvs@apache.org
> Subject: cvs commit:
> jakarta-jetspeed/webapp/WEB-INF/templates/vm/screens/html Error.vm
> 
> 
> taylor      01/04/22 22:18:36
> 
>   Modified:    webapp/WEB-INF/templates/vm/screens/html Error.vm
>   Log:
>   Enhanced Error information from Johnny Cass
>   
>   Revision  Changes    Path
>   1.3       +67 -14
> jakarta-jetspeed/webapp/WEB-INF/templates/vm/screens/html/Error.vm
>   
>   Index: Error.vm
>   ===================================================================
>   RCS file:
> /home/cvs/jakarta-jetspeed/webapp/WEB-INF/templates/vm/screens/html/Error.vm
> ,v
>   retrieving revision 1.2
>   retrieving revision 1.3
>   diff -u -r1.2 -r1.3
>   --- Error.vm	2001/04/19 23:21:15	1.2
>   +++ Error.vm	2001/04/23 05:18:36	1.3
>   @@ -1,18 +1,71 @@
>    $page.setTitle("Error")
>    
>   -$page.setBgColor("#ffffff")
>   +<table border=1 cellpadding="5"> 
>   +  #* Error Message *#
>   +  <tr> 
>   +    <td>
>   +      <br>
>   +      <h2>There has been an Error!</h2>
>   +      Reason:
>   +      <pre>
>   +        $!data.stackTraceException.toString()
>   +      </pre>
>   +    </td>
>   +  </tr> 
>   +
>   +  #* HTTP Parameters *#
>   +  #set ( $keys = $data.getParameters().keys() )
>   +  #if ( $keys )
>   +    <tr> 
>   +      <td>
>   +        <br>
>   +        <h3>Get/Post Data:</h3>
>   +        <table border=0>           
>   +          #foreach ( $key in $keys )                      
>   +            <tr>
>   +              <td><b> $key </b></td>
>   +              <td> = $data.getParameters().getString( $key )</td>
>   +            <tr>
>   +          #end          
>   +        </table>
>   +      </td> 
>   +    </tr> 
>   +  #end
>   +
>   +  #* Debug Keys *#
>   +  #set ( $keys = $data.getVarDebug().keys() )
>   +  #if ( $keys )
>   +    #if ( $keys.hasMoreElements() )
>   +      <tr> 
>   +        <td>
>   +          <br>
>   +          <h3>Debugging Data:</h3>
>   +          <table border=0> 
>   +            #foreach ( $key in $keys )            
>   +              <tr>
>   +                <td><b> $key </b></td>
>   +                <td> = $data.getVarDebug().get( $key ) </td>
>   +              <tr>
>   +            #end
>   +          </table>
>   +        </td> 
>   +      </tr> 
>   +    #end
>   +  #end
>   +
>   +  #* Stacktrace *#
>   +  #if ( $data.getStackTrace() )
>   +    <tr> 
>   +      <td>
>   +        <br>
>   +        <h3>Stacktrace:</h3>
>   +        <pre>      
>   +          $data.getStackTrace()      
>   +        </pre>
>   +      </td> 
>   +    </tr>
>   +  #end
>   +</table> 
>   + 
>    
>   -<font face="verdana,geneva,helvetica">
>    
>   -<h2>Error</h2>
>   -
>   -#if( $data.getMessage() )
>   -
>   -    Message: <br>$data.getMessage() <br><br>
>   -    StackTrace: <br>$data.getStackTrace() <br>
>   -
>   -#end
>   -
>   -</font>
>   -
>   -<br>
>   
>   
>   
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: jetspeed-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: jetspeed-dev-help@jakarta.apache.org
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: jetspeed-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: jetspeed-dev-help@jakarta.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jetspeed-dev-help@jakarta.apache.org


RE: Jakarta-Jetspeed Bug in

Posted by Ingo Schuster <in...@raleigh.ibm.com>.
At 19:23 04/23/01, David Sean Taylor wrote:
> > I think it is not that simple. Ideally, the include should be given a
> > path after passing through the hierarchical path resolution strategy
> > aimed to resolve language and media dependencies. Possibly something
> > like having a taglib that would locate the most "local" included file
> > first...
>
>It would be nice to have a tag that does the same as the standard jsp
>'include' but uses the language/media fallback algorithm.

Yes the "ResourceLocatorService" with a respective tag... Let's see when I 
find some time for it.

>Jay's patch keeps jsp from always erroring out about the missing include
>file, which is good fix for now.
>However i just noticed that the german template is including english. I
>could fix that, although my german wouldn't be pretty.

I think my idea was that this is only displayed when a serious error 
occurs, and in this case an english error message is ok. (Keeps the number 
of template files smaller.) But if you want it all pretty and clean, here's 
a translation: ;-)

>Any German speaking volunteers to translate this:

<%-- This screen be shown (using "include file") by other screens if they 
can't find the ScreenData hashtable  --%>

<table border=1 cellpadding="5">

   <tr>
     <td>
       <br>
       <h2>Das Screen-Template konnte die nötigen Daten("ScreenData") im 
Kontext nicht finden!</h2>
       Wahrscheinlich ist die PrepareScreen-Action nicht ausgeführt worden. 
Bitte überprüfen sie die URL auf Richtigkeit.
     </td>
   </tr>

</table>


><%-- This screen be shown (using "include file") by other screens if they
>can't find the ScreenData hashtable  --%>
>
><table border=1 cellpadding="5">
>
>   <tr>
>     <td>
>       <br>
>       <h2>The screen template couldn't find its ScreenData in the
>context!</h2>
>       It seems as if the PrepareScreen action hasn't been executed. Please
>check if the requested URL is correct.
>     </td>
>   </tr>
>
></table>
>
>I can then move the includes into their respective language directories
>
>- david
>
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: jetspeed-dev-unsubscribe@jakarta.apache.org
>For additional commands, e-mail: jetspeed-dev-help@jakarta.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jetspeed-dev-help@jakarta.apache.org


RE: Jakarta-Jetspeed Bug in

Posted by David Sean Taylor <da...@bluesunrise.com>.
> I think it is not that simple. Ideally, the include should be given a
> path after passing through the hierarchical path resolution strategy
> aimed to resolve language and media dependencies. Possibly something
> like having a taglib that would locate the most "local" included file
> first...

It would be nice to have a tag that does the same as the standard jsp
'include' but uses the language/media fallback algorithm.
Jay's patch keeps jsp from always erroring out about the missing include
file, which is good fix for now.
However i just noticed that the german template is including english. I
could fix that, although my german wouldn't be pretty.
Any German speaking volunteers to translate this:

<%-- This screen be shown (using "include file") by other screens if they
can't find the ScreenData hashtable  --%>

<table border=1 cellpadding="5">

  <tr>
    <td>
      <br>
      <h2>The screen template couldn't find its ScreenData in the
context!</h2>
      It seems as if the PrepareScreen action hasn't been executed. Please
check if the requested URL is correct.
    </td>
  </tr>

</table>

I can then move the includes into their respective language directories

- david



---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jetspeed-dev-help@jakarta.apache.org