[PR] KAFKA-20860: Retry consumer reconciliation after synchronous failure [kafka]

["lh0156 (via GitHub)" <gi...@apache.org>]

lh0156 opened a new pull request, #23023:
URL: https://github.com/apache/kafka/pull/23023

   ### Summary
   - Reset the reconciliation-in-progress latch when synchronous reconciliation setup fails.
   - Handle synchronous failures while starting revocation and assignment without breaking the consumer background loop.
   - Add regression coverage proving the next reconciliation loop retries successfully.
   
   ### Motivation
   A RuntimeException thrown after reconciliation starts but before its asynchronous future chain is established can leave the membership manager permanently stuck because `reconciliationInProgress` remains true. This change treats that setup failure as a failed attempt, preserves the existing auto-commit failure behavior, and allows the next poll to retry.
   
   ### Testing
   - `./gradlew :clients:test --tests org.apache.kafka.clients.consumer.internals.ConsumerMembershipManagerTest`
   - `./gradlew :clients:test --tests org.apache.kafka.clients.consumer.internals.ConsumerMembershipManagerTest --tests org.apache.kafka.clients.consumer.internals.StreamsMembershipManagerTest --tests org.apache.kafka.clients.consumer.internals.ShareMembershipManagerTest`
   - `./gradlew :clients:check --no-build-cache --console=plain`
   
   Fixes KAFKA-20860


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-20860: Retry consumer reconciliation after synchronous failure [kafka]

["lianetm (via GitHub)" <gi...@apache.org>]

lianetm commented on PR #23023:
URL: https://github.com/apache/kafka/pull/23023#issuecomment-5207342111

   Thanks for looking into this @lh0156 ! I left a [comment](https://issues.apache.org/jira/browse/KAFKA-20860?focusedCommentId=18102485&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-18102485) in jira mentioning how I don't see how this could be reachable. Am I missing a case where we could indeed have such "sync failure" in that section of the code? Or was the motivation here just to be defensive?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-20860: Retry consumer reconciliation after synchronous failure [kafka]

["github-actions[bot] (via GitHub)" <gi...@apache.org>]

github-actions[bot] commented on PR #23023:
URL: https://github.com/apache/kafka/pull/23023#issuecomment-5235602825

   A label of 'needs-attention' was automatically added to this PR in order to raise the
   attention of the committers. Once this issue has been triaged, the `triage` label
   should be removed to prevent this automation from happening again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org