You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by zh...@apache.org on 2020/09/16 09:11:29 UTC
[hbase] branch HBASE-25021 updated (d0d5170 -> b69efaa)
This is an automated email from the ASF dual-hosted git repository.
zhangduo pushed a change to branch HBASE-25021
in repository https://gitbox.apache.org/repos/asf/hbase.git.
discard d0d5170 fix version when debug is on
discard ea3efe2 add more debug log
discard 5288f08 add more debug log
discard 4ccc19d add debug info
discard f518cf3 fix script error and disable all other stages
discard dc560f1 HBASE-25021 Nightly job should skip hadoop-2 integration test for master
add 325317f HBASE-24831 : Addendum for source compatibility
add ca96f96 HBASE-25014 ScheduledChore is never triggered when initalDelay > 1.5*period (#2395)
add 6d985dd HBASE-25009: Hbck chore logs wrong message when loading regions from RS (#2379)
add c5ca191 HBASE-24875 Remove the force param for unassign since it dose not take effect any more (#2254)
new bfc9d562 HBASE-25021 Nightly job should skip hadoop-2 integration test for master
new 93e1e3e fix script error and disable all other stages
new c69e77a add debug info
new ae8e15b add more debug log
new b1289c9 add more debug log
new 4955c48 fix version when debug is on
new b69efaa fix hang
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (d0d5170)
\
N -- N -- N refs/heads/HBASE-25021 (b69efaa)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
The 7 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../java/org/apache/hadoop/hbase/client/Admin.java | 16 +++++++++--
.../hadoop/hbase/client/AdminOverAsyncAdmin.java | 4 +--
.../org/apache/hadoop/hbase/client/AsyncAdmin.java | 13 ++++++++-
.../hadoop/hbase/client/AsyncConnectionImpl.java | 6 ++--
.../hadoop/hbase/client/AsyncHBaseAdmin.java | 4 +--
.../hadoop/hbase/client/RawAsyncHBaseAdmin.java | 4 +--
.../apache/hadoop/hbase/ipc/AbstractRpcClient.java | 12 ++++----
.../hbase/shaded/protobuf/RequestConverter.java | 4 +--
.../org/apache/hadoop/hbase/ScheduledChore.java | 2 +-
.../org/apache/hadoop/hbase/TestChoreService.java | 25 ++++++++++++++++-
.../hbase/mapreduce/TableRecordReaderImpl.java | 32 ++++++++++++++++++++++
.../src/main/protobuf/server/master/Master.proto | 1 +
.../protobuf/server/master/MasterProcedure.proto | 1 +
.../hadoop/hbase/coprocessor/MasterObserver.java | 10 +++----
.../org/apache/hadoop/hbase/master/HbckChore.java | 2 +-
.../hadoop/hbase/master/MasterCoprocessorHost.java | 9 +++---
.../hadoop/hbase/master/MasterRpcServices.java | 7 ++---
.../hbase/master/assignment/UnassignProcedure.java | 6 ----
.../hbase/security/access/AccessController.java | 4 +--
.../hbase/coprocessor/TestMasterObserver.java | 4 +--
.../hbase/rsgroup/VerifyingRSGroupAdmin.java | 4 +--
.../security/access/TestAccessController.java | 2 +-
.../access/TestWithDisabledAuthorization.java | 3 +-
hbase-shell/src/main/ruby/hbase/admin.rb | 5 ++--
.../src/main/ruby/shell/commands/unassign.rb | 10 ++-----
.../hadoop/hbase/thrift2/client/ThriftAdmin.java | 3 +-
26 files changed, 128 insertions(+), 65 deletions(-)
[hbase] 02/07: fix script error and disable all other stages
Posted by zh...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
zhangduo pushed a commit to branch HBASE-25021
in repository https://gitbox.apache.org/repos/asf/hbase.git
commit 93e1e3e0475085fc3d0575015c5bf34246b25989
Author: Duo Zhang <zh...@apache.org>
AuthorDate: Tue Sep 15 14:25:31 2020 +0800
fix script error and disable all other stages
---
dev-support/Jenkinsfile | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/dev-support/Jenkinsfile b/dev-support/Jenkinsfile
index 61a4c20..312f9f1 100644
--- a/dev-support/Jenkinsfile
+++ b/dev-support/Jenkinsfile
@@ -195,6 +195,9 @@ pipeline {
label 'Hadoop'
}
}
+ when {
+ branch 'branch-1*'
+ }
environment {
BASEDIR = "${env.WORKSPACE}/component"
TESTS = "${env.SHALLOW_CHECKS}"
@@ -423,9 +426,9 @@ pipeline {
}
}
when {
- not {
+ //not {
branch 'branch-1*'
- }
+ //}
}
environment {
BASEDIR = "${env.WORKSPACE}/component"
@@ -508,9 +511,9 @@ pipeline {
}
}
when {
- not {
+ //not {
branch 'branch-1*'
- }
+ //}
}
environment {
BASEDIR = "${env.WORKSPACE}/component"
@@ -712,6 +715,7 @@ pipeline {
exit 2
fi
echo "(/) {color:green}+1 client integration test{color}" >output-integration/commentfile
+ fi
'''
[hbase] 03/07: add debug info
Posted by zh...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
zhangduo pushed a commit to branch HBASE-25021
in repository https://gitbox.apache.org/repos/asf/hbase.git
commit c69e77a0a72ae850d4e2a3b9b27cb5aece75176b
Author: Duo Zhang <zh...@apache.org>
AuthorDate: Tue Sep 15 16:24:29 2020 +0800
add debug info
---
dev-support/hbase_nightly_pseudo-distributed-test.sh | 3 +++
1 file changed, 3 insertions(+)
diff --git a/dev-support/hbase_nightly_pseudo-distributed-test.sh b/dev-support/hbase_nightly_pseudo-distributed-test.sh
index b5fdf99..b881e3f 100755
--- a/dev-support/hbase_nightly_pseudo-distributed-test.sh
+++ b/dev-support/hbase_nightly_pseudo-distributed-test.sh
@@ -179,6 +179,9 @@ echo "HBase version information:"
hbase_version=$("${component_install}/bin/hbase" version | head -n 1 2>/dev/null)
hbase_version="${hbase_version#HBase }"
+echo "${hbase_client}/lib/shaded-clients"
+ls -R ${hbase_client}
+
if [ ! -s "${hbase_client}/lib/shaded-clients/hbase-shaded-mapreduce-${hbase_version}.jar" ]; then
echo "HBase binary install doesn't appear to include a shaded mapreduce artifact." >&2
exit 1
[hbase] 06/07: fix version when debug is on
Posted by zh...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
zhangduo pushed a commit to branch HBASE-25021
in repository https://gitbox.apache.org/repos/asf/hbase.git
commit 4955c48d6675564e463650b053ca7bdd8f990ec4
Author: Duo Zhang <zh...@apache.org>
AuthorDate: Tue Sep 15 17:41:24 2020 +0800
fix version when debug is on
---
dev-support/hbase_nightly_pseudo-distributed-test.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dev-support/hbase_nightly_pseudo-distributed-test.sh b/dev-support/hbase_nightly_pseudo-distributed-test.sh
index ff4d773..9a00fc5 100755
--- a/dev-support/hbase_nightly_pseudo-distributed-test.sh
+++ b/dev-support/hbase_nightly_pseudo-distributed-test.sh
@@ -176,7 +176,7 @@ fi
echo "HBase version information:"
"${component_install}/bin/hbase" version 2>/dev/null
-hbase_version=$("${component_install}/bin/hbase" version | head -n 1 2>/dev/null)
+hbase_version=$("${component_install}/bin/hbase" version 2>&1 | grep ^HBase | head -n 1)
hbase_version="${hbase_version#HBase }"
echo "version is $hbase_version"
[hbase] 04/07: add more debug log
Posted by zh...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
zhangduo pushed a commit to branch HBASE-25021
in repository https://gitbox.apache.org/repos/asf/hbase.git
commit ae8e15b09e7c7cc0a08dda4ad69bf11d1d3b2baf
Author: Duo Zhang <zh...@apache.org>
AuthorDate: Tue Sep 15 16:57:32 2020 +0800
add more debug log
---
dev-support/hbase_nightly_pseudo-distributed-test.sh | 2 ++
1 file changed, 2 insertions(+)
diff --git a/dev-support/hbase_nightly_pseudo-distributed-test.sh b/dev-support/hbase_nightly_pseudo-distributed-test.sh
index b881e3f..496b331 100755
--- a/dev-support/hbase_nightly_pseudo-distributed-test.sh
+++ b/dev-support/hbase_nightly_pseudo-distributed-test.sh
@@ -179,8 +179,10 @@ echo "HBase version information:"
hbase_version=$("${component_install}/bin/hbase" version | head -n 1 2>/dev/null)
hbase_version="${hbase_version#HBase }"
+echo "version is $hbase_version"
echo "${hbase_client}/lib/shaded-clients"
ls -R ${hbase_client}
+ls "${hbase_client}/lib/shaded-clients/hbase-shaded-mapreduce-${hbase_version}.jar"
if [ ! -s "${hbase_client}/lib/shaded-clients/hbase-shaded-mapreduce-${hbase_version}.jar" ]; then
echo "HBase binary install doesn't appear to include a shaded mapreduce artifact." >&2
[hbase] 01/07: HBASE-25021 Nightly job should skip hadoop-2
integration test for master
Posted by zh...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
zhangduo pushed a commit to branch HBASE-25021
in repository https://gitbox.apache.org/repos/asf/hbase.git
commit bfc9d562b812b5bf2092e38ee0a1c9102b22e0bc
Author: Duo Zhang <zh...@apache.org>
AuthorDate: Mon Sep 14 22:55:48 2020 +0800
HBASE-25021 Nightly job should skip hadoop-2 integration test for master
---
dev-support/Jenkinsfile | 108 ++++++++++++++++++++++++++----------------------
1 file changed, 58 insertions(+), 50 deletions(-)
diff --git a/dev-support/Jenkinsfile b/dev-support/Jenkinsfile
index e654ffe..61a4c20 100644
--- a/dev-support/Jenkinsfile
+++ b/dev-support/Jenkinsfile
@@ -599,6 +599,7 @@ pipeline {
}
environment {
BASEDIR = "${env.WORKSPACE}/component"
+ BRANCH = "${env.BRANCH_NAME}"
}
steps {
sh '''#!/bin/bash -e
@@ -649,61 +650,68 @@ pipeline {
tar --strip-component=1 -xzf "${client_artifact}" -C "hbase-client"
'''
unstash 'hadoop-2'
- echo "Attempting to use run an instance on top of Hadoop 2."
sh '''#!/bin/bash -xe
- artifact=$(ls -1 "${WORKSPACE}"/hadoop-2*.tar.gz | head -n 1)
- tar --strip-components=1 -xzf "${artifact}" -C "hadoop-2"
- if ! "${BASEDIR}/dev-support/hbase_nightly_pseudo-distributed-test.sh" \
- --single-process \
- --working-dir output-integration/hadoop-2 \
- --hbase-client-install "hbase-client" \
- "hbase-install" \
- "hadoop-2/bin/hadoop" \
- hadoop-2/share/hadoop/yarn/timelineservice \
- hadoop-2/share/hadoop/yarn/test/hadoop-yarn-server-tests-*-tests.jar \
- hadoop-2/share/hadoop/mapreduce/hadoop-mapreduce-client-jobclient-*-tests.jar \
- hadoop-2/bin/mapred \
- >output-integration/hadoop-2.log 2>&1 ; then
- echo "(x) {color:red}-1 client integration test{color}\n--Failed when running client tests on top of Hadoop 2. [see log for details|${BUILD_URL}/artifact/output-integration/hadoop-2.log]. (note that this means we didn't run on Hadoop 3)" >output-integration/commentfile
- exit 2
+ if [[ "${BRANCH}" = branch-2* ]] || [[ "${BRANCH}" = branch-1* ]]; then
+ echo "Attempting to use run an instance on top of Hadoop 2."
+ artifact=$(ls -1 "${WORKSPACE}"/hadoop-2*.tar.gz | head -n 1)
+ tar --strip-components=1 -xzf "${artifact}" -C "hadoop-2"
+ if ! "${BASEDIR}/dev-support/hbase_nightly_pseudo-distributed-test.sh" \
+ --single-process \
+ --working-dir output-integration/hadoop-2 \
+ --hbase-client-install "hbase-client" \
+ "hbase-install" \
+ "hadoop-2/bin/hadoop" \
+ hadoop-2/share/hadoop/yarn/timelineservice \
+ hadoop-2/share/hadoop/yarn/test/hadoop-yarn-server-tests-*-tests.jar \
+ hadoop-2/share/hadoop/mapreduce/hadoop-mapreduce-client-jobclient-*-tests.jar \
+ hadoop-2/bin/mapred \
+ >output-integration/hadoop-2.log 2>&1 ; then
+ echo "(x) {color:red}-1 client integration test{color}\n--Failed when running client tests on top of Hadoop 2. [see log for details|${BUILD_URL}/artifact/output-integration/hadoop-2.log]. (note that this means we didn't run on Hadoop 3)" >output-integration/commentfile
+ exit 2
+ fi
+ else
+ echo "Skipping to run against Hadoop 2 for branch ${BRANCH}"
fi
'''
unstash 'hadoop-3'
- echo "Attempting to use run an instance on top of Hadoop 3."
sh '''#!/bin/bash -e
- artifact=$(ls -1 "${WORKSPACE}"/hadoop-3*.tar.gz | head -n 1)
- tar --strip-components=1 -xzf "${artifact}" -C "hadoop-3"
- if ! "${BASEDIR}/dev-support/hbase_nightly_pseudo-distributed-test.sh" \
- --single-process \
- --working-dir output-integration/hadoop-3 \
- --hbase-client-install hbase-client \
- hbase-install \
- hadoop-3/bin/hadoop \
- hadoop-3/share/hadoop/yarn/timelineservice \
- hadoop-3/share/hadoop/yarn/test/hadoop-yarn-server-tests-*-tests.jar \
- hadoop-3/share/hadoop/mapreduce/hadoop-mapreduce-client-jobclient-*-tests.jar \
- hadoop-3/bin/mapred \
- >output-integration/hadoop-3.log 2>&1 ; then
- echo "(x) {color:red}-1 client integration test{color}\n--Failed when running client tests on top of Hadoop 3. [see log for details|${BUILD_URL}/artifact/output-integration/hadoop-3.log]. (note that this means we didn't check the Hadoop 3 shaded client)" >output-integration/commentfile
- exit 2
- fi
- echo "Attempting to use run an instance on top of Hadoop 3, relying on the Hadoop client artifacts for the example client program."
- if ! "${BASEDIR}/dev-support/hbase_nightly_pseudo-distributed-test.sh" \
- --single-process \
- --hadoop-client-classpath hadoop-3/share/hadoop/client/hadoop-client-api-*.jar:hadoop-3/share/hadoop/client/hadoop-client-runtime-*.jar \
- --working-dir output-integration/hadoop-3-shaded \
- --hbase-client-install hbase-client \
- hbase-install \
- hadoop-3/bin/hadoop \
- hadoop-3/share/hadoop/yarn/timelineservice \
- hadoop-3/share/hadoop/yarn/test/hadoop-yarn-server-tests-*-tests.jar \
- hadoop-3/share/hadoop/mapreduce/hadoop-mapreduce-client-jobclient-*-tests.jar \
- hadoop-3/bin/mapred \
- >output-integration/hadoop-3-shaded.log 2>&1 ; then
- echo "(x) {color:red}-1 client integration test{color}\n--Failed when running client tests on top of Hadoop 3 using Hadoop's shaded client. [see log for details|${BUILD_URL}/artifact/output-integration/hadoop-3-shaded.log]." >output-integration/commentfile
- exit 2
- fi
- echo "(/) {color:green}+1 client integration test{color}" >output-integration/commentfile
+ if [[ "${BRANCH}" = branch-1* ]]; then
+ echo "Skipping to run against Hadoop 3 for branch ${BRANCH}"
+ else
+ echo "Attempting to use run an instance on top of Hadoop 3."
+ artifact=$(ls -1 "${WORKSPACE}"/hadoop-3*.tar.gz | head -n 1)
+ tar --strip-components=1 -xzf "${artifact}" -C "hadoop-3"
+ if ! "${BASEDIR}/dev-support/hbase_nightly_pseudo-distributed-test.sh" \
+ --single-process \
+ --working-dir output-integration/hadoop-3 \
+ --hbase-client-install hbase-client \
+ hbase-install \
+ hadoop-3/bin/hadoop \
+ hadoop-3/share/hadoop/yarn/timelineservice \
+ hadoop-3/share/hadoop/yarn/test/hadoop-yarn-server-tests-*-tests.jar \
+ hadoop-3/share/hadoop/mapreduce/hadoop-mapreduce-client-jobclient-*-tests.jar \
+ hadoop-3/bin/mapred \
+ >output-integration/hadoop-3.log 2>&1 ; then
+ echo "(x) {color:red}-1 client integration test{color}\n--Failed when running client tests on top of Hadoop 3. [see log for details|${BUILD_URL}/artifact/output-integration/hadoop-3.log]. (note that this means we didn't check the Hadoop 3 shaded client)" >output-integration/commentfile
+ exit 2
+ fi
+ echo "Attempting to use run an instance on top of Hadoop 3, relying on the Hadoop client artifacts for the example client program."
+ if ! "${BASEDIR}/dev-support/hbase_nightly_pseudo-distributed-test.sh" \
+ --single-process \
+ --hadoop-client-classpath hadoop-3/share/hadoop/client/hadoop-client-api-*.jar:hadoop-3/share/hadoop/client/hadoop-client-runtime-*.jar \
+ --working-dir output-integration/hadoop-3-shaded \
+ --hbase-client-install hbase-client \
+ hbase-install \
+ hadoop-3/bin/hadoop \
+ hadoop-3/share/hadoop/yarn/timelineservice \
+ hadoop-3/share/hadoop/yarn/test/hadoop-yarn-server-tests-*-tests.jar \
+ hadoop-3/share/hadoop/mapreduce/hadoop-mapreduce-client-jobclient-*-tests.jar \
+ hadoop-3/bin/mapred \
+ >output-integration/hadoop-3-shaded.log 2>&1 ; then
+ echo "(x) {color:red}-1 client integration test{color}\n--Failed when running client tests on top of Hadoop 3 using Hadoop's shaded client. [see log for details|${BUILD_URL}/artifact/output-integration/hadoop-3-shaded.log]." >output-integration/commentfile
+ exit 2
+ fi
+ echo "(/) {color:green}+1 client integration test{color}" >output-integration/commentfile
'''
[hbase] 07/07: fix hang
Posted by zh...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
zhangduo pushed a commit to branch HBASE-25021
in repository https://gitbox.apache.org/repos/asf/hbase.git
commit b69efaa9c2fa25e2b68e9a5d373126f8723f5ea4
Author: Duo Zhang <zh...@apache.org>
AuthorDate: Wed Sep 16 17:10:34 2020 +0800
fix hang
---
.../org/apache/hadoop/hbase/client/AsyncConnectionImpl.java | 6 +++---
.../java/org/apache/hadoop/hbase/ipc/AbstractRpcClient.java | 12 ++++++------
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncConnectionImpl.java b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncConnectionImpl.java
index 896b7dc..97b70e1 100644
--- a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncConnectionImpl.java
+++ b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncConnectionImpl.java
@@ -77,9 +77,9 @@ class AsyncConnectionImpl implements AsyncConnection {
@VisibleForTesting
static final HashedWheelTimer RETRY_TIMER = new HashedWheelTimer(
- new ThreadFactoryBuilder().setNameFormat("Async-Client-Retry-Timer-pool-%d")
- .setUncaughtExceptionHandler(Threads.LOGGING_EXCEPTION_HANDLER).build(), 10,
- TimeUnit.MILLISECONDS);
+ new ThreadFactoryBuilder().setNameFormat("Async-Client-Retry-Timer-pool-%d").setDaemon(true)
+ .setUncaughtExceptionHandler(Threads.LOGGING_EXCEPTION_HANDLER).build(),
+ 10, TimeUnit.MILLISECONDS);
private static final String RESOLVE_HOSTNAME_ON_FAIL_KEY = "hbase.resolve.hostnames.on.failure";
diff --git a/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AbstractRpcClient.java b/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AbstractRpcClient.java
index bdf0801..d94f2d3 100644
--- a/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AbstractRpcClient.java
+++ b/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AbstractRpcClient.java
@@ -92,13 +92,13 @@ public abstract class AbstractRpcClient<T extends RpcConnection> implements RpcC
public static final Logger LOG = LoggerFactory.getLogger(AbstractRpcClient.class);
protected static final HashedWheelTimer WHEEL_TIMER = new HashedWheelTimer(
- new ThreadFactoryBuilder().setNameFormat("RpcClient-timer-pool-%d")
- .setUncaughtExceptionHandler(Threads.LOGGING_EXCEPTION_HANDLER).build(), 10,
- TimeUnit.MILLISECONDS);
+ new ThreadFactoryBuilder().setNameFormat("RpcClient-timer-pool-%d").setDaemon(true)
+ .setUncaughtExceptionHandler(Threads.LOGGING_EXCEPTION_HANDLER).build(),
+ 10, TimeUnit.MILLISECONDS);
- private static final ScheduledExecutorService IDLE_CONN_SWEEPER = Executors
- .newScheduledThreadPool(1,
- new ThreadFactoryBuilder().setNameFormat("Idle-Rpc-Conn-Sweeper-pool-%d")
+ private static final ScheduledExecutorService IDLE_CONN_SWEEPER =
+ Executors.newScheduledThreadPool(1,
+ new ThreadFactoryBuilder().setNameFormat("Idle-Rpc-Conn-Sweeper-pool-%d").setDaemon(true)
.setUncaughtExceptionHandler(Threads.LOGGING_EXCEPTION_HANDLER).build());
protected boolean running = true; // if client runs
[hbase] 05/07: add more debug log
Posted by zh...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
zhangduo pushed a commit to branch HBASE-25021
in repository https://gitbox.apache.org/repos/asf/hbase.git
commit b1289c932fe4c0021649e2237a5874587f151651
Author: Duo Zhang <zh...@apache.org>
AuthorDate: Tue Sep 15 17:02:21 2020 +0800
add more debug log
---
dev-support/hbase_nightly_pseudo-distributed-test.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dev-support/hbase_nightly_pseudo-distributed-test.sh b/dev-support/hbase_nightly_pseudo-distributed-test.sh
index 496b331..ff4d773 100755
--- a/dev-support/hbase_nightly_pseudo-distributed-test.sh
+++ b/dev-support/hbase_nightly_pseudo-distributed-test.sh
@@ -182,7 +182,7 @@ hbase_version="${hbase_version#HBase }"
echo "version is $hbase_version"
echo "${hbase_client}/lib/shaded-clients"
ls -R ${hbase_client}
-ls "${hbase_client}/lib/shaded-clients/hbase-shaded-mapreduce-${hbase_version}.jar"
+ls -al "${hbase_client}/lib/shaded-clients/hbase-shaded-mapreduce-${hbase_version}.jar"
if [ ! -s "${hbase_client}/lib/shaded-clients/hbase-shaded-mapreduce-${hbase_version}.jar" ]; then
echo "HBase binary install doesn't appear to include a shaded mapreduce artifact." >&2