You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2014/04/15 19:55:13 UTC
Review Request 20373: Added libprocess metrics to master/slave '/stats.json'.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20373/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
src/master/http.cpp 72d8e91013cd6a9c52a6d1ffdf517a52c4567bb7
src/slave/http.cpp 594032da1b2edd47961cd8201acd093b22fa30ae
src/tests/master_tests.cpp c047397654898b7b1715ee55c972b28c31f5b8c4
Diff: https://reviews.apache.org/r/20373/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 20373: Added libprocess metrics to master/slave
'/stats.json'.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20373/#review40441
-----------------------------------------------------------
Do we want to add this to masters and slaves? Given it's a temporary fix, we probably want to avoid adding too much extra data to the endpoints.
- Dominic Hamon
On April 15, 2014, 10:55 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20373/
> -----------------------------------------------------------
>
> (Updated April 15, 2014, 10:55 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/http.cpp 72d8e91013cd6a9c52a6d1ffdf517a52c4567bb7
> src/slave/http.cpp 594032da1b2edd47961cd8201acd093b22fa30ae
> src/tests/master_tests.cpp c047397654898b7b1715ee55c972b28c31f5b8c4
>
> Diff: https://reviews.apache.org/r/20373/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 20373: Added libprocess metrics to master/slave
'/stats.json'.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20373/#review41111
-----------------------------------------------------------
Patch looks great!
Reviews applied: [20373]
All tests passed.
- Mesos ReviewBot
On April 15, 2014, 5:55 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20373/
> -----------------------------------------------------------
>
> (Updated April 15, 2014, 5:55 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/http.cpp 72d8e91013cd6a9c52a6d1ffdf517a52c4567bb7
> src/slave/http.cpp 594032da1b2edd47961cd8201acd093b22fa30ae
> src/tests/master_tests.cpp c047397654898b7b1715ee55c972b28c31f5b8c4
>
> Diff: https://reviews.apache.org/r/20373/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 20373: Added libprocess metrics to master/slave
'/stats.json'.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20373/#review41106
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On April 15, 2014, 5:55 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20373/
> -----------------------------------------------------------
>
> (Updated April 15, 2014, 5:55 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/http.cpp 72d8e91013cd6a9c52a6d1ffdf517a52c4567bb7
> src/slave/http.cpp 594032da1b2edd47961cd8201acd093b22fa30ae
> src/tests/master_tests.cpp c047397654898b7b1715ee55c972b28c31f5b8c4
>
> Diff: https://reviews.apache.org/r/20373/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>