You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ignite.apache.org by av...@apache.org on 2021/03/24 08:09:31 UTC
[ignite] branch master updated: IGNITE-14377 : Enchance log of node
ping failure. (#8913)
This is an automated email from the ASF dual-hosted git repository.
av pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ignite.git
The following commit(s) were added to refs/heads/master by this push:
new 8d7a8eb IGNITE-14377 : Enchance log of node ping failure. (#8913)
8d7a8eb is described below
commit 8d7a8eb55701b78d79fdd945cfbf1bfc1f2665ac
Author: Vladimir Steshin <vl...@gmail.com>
AuthorDate: Wed Mar 24 11:09:10 2021 +0300
IGNITE-14377 : Enchance log of node ping failure. (#8913)
---
.../ignite/spi/discovery/tcp/ServerImpl.java | 29 ++++++++++++++--------
1 file changed, 19 insertions(+), 10 deletions(-)
diff --git a/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java b/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java
index 13410f5..2b0858c 100644
--- a/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java
+++ b/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java
@@ -881,8 +881,6 @@ class ServerImpl extends TcpDiscoveryImpl {
if (addr.isUnresolved())
addr = new InetSocketAddress(InetAddress.getByName(addr.getHostName()), addr.getPort());
- long tsNanos = System.nanoTime();
-
sock = spi.createSocket();
fut.sock = sock;
@@ -912,9 +910,8 @@ class ServerImpl extends TcpDiscoveryImpl {
}
catch (IOException | IgniteCheckedException e) {
if (nodeId != null && !nodeAlive(nodeId)) {
- if (log.isDebugEnabled())
- log.debug("Failed to ping the node (has left or leaving topology): [nodeId=" + nodeId +
- ']');
+ log.warning("Failed to ping node [nodeId=" + nodeId + "]. Node has left or is " +
+ "leaving topology. Cause: " + e.getMessage());
fut.onDone((IgniteBiTuple<UUID, Boolean>)null);
@@ -928,17 +925,29 @@ class ServerImpl extends TcpDiscoveryImpl {
reconCnt++;
- if (!openedSock && reconCnt == 2)
+ if (!openedSock && reconCnt == 2) {
+ log.warning("Failed to ping node [nodeId=" + nodeId + "]. Was unable to open the " +
+ "socket at all. Cause: " + e.getMessage());
+
break;
+ }
+
+ if (spi.failureDetectionTimeoutEnabled() && timeoutHelper.checkFailureTimeoutReached(e)) {
+ log.warning("Failed to ping node [nodeId=" + nodeId + "]. Reached the timeout " +
+ spi.failureDetectionTimeout() + "ms. Cause: " + e.getMessage());
- if (spi.failureDetectionTimeoutEnabled() && timeoutHelper.checkFailureTimeoutReached(e))
break;
- else if (!spi.failureDetectionTimeoutEnabled() && reconCnt == spi.getReconnectCount())
+ }
+ else if (!spi.failureDetectionTimeoutEnabled() && reconCnt == spi.getReconnectCount()) {
+ log.warning("Failed to ping node [nodeId=" + nodeId + "]. Reached the reconnection " +
+ "count " + spi.getReconnectCount() + ". Cause: " + e.getMessage());
+
break;
+ }
if (spi.isNodeStopping0()) {
- if (log.isDebugEnabled())
- log.debug("Stop pinging node, because node is stopping: [rmtNodeId=" + nodeId + ']');
+ log.warning("Failed to ping node [nodeId=" + nodeId + "]. Current node is " +
+ "stopping. Cause: " + e.getMessage());
break;
}