[GitHub] [activemq-artemis] jbertram commented on a diff in pull request #4135: ARTEMIS-3794 System Property Encryption Support

[GitBox <gi...@apache.org>]

jbertram commented on code in PR #4135:
URL: https://github.com/apache/activemq-artemis/pull/4135#discussion_r1051167603


##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnector.java:
##########
@@ -755,6 +771,23 @@ public void initChannel(Channel channel) throws Exception {
       logger.debug("Started {} Netty Connector version {} to {}:{}", connectorType, TransportConstants.NETTY_VERSION, host, port);
    }
 
+   private String processSslPasswordProperty(String password, String codecClass) {

Review Comment:
   Instead of using `ConfigurationHelper` you could simply use `PasswordMaskingUtil` (which is what `ConfigurationHelper` does eventually), e.g.:
   ```java
      private String resolveMask(String password, String codecClass) {
         try {
            return PasswordMaskingUtil.resolveMask(password, codecClass);
         } catch (Exception e) {
            throw new RuntimeException(e);
         }
      }
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org