You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Commit Tag Bot (JIRA)" <ji...@apache.org> on 2013/03/22 17:21:21 UTC

[jira] [Commented] (LUCENE-4534) WFST/AnalyzingSuggest don't handle keys containing 0 bytes correctly

    [ https://issues.apache.org/jira/browse/LUCENE-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13610596#comment-13610596 ] 

Commit Tag Bot commented on LUCENE-4534:
----------------------------------------

[branch_4x commit] Michael McCandless
http://svn.apache.org/viewvc?view=revision&revision=1405978

LUCENE-4534: dedup same surface form in Analyzing/FuzzySuggester

                
> WFST/AnalyzingSuggest don't handle keys containing 0 bytes correctly
> --------------------------------------------------------------------
>
>                 Key: LUCENE-4534
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4534
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 4.1, 5.0
>
>         Attachments: LUCENE-4534.patch, LUCENE-4534.patch
>
>
> While binary terms w/ 0 bytes are rare, they are "allowed" but will cause exceptions with at least WFST/AnalyzingSuggester.
> I think to fix this we should pass custom Comparator to the offline sorter that decodes each BytesRef key and does the actual comparison we want, instead of using separator and relying on BytesRef.compareTo.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org