You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/04/13 20:33:59 UTC

[GitHub] [tvm] junrushao1994 edited a comment on pull request #7809: [WIP][Target][Lowering] Update Op Intrinsic Lowering Mechanism And Intrinsic Lowering Pass

junrushao1994 edited a comment on pull request #7809:
URL: https://github.com/apache/tvm/pull/7809#issuecomment-819034462


   Thanks for the contribution! A few high-level comments:
   
   1. Do not add any C API - we can use packed func to expose the interface. Op is a compile-time concept so please move the registration logic out of the runtime :-)
   2. Please change `register_op` to some name like `register_intrin_lowering`, and consider accepting a target kind like `default`/`llvm`/`cuda`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org