[GitHub] [netbeans-tools] javierllorente commented on pull request #54: Implement RPM packaging

[GitBox <gi...@apache.org>]

javierllorente commented on PR #54:
URL: https://github.com/apache/netbeans-tools/pull/54#issuecomment-1320903509

   >Looks great, many thanks! Will merge.
   
   Excellent. Thanks to you!
   
   >I've been making a bunch of changes so we can move towards releasing NBPackage. I may look at changing a couple of these options into global ones before then, as they can probably be used in the other packagers (eg. InnoSetup template has a to-do around URLs)
   
   Good idea. There are some repeated variables (maintainer, license, ...).
   
   >As an aside to this, but related to release - as the first person to contribute another packager, did the API make sense? Anything confusing? Thanks!
   
   It's a clean API. I have spent most of the time adjusting rpmbuild.
   Some cleaning of unneeded files would be nice, such as netbeans.exe.
   
   NBPackage could be also adapted to package other Java apps (ie: GlassFish); it would extract the zip, skip creating a launcher/copying icons, package all the bits and voilà. A bit out of scope?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists