You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/12/11 14:00:36 UTC
[GitHub] [dubbo-go] codecov-io commented on pull request #928: refactor(generic_filter): struct2MapAll key of map keep type of int f…
codecov-io commented on pull request #928:
URL: https://github.com/apache/dubbo-go/pull/928#issuecomment-743207791
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=h1) Report
> Merging [#928](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=desc) (fcd410c) into [master](https://codecov.io/gh/apache/dubbo-go/commit/1156b92ab4bf2cfb2e52343e91005b03528118a5?el=desc) (1156b92) will **decrease** coverage by `0.09%`.
> The diff coverage is `85.71%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #928 +/- ##
==========================================
- Coverage 59.83% 59.73% -0.10%
==========================================
Files 260 260
Lines 12854 12858 +4
==========================================
- Hits 7691 7681 -10
- Misses 4202 4209 +7
- Partials 961 968 +7
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [filter/filter\_impl/generic\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2dlbmVyaWNfZmlsdGVyLmdv) | `72.30% <85.71%> (+0.17%)` | :arrow_up: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `75.00% <0.00%> (-4.35%)` | :arrow_down: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `72.72% <0.00%> (-3.04%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `75.90% <0.00%> (-2.41%)` | :arrow_down: |
| [remoting/kubernetes/registry\_controller.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9yZWdpc3RyeV9jb250cm9sbGVyLmdv) | `50.20% <0.00%> (-1.23%)` | :arrow_down: |
| [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `68.72% <0.00%> (-0.89%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/928/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=footer). Last update [1156b92...fcd410c](https://codecov.io/gh/apache/dubbo-go/pull/928?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org