You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by gaohoward <gi...@git.apache.org> on 2015/06/29 07:13:14 UTC
[GitHub] activemq-artemis pull request: ARTEMIS-146 Fix Queue auto-creation
GitHub user gaohoward opened a pull request:
https://github.com/apache/activemq-artemis/pull/55
ARTEMIS-146 Fix Queue auto-creation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gaohoward/activemq-artemis artemis146_master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/55.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #55
----
commit 7d7564db5723c8fc9c8e92a94616cc36e2a325f9
Author: Howard Gao <hg...@redhat.com>
Date: 2015-06-29T05:04:55Z
ARTEMIS-146 Fix Queue auto-creation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-146 Fix Queue auto-creation
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/55#issuecomment-116454841
I am going to sleep now. And I won't be able to look further before my morning. Maybe I'm missing something.
Maybe you could abstract the manager without changing production cases. That's what concerns me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-146 Fix Queue auto-creation
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/55#issuecomment-116453439
I don't think so. Openwire is a jms protocol. Hence it needs the jms manager
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-146 Fix Queue auto-creation
Posted by gaohoward <gi...@git.apache.org>.
Github user gaohoward commented on the pull request:
https://github.com/apache/activemq-artemis/pull/55#issuecomment-116916902
:)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-146 Fix Queue auto-creation
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/55#issuecomment-116444946
First, you are changing semantics of a production of a production server because the test is not adapting... it's wrong.
Second, when a JMS Object is created it needs to also create JMS objects for the JMS Created Queue, that should happen through the JMS Manager. You are cutting this directly into a core-queue, it's also wrong.
Why can't you fix the test and add the JMS Manager?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-146 Fix Queue auto-creation
Posted by gaohoward <gi...@git.apache.org>.
Github user gaohoward commented on the pull request:
https://github.com/apache/activemq-artemis/pull/55#issuecomment-116439289
I don't think this has to do with any JMS queues and JMX objects. It's only for openwire. Why it is not valid?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-146 Fix Queue auto-creation
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/55
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-146 Fix Queue auto-creation
Posted by gaohoward <gi...@git.apache.org>.
Github user gaohoward commented on the pull request:
https://github.com/apache/activemq-artemis/pull/55#issuecomment-116448885
OK I get your point. The reason I didn't want to bring in JMS manager is because openwire is not supposed to depends on JMS manager. It should depends only on the core server. Like jms manager, the openwire should only be a facade layer around core. isn't it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-146 Fix Queue auto-creation
Posted by gaohoward <gi...@git.apache.org>.
Github user gaohoward commented on the pull request:
https://github.com/apache/activemq-artemis/pull/55#issuecomment-116653400
ok, just back from the visa application center (it's been 5 hours waiting). Let's just bring in the JMS manager as you suggested. If anything goes wrong we can refactor it later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-146 Fix Queue auto-creation
Posted by gaohoward <gi...@git.apache.org>.
Github user gaohoward commented on the pull request:
https://github.com/apache/activemq-artemis/pull/55#issuecomment-116913275
Hi Clebert,
I updated the branch, can you take a look?
Thanks
Howard
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---