You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Veena Basavaraj <vb...@cloudera.com> on 2014/11/12 20:21:45 UTC
Review Request 27918: Column Type enhancements for complex types
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27918/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-1709
https://issues.apache.org/jira/browse/SQOOP-1709
Repository: sqoop-sqoop2
Description
-------
see jira
Diffs
-----
common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java ecb5aa3
common/src/main/java/org/apache/sqoop/schema/type/AbstractComplexListType.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/AbstractComplexType.java ca9b3b1
common/src/main/java/org/apache/sqoop/schema/type/AbstractDateTime.java 5c969af
common/src/main/java/org/apache/sqoop/schema/type/AbstractNumber.java 1ecb2d5
common/src/main/java/org/apache/sqoop/schema/type/AbstractPrimitiveType.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/AbstractString.java 950c2fd
common/src/main/java/org/apache/sqoop/schema/type/Array.java d7dcc0c
common/src/main/java/org/apache/sqoop/schema/type/Binary.java 7111bf5
common/src/main/java/org/apache/sqoop/schema/type/Bit.java 2371746
common/src/main/java/org/apache/sqoop/schema/type/Column.java 2339d66
common/src/main/java/org/apache/sqoop/schema/type/Date.java 324a089
common/src/main/java/org/apache/sqoop/schema/type/DateTime.java d982d2a
common/src/main/java/org/apache/sqoop/schema/type/Decimal.java 5470b9c
common/src/main/java/org/apache/sqoop/schema/type/Enum.java 0c54fd0
common/src/main/java/org/apache/sqoop/schema/type/FixedPoint.java d949aa7
common/src/main/java/org/apache/sqoop/schema/type/FloatingPoint.java 9639197
common/src/main/java/org/apache/sqoop/schema/type/Map.java d3301c0
common/src/main/java/org/apache/sqoop/schema/type/Set.java a18699f
common/src/main/java/org/apache/sqoop/schema/type/Text.java db47ede
common/src/main/java/org/apache/sqoop/schema/type/Time.java 0f71508
common/src/main/java/org/apache/sqoop/schema/type/Unknown.java 97f72c0
common/src/test/java/org/apache/sqoop/json/util/TestSchemaSerialization.java 1640ead
Diff: https://reviews.apache.org/r/27918/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj
Re: Review Request 27918: Column Type enhancements for complex types
Posted by Jarek Cecho <ja...@apache.org>.
> On Nov. 12, 2014, 7:46 p.m., Jarek Cecho wrote:
> > common/src/main/java/org/apache/sqoop/schema/type/AbstractComplexType.java, line 25
> > <https://reviews.apache.org/r/27918/diff/1/?file=760208#file760208line25>
> >
> > Could you talk a bit about what does the size represents here? (and prehaps include a comment describing that)
>
> Veena Basavaraj wrote:
> good point, I was wondering about this myself yday and did not get a chance to clarify.
>
> related to my question. On the string we have a length. is this basically a max lenght? that we will use for validation ?
>
> I added size on the similar lines, may be all we care is the byte size, just like the number has.
>
> Jarek Cecho wrote:
> I would probably add size only to those types where it make sense. Char/Varchar do have size, numbers do have size as well. Arrays doesn't seem to have size (in Hive, and bogus one in PostgresSQL), Map and Enum doesn't have size either. I did nice summary and investigation in SQOOP-515, perhaps it might be useful to crosscheck my notes.
>
> Veena Basavaraj wrote:
> Sure, I will make the changes and document it. But is it really the max Size? and how will this field be used in Sqoop? I dont see it used so far.
>
> Veena Basavaraj wrote:
> I will add a doc in another sub tasks and add examples of how size attribute can be useful for connector developers.
>
> https://issues.apache.org/jira/secure/attachment/12589331/Sqoop2Datatypes.pdf
The size semantics differs per type - numberic size is number of bytes whereas String have number of characters (and due to UTF and other encodings byte != character). The semantics with the "max" is also depending on the type. The size for a number is a constant in the sense that all values will have that number of bytes whereas in "VARCHAR" case the semantics of the size is indeed the maximal number of characters.
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27918/#review61043
-----------------------------------------------------------
On Nov. 12, 2014, 7:46 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27918/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2014, 7:46 p.m.)
>
>
> Review request for Sqoop and Jarek Cecho.
>
>
> Bugs: SQOOP-1709
> https://issues.apache.org/jira/browse/SQOOP-1709
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see jira
>
> NOTE: WS will be addressed once the patch is reviewd for functinality
>
> Have a few questions as part of this patch:
>
> Why do we make the name optional? It actually throws an exception if we have more than one column as empty. So would it not be wise to make it a mandatory? or can we have columns with no names in databases?
>
> Second, the length attribute, is it more like maxLength that the columns have? if so we should just call it so.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java ecb5aa3
> common/src/main/java/org/apache/sqoop/schema/type/AbstractComplexListType.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/AbstractComplexType.java ca9b3b1
> common/src/main/java/org/apache/sqoop/schema/type/AbstractDateTime.java 5c969af
> common/src/main/java/org/apache/sqoop/schema/type/AbstractNumber.java 1ecb2d5
> common/src/main/java/org/apache/sqoop/schema/type/AbstractPrimitiveType.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/AbstractString.java 950c2fd
> common/src/main/java/org/apache/sqoop/schema/type/Array.java d7dcc0c
> common/src/main/java/org/apache/sqoop/schema/type/Binary.java 7111bf5
> common/src/main/java/org/apache/sqoop/schema/type/Bit.java 2371746
> common/src/main/java/org/apache/sqoop/schema/type/Column.java 2339d66
> common/src/main/java/org/apache/sqoop/schema/type/Date.java 324a089
> common/src/main/java/org/apache/sqoop/schema/type/DateTime.java d982d2a
> common/src/main/java/org/apache/sqoop/schema/type/Decimal.java 5470b9c
> common/src/main/java/org/apache/sqoop/schema/type/Enum.java 0c54fd0
> common/src/main/java/org/apache/sqoop/schema/type/FixedPoint.java d949aa7
> common/src/main/java/org/apache/sqoop/schema/type/FloatingPoint.java 9639197
> common/src/main/java/org/apache/sqoop/schema/type/Map.java d3301c0
> common/src/main/java/org/apache/sqoop/schema/type/Set.java a18699f
> common/src/main/java/org/apache/sqoop/schema/type/Text.java db47ede
> common/src/main/java/org/apache/sqoop/schema/type/Time.java 0f71508
> common/src/main/java/org/apache/sqoop/schema/type/Unknown.java 97f72c0
> common/src/test/java/org/apache/sqoop/json/util/TestSchemaSerialization.java 1640ead
>
> Diff: https://reviews.apache.org/r/27918/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27918: Column Type enhancements for complex types
Posted by Veena Basavaraj <vb...@cloudera.com>.
> On Nov. 12, 2014, 11:46 a.m., Jarek Cecho wrote:
> > common/src/main/java/org/apache/sqoop/schema/type/AbstractComplexType.java, line 25
> > <https://reviews.apache.org/r/27918/diff/1/?file=760208#file760208line25>
> >
> > Could you talk a bit about what does the size represents here? (and prehaps include a comment describing that)
>
> Veena Basavaraj wrote:
> good point, I was wondering about this myself yday and did not get a chance to clarify.
>
> related to my question. On the string we have a length. is this basically a max lenght? that we will use for validation ?
>
> I added size on the similar lines, may be all we care is the byte size, just like the number has.
>
> Jarek Cecho wrote:
> I would probably add size only to those types where it make sense. Char/Varchar do have size, numbers do have size as well. Arrays doesn't seem to have size (in Hive, and bogus one in PostgresSQL), Map and Enum doesn't have size either. I did nice summary and investigation in SQOOP-515, perhaps it might be useful to crosscheck my notes.
Sure, I will make the changes and document it. But is it really the max Size? and how will this field be used in Sqoop? I dont see it used so far.
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27918/#review61043
-----------------------------------------------------------
On Nov. 12, 2014, 11:46 a.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27918/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2014, 11:46 a.m.)
>
>
> Review request for Sqoop and Jarek Cecho.
>
>
> Bugs: SQOOP-1709
> https://issues.apache.org/jira/browse/SQOOP-1709
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see jira
>
> NOTE: WS will be addressed once the patch is reviewd for functinality
>
> Have a few questions as part of this patch:
>
> Why do we make the name optional? It actually throws an exception if we have more than one column as empty. So would it not be wise to make it a mandatory? or can we have columns with no names in databases?
>
> Second, the length attribute, is it more like maxLength that the columns have? if so we should just call it so.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java ecb5aa3
> common/src/main/java/org/apache/sqoop/schema/type/AbstractComplexListType.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/AbstractComplexType.java ca9b3b1
> common/src/main/java/org/apache/sqoop/schema/type/AbstractDateTime.java 5c969af
> common/src/main/java/org/apache/sqoop/schema/type/AbstractNumber.java 1ecb2d5
> common/src/main/java/org/apache/sqoop/schema/type/AbstractPrimitiveType.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/AbstractString.java 950c2fd
> common/src/main/java/org/apache/sqoop/schema/type/Array.java d7dcc0c
> common/src/main/java/org/apache/sqoop/schema/type/Binary.java 7111bf5
> common/src/main/java/org/apache/sqoop/schema/type/Bit.java 2371746
> common/src/main/java/org/apache/sqoop/schema/type/Column.java 2339d66
> common/src/main/java/org/apache/sqoop/schema/type/Date.java 324a089
> common/src/main/java/org/apache/sqoop/schema/type/DateTime.java d982d2a
> common/src/main/java/org/apache/sqoop/schema/type/Decimal.java 5470b9c
> common/src/main/java/org/apache/sqoop/schema/type/Enum.java 0c54fd0
> common/src/main/java/org/apache/sqoop/schema/type/FixedPoint.java d949aa7
> common/src/main/java/org/apache/sqoop/schema/type/FloatingPoint.java 9639197
> common/src/main/java/org/apache/sqoop/schema/type/Map.java d3301c0
> common/src/main/java/org/apache/sqoop/schema/type/Set.java a18699f
> common/src/main/java/org/apache/sqoop/schema/type/Text.java db47ede
> common/src/main/java/org/apache/sqoop/schema/type/Time.java 0f71508
> common/src/main/java/org/apache/sqoop/schema/type/Unknown.java 97f72c0
> common/src/test/java/org/apache/sqoop/json/util/TestSchemaSerialization.java 1640ead
>
> Diff: https://reviews.apache.org/r/27918/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27918: Column Type enhancements for complex types
Posted by Jarek Cecho <ja...@apache.org>.
> On Nov. 12, 2014, 7:46 p.m., Jarek Cecho wrote:
> > common/src/main/java/org/apache/sqoop/schema/type/AbstractComplexType.java, line 25
> > <https://reviews.apache.org/r/27918/diff/1/?file=760208#file760208line25>
> >
> > Could you talk a bit about what does the size represents here? (and prehaps include a comment describing that)
>
> Veena Basavaraj wrote:
> good point, I was wondering about this myself yday and did not get a chance to clarify.
>
> related to my question. On the string we have a length. is this basically a max lenght? that we will use for validation ?
>
> I added size on the similar lines, may be all we care is the byte size, just like the number has.
I would probably add size only to those types where it make sense. Char/Varchar do have size, numbers do have size as well. Arrays doesn't seem to have size (in Hive, and bogus one in PostgresSQL), Map and Enum doesn't have size either. I did nice summary and investigation in SQOOP-515, perhaps it might be useful to crosscheck my notes.
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27918/#review61043
-----------------------------------------------------------
On Nov. 12, 2014, 7:46 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27918/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2014, 7:46 p.m.)
>
>
> Review request for Sqoop and Jarek Cecho.
>
>
> Bugs: SQOOP-1709
> https://issues.apache.org/jira/browse/SQOOP-1709
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see jira
>
> NOTE: WS will be addressed once the patch is reviewd for functinality
>
> Have a few questions as part of this patch:
>
> Why do we make the name optional? It actually throws an exception if we have more than one column as empty. So would it not be wise to make it a mandatory? or can we have columns with no names in databases?
>
> Second, the length attribute, is it more like maxLength that the columns have? if so we should just call it so.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java ecb5aa3
> common/src/main/java/org/apache/sqoop/schema/type/AbstractComplexListType.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/AbstractComplexType.java ca9b3b1
> common/src/main/java/org/apache/sqoop/schema/type/AbstractDateTime.java 5c969af
> common/src/main/java/org/apache/sqoop/schema/type/AbstractNumber.java 1ecb2d5
> common/src/main/java/org/apache/sqoop/schema/type/AbstractPrimitiveType.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/AbstractString.java 950c2fd
> common/src/main/java/org/apache/sqoop/schema/type/Array.java d7dcc0c
> common/src/main/java/org/apache/sqoop/schema/type/Binary.java 7111bf5
> common/src/main/java/org/apache/sqoop/schema/type/Bit.java 2371746
> common/src/main/java/org/apache/sqoop/schema/type/Column.java 2339d66
> common/src/main/java/org/apache/sqoop/schema/type/Date.java 324a089
> common/src/main/java/org/apache/sqoop/schema/type/DateTime.java d982d2a
> common/src/main/java/org/apache/sqoop/schema/type/Decimal.java 5470b9c
> common/src/main/java/org/apache/sqoop/schema/type/Enum.java 0c54fd0
> common/src/main/java/org/apache/sqoop/schema/type/FixedPoint.java d949aa7
> common/src/main/java/org/apache/sqoop/schema/type/FloatingPoint.java 9639197
> common/src/main/java/org/apache/sqoop/schema/type/Map.java d3301c0
> common/src/main/java/org/apache/sqoop/schema/type/Set.java a18699f
> common/src/main/java/org/apache/sqoop/schema/type/Text.java db47ede
> common/src/main/java/org/apache/sqoop/schema/type/Time.java 0f71508
> common/src/main/java/org/apache/sqoop/schema/type/Unknown.java 97f72c0
> common/src/test/java/org/apache/sqoop/json/util/TestSchemaSerialization.java 1640ead
>
> Diff: https://reviews.apache.org/r/27918/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27918: Column Type enhancements for complex types
Posted by Veena Basavaraj <vb...@cloudera.com>.
> On Nov. 12, 2014, 11:46 a.m., Jarek Cecho wrote:
> > common/src/main/java/org/apache/sqoop/schema/type/AbstractComplexType.java, line 25
> > <https://reviews.apache.org/r/27918/diff/1/?file=760208#file760208line25>
> >
> > Could you talk a bit about what does the size represents here? (and prehaps include a comment describing that)
>
> Veena Basavaraj wrote:
> good point, I was wondering about this myself yday and did not get a chance to clarify.
>
> related to my question. On the string we have a length. is this basically a max lenght? that we will use for validation ?
>
> I added size on the similar lines, may be all we care is the byte size, just like the number has.
>
> Jarek Cecho wrote:
> I would probably add size only to those types where it make sense. Char/Varchar do have size, numbers do have size as well. Arrays doesn't seem to have size (in Hive, and bogus one in PostgresSQL), Map and Enum doesn't have size either. I did nice summary and investigation in SQOOP-515, perhaps it might be useful to crosscheck my notes.
>
> Veena Basavaraj wrote:
> Sure, I will make the changes and document it. But is it really the max Size? and how will this field be used in Sqoop? I dont see it used so far.
I will add a doc in another sub tasks and add examples of how size attribute can be useful for connector developers.
https://issues.apache.org/jira/secure/attachment/12589331/Sqoop2Datatypes.pdf
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27918/#review61043
-----------------------------------------------------------
On Nov. 12, 2014, 11:46 a.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27918/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2014, 11:46 a.m.)
>
>
> Review request for Sqoop and Jarek Cecho.
>
>
> Bugs: SQOOP-1709
> https://issues.apache.org/jira/browse/SQOOP-1709
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see jira
>
> NOTE: WS will be addressed once the patch is reviewd for functinality
>
> Have a few questions as part of this patch:
>
> Why do we make the name optional? It actually throws an exception if we have more than one column as empty. So would it not be wise to make it a mandatory? or can we have columns with no names in databases?
>
> Second, the length attribute, is it more like maxLength that the columns have? if so we should just call it so.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java ecb5aa3
> common/src/main/java/org/apache/sqoop/schema/type/AbstractComplexListType.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/AbstractComplexType.java ca9b3b1
> common/src/main/java/org/apache/sqoop/schema/type/AbstractDateTime.java 5c969af
> common/src/main/java/org/apache/sqoop/schema/type/AbstractNumber.java 1ecb2d5
> common/src/main/java/org/apache/sqoop/schema/type/AbstractPrimitiveType.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/AbstractString.java 950c2fd
> common/src/main/java/org/apache/sqoop/schema/type/Array.java d7dcc0c
> common/src/main/java/org/apache/sqoop/schema/type/Binary.java 7111bf5
> common/src/main/java/org/apache/sqoop/schema/type/Bit.java 2371746
> common/src/main/java/org/apache/sqoop/schema/type/Column.java 2339d66
> common/src/main/java/org/apache/sqoop/schema/type/Date.java 324a089
> common/src/main/java/org/apache/sqoop/schema/type/DateTime.java d982d2a
> common/src/main/java/org/apache/sqoop/schema/type/Decimal.java 5470b9c
> common/src/main/java/org/apache/sqoop/schema/type/Enum.java 0c54fd0
> common/src/main/java/org/apache/sqoop/schema/type/FixedPoint.java d949aa7
> common/src/main/java/org/apache/sqoop/schema/type/FloatingPoint.java 9639197
> common/src/main/java/org/apache/sqoop/schema/type/Map.java d3301c0
> common/src/main/java/org/apache/sqoop/schema/type/Set.java a18699f
> common/src/main/java/org/apache/sqoop/schema/type/Text.java db47ede
> common/src/main/java/org/apache/sqoop/schema/type/Time.java 0f71508
> common/src/main/java/org/apache/sqoop/schema/type/Unknown.java 97f72c0
> common/src/test/java/org/apache/sqoop/json/util/TestSchemaSerialization.java 1640ead
>
> Diff: https://reviews.apache.org/r/27918/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27918: Column Type enhancements for complex types
Posted by Veena Basavaraj <vb...@cloudera.com>.
> On Nov. 12, 2014, 11:46 a.m., Jarek Cecho wrote:
> > common/src/main/java/org/apache/sqoop/schema/type/Map.java, lines 47-49
> > <https://reviews.apache.org/r/27918/diff/1/?file=760223#file760223line47>
> >
> > I'm assuming that Value also should not be null, correct?
fair point. we shoudl assert it as well
> On Nov. 12, 2014, 11:46 a.m., Jarek Cecho wrote:
> > common/src/main/java/org/apache/sqoop/schema/type/AbstractComplexType.java, line 25
> > <https://reviews.apache.org/r/27918/diff/1/?file=760208#file760208line25>
> >
> > Could you talk a bit about what does the size represents here? (and prehaps include a comment describing that)
good point, I was wondering about this myself yday and did not get a chance to clarify.
related to my question. On the string we have a length. is this basically a max lenght? that we will use for validation ?
I added size on the similar lines, may be all we care is the byte size, just like the number has.
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27918/#review61043
-----------------------------------------------------------
On Nov. 12, 2014, 11:46 a.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27918/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2014, 11:46 a.m.)
>
>
> Review request for Sqoop and Jarek Cecho.
>
>
> Bugs: SQOOP-1709
> https://issues.apache.org/jira/browse/SQOOP-1709
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see jira
>
> NOTE: WS will be addressed once the patch is reviewd for functinality
>
> Have a few questions as part of this patch:
>
> Why do we make the name optional? It actually throws an exception if we have more than one column as empty. So would it not be wise to make it a mandatory? or can we have columns with no names in databases?
>
> Second, the length attribute, is it more like maxLength that the columns have? if so we should just call it so.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java ecb5aa3
> common/src/main/java/org/apache/sqoop/schema/type/AbstractComplexListType.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/AbstractComplexType.java ca9b3b1
> common/src/main/java/org/apache/sqoop/schema/type/AbstractDateTime.java 5c969af
> common/src/main/java/org/apache/sqoop/schema/type/AbstractNumber.java 1ecb2d5
> common/src/main/java/org/apache/sqoop/schema/type/AbstractPrimitiveType.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/AbstractString.java 950c2fd
> common/src/main/java/org/apache/sqoop/schema/type/Array.java d7dcc0c
> common/src/main/java/org/apache/sqoop/schema/type/Binary.java 7111bf5
> common/src/main/java/org/apache/sqoop/schema/type/Bit.java 2371746
> common/src/main/java/org/apache/sqoop/schema/type/Column.java 2339d66
> common/src/main/java/org/apache/sqoop/schema/type/Date.java 324a089
> common/src/main/java/org/apache/sqoop/schema/type/DateTime.java d982d2a
> common/src/main/java/org/apache/sqoop/schema/type/Decimal.java 5470b9c
> common/src/main/java/org/apache/sqoop/schema/type/Enum.java 0c54fd0
> common/src/main/java/org/apache/sqoop/schema/type/FixedPoint.java d949aa7
> common/src/main/java/org/apache/sqoop/schema/type/FloatingPoint.java 9639197
> common/src/main/java/org/apache/sqoop/schema/type/Map.java d3301c0
> common/src/main/java/org/apache/sqoop/schema/type/Set.java a18699f
> common/src/main/java/org/apache/sqoop/schema/type/Text.java db47ede
> common/src/main/java/org/apache/sqoop/schema/type/Time.java 0f71508
> common/src/main/java/org/apache/sqoop/schema/type/Unknown.java 97f72c0
> common/src/test/java/org/apache/sqoop/json/util/TestSchemaSerialization.java 1640ead
>
> Diff: https://reviews.apache.org/r/27918/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27918: Column Type enhancements for complex types
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27918/#review61043
-----------------------------------------------------------
Overall it looks good. Just couple of small nits:
common/src/main/java/org/apache/sqoop/schema/type/AbstractComplexType.java
<https://reviews.apache.org/r/27918/#comment102505>
Could you talk a bit about what does the size represents here? (and prehaps include a comment describing that)
common/src/main/java/org/apache/sqoop/schema/type/Map.java
<https://reviews.apache.org/r/27918/#comment102503>
I'm assuming that Value also should not be null, correct?
Jarcec
- Jarek Cecho
On Nov. 12, 2014, 7:45 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27918/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2014, 7:45 p.m.)
>
>
> Review request for Sqoop and Jarek Cecho.
>
>
> Bugs: SQOOP-1709
> https://issues.apache.org/jira/browse/SQOOP-1709
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see jira
>
> NOTE: WS will be addressed once the patch is reviewd for functinality
>
> Have a few questions as part of this patch:
>
> Why do we make the name optional? It actually throws an exception if we have more than one column as empty. So would it not be wise to make it a mandatory? or can we have columns with no names in databases?
>
> Second, the length attribute, is it more like maxLength that the columns have? if so we should just call it so.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java ecb5aa3
> common/src/main/java/org/apache/sqoop/schema/type/AbstractComplexListType.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/AbstractComplexType.java ca9b3b1
> common/src/main/java/org/apache/sqoop/schema/type/AbstractDateTime.java 5c969af
> common/src/main/java/org/apache/sqoop/schema/type/AbstractNumber.java 1ecb2d5
> common/src/main/java/org/apache/sqoop/schema/type/AbstractPrimitiveType.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/AbstractString.java 950c2fd
> common/src/main/java/org/apache/sqoop/schema/type/Array.java d7dcc0c
> common/src/main/java/org/apache/sqoop/schema/type/Binary.java 7111bf5
> common/src/main/java/org/apache/sqoop/schema/type/Bit.java 2371746
> common/src/main/java/org/apache/sqoop/schema/type/Column.java 2339d66
> common/src/main/java/org/apache/sqoop/schema/type/Date.java 324a089
> common/src/main/java/org/apache/sqoop/schema/type/DateTime.java d982d2a
> common/src/main/java/org/apache/sqoop/schema/type/Decimal.java 5470b9c
> common/src/main/java/org/apache/sqoop/schema/type/Enum.java 0c54fd0
> common/src/main/java/org/apache/sqoop/schema/type/FixedPoint.java d949aa7
> common/src/main/java/org/apache/sqoop/schema/type/FloatingPoint.java 9639197
> common/src/main/java/org/apache/sqoop/schema/type/Map.java d3301c0
> common/src/main/java/org/apache/sqoop/schema/type/Set.java a18699f
> common/src/main/java/org/apache/sqoop/schema/type/Text.java db47ede
> common/src/main/java/org/apache/sqoop/schema/type/Time.java 0f71508
> common/src/main/java/org/apache/sqoop/schema/type/Unknown.java 97f72c0
> common/src/test/java/org/apache/sqoop/json/util/TestSchemaSerialization.java 1640ead
>
> Diff: https://reviews.apache.org/r/27918/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27918: Column Type enhancements for complex types
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27918/#review61169
-----------------------------------------------------------
Ship it!
Ship It!
- Jarek Cecho
On Nov. 13, 2014, 12:16 a.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27918/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2014, 12:16 a.m.)
>
>
> Review request for Sqoop and Jarek Cecho.
>
>
> Bugs: SQOOP-1709
> https://issues.apache.org/jira/browse/SQOOP-1709
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see jira
>
> NOTE: WS will be addressed once the patch is reviewd for functinality
>
> Have a few questions as part of this patch:
>
> Why do we make the name optional? It actually throws an exception if we have more than one column as empty. So would it not be wise to make it a mandatory? or can we have columns with no names in databases?
>
> Second, the length attribute, is it more like maxLength that the columns have? if so we should just call it so.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java ecb5aa3
> common/src/main/java/org/apache/sqoop/schema/type/AbstractComplexListType.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/AbstractComplexType.java ca9b3b1
> common/src/main/java/org/apache/sqoop/schema/type/AbstractDateTime.java 5c969af
> common/src/main/java/org/apache/sqoop/schema/type/AbstractNumber.java 1ecb2d5
> common/src/main/java/org/apache/sqoop/schema/type/AbstractPrimitiveType.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/AbstractString.java 950c2fd
> common/src/main/java/org/apache/sqoop/schema/type/Array.java d7dcc0c
> common/src/main/java/org/apache/sqoop/schema/type/Binary.java 7111bf5
> common/src/main/java/org/apache/sqoop/schema/type/Bit.java 2371746
> common/src/main/java/org/apache/sqoop/schema/type/Column.java 2339d66
> common/src/main/java/org/apache/sqoop/schema/type/Date.java 324a089
> common/src/main/java/org/apache/sqoop/schema/type/DateTime.java d982d2a
> common/src/main/java/org/apache/sqoop/schema/type/Decimal.java 5470b9c
> common/src/main/java/org/apache/sqoop/schema/type/Enum.java 0c54fd0
> common/src/main/java/org/apache/sqoop/schema/type/FixedPoint.java d949aa7
> common/src/main/java/org/apache/sqoop/schema/type/FloatingPoint.java 9639197
> common/src/main/java/org/apache/sqoop/schema/type/Map.java d3301c0
> common/src/main/java/org/apache/sqoop/schema/type/Set.java a18699f
> common/src/main/java/org/apache/sqoop/schema/type/Text.java db47ede
> common/src/main/java/org/apache/sqoop/schema/type/Time.java 0f71508
> common/src/main/java/org/apache/sqoop/schema/type/Unknown.java 97f72c0
> common/src/test/java/org/apache/sqoop/json/util/TestSchemaSerialization.java 1640ead
>
> Diff: https://reviews.apache.org/r/27918/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27918: Column Type enhancements for complex types
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27918/
-----------------------------------------------------------
(Updated Nov. 12, 2014, 4:16 p.m.)
Review request for Sqoop and Jarek Cecho.
Bugs: SQOOP-1709
https://issues.apache.org/jira/browse/SQOOP-1709
Repository: sqoop-sqoop2
Description
-------
see jira
NOTE: WS will be addressed once the patch is reviewd for functinality
Have a few questions as part of this patch:
Why do we make the name optional? It actually throws an exception if we have more than one column as empty. So would it not be wise to make it a mandatory? or can we have columns with no names in databases?
Second, the length attribute, is it more like maxLength that the columns have? if so we should just call it so.
Diffs (updated)
-----
common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java ecb5aa3
common/src/main/java/org/apache/sqoop/schema/type/AbstractComplexListType.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/AbstractComplexType.java ca9b3b1
common/src/main/java/org/apache/sqoop/schema/type/AbstractDateTime.java 5c969af
common/src/main/java/org/apache/sqoop/schema/type/AbstractNumber.java 1ecb2d5
common/src/main/java/org/apache/sqoop/schema/type/AbstractPrimitiveType.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/AbstractString.java 950c2fd
common/src/main/java/org/apache/sqoop/schema/type/Array.java d7dcc0c
common/src/main/java/org/apache/sqoop/schema/type/Binary.java 7111bf5
common/src/main/java/org/apache/sqoop/schema/type/Bit.java 2371746
common/src/main/java/org/apache/sqoop/schema/type/Column.java 2339d66
common/src/main/java/org/apache/sqoop/schema/type/Date.java 324a089
common/src/main/java/org/apache/sqoop/schema/type/DateTime.java d982d2a
common/src/main/java/org/apache/sqoop/schema/type/Decimal.java 5470b9c
common/src/main/java/org/apache/sqoop/schema/type/Enum.java 0c54fd0
common/src/main/java/org/apache/sqoop/schema/type/FixedPoint.java d949aa7
common/src/main/java/org/apache/sqoop/schema/type/FloatingPoint.java 9639197
common/src/main/java/org/apache/sqoop/schema/type/Map.java d3301c0
common/src/main/java/org/apache/sqoop/schema/type/Set.java a18699f
common/src/main/java/org/apache/sqoop/schema/type/Text.java db47ede
common/src/main/java/org/apache/sqoop/schema/type/Time.java 0f71508
common/src/main/java/org/apache/sqoop/schema/type/Unknown.java 97f72c0
common/src/test/java/org/apache/sqoop/json/util/TestSchemaSerialization.java 1640ead
Diff: https://reviews.apache.org/r/27918/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj
Re: Review Request 27918: Column Type enhancements for complex types
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27918/
-----------------------------------------------------------
(Updated Nov. 12, 2014, 3:52 p.m.)
Review request for Sqoop and Jarek Cecho.
Bugs: SQOOP-1709
https://issues.apache.org/jira/browse/SQOOP-1709
Repository: sqoop-sqoop2
Description
-------
see jira
NOTE: WS will be addressed once the patch is reviewd for functinality
Have a few questions as part of this patch:
Why do we make the name optional? It actually throws an exception if we have more than one column as empty. So would it not be wise to make it a mandatory? or can we have columns with no names in databases?
Second, the length attribute, is it more like maxLength that the columns have? if so we should just call it so.
Diffs (updated)
-----
common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java ecb5aa3
common/src/main/java/org/apache/sqoop/schema/type/AbstractComplexListType.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/AbstractComplexType.java ca9b3b1
common/src/main/java/org/apache/sqoop/schema/type/AbstractDateTime.java 5c969af
common/src/main/java/org/apache/sqoop/schema/type/AbstractNumber.java 1ecb2d5
common/src/main/java/org/apache/sqoop/schema/type/AbstractPrimitiveType.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/AbstractString.java 950c2fd
common/src/main/java/org/apache/sqoop/schema/type/Array.java d7dcc0c
common/src/main/java/org/apache/sqoop/schema/type/Binary.java 7111bf5
common/src/main/java/org/apache/sqoop/schema/type/Bit.java 2371746
common/src/main/java/org/apache/sqoop/schema/type/Column.java 2339d66
common/src/main/java/org/apache/sqoop/schema/type/Date.java 324a089
common/src/main/java/org/apache/sqoop/schema/type/DateTime.java d982d2a
common/src/main/java/org/apache/sqoop/schema/type/Decimal.java 5470b9c
common/src/main/java/org/apache/sqoop/schema/type/Enum.java 0c54fd0
common/src/main/java/org/apache/sqoop/schema/type/FixedPoint.java d949aa7
common/src/main/java/org/apache/sqoop/schema/type/FloatingPoint.java 9639197
common/src/main/java/org/apache/sqoop/schema/type/Map.java d3301c0
common/src/main/java/org/apache/sqoop/schema/type/Set.java a18699f
common/src/main/java/org/apache/sqoop/schema/type/Text.java db47ede
common/src/main/java/org/apache/sqoop/schema/type/Time.java 0f71508
common/src/main/java/org/apache/sqoop/schema/type/Unknown.java 97f72c0
common/src/test/java/org/apache/sqoop/json/util/TestSchemaSerialization.java 1640ead
Diff: https://reviews.apache.org/r/27918/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj
Re: Review Request 27918: Column Type enhancements for complex types
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27918/
-----------------------------------------------------------
(Updated Nov. 12, 2014, 11:46 a.m.)
Review request for Sqoop and Jarek Cecho.
Bugs: SQOOP-1709
https://issues.apache.org/jira/browse/SQOOP-1709
Repository: sqoop-sqoop2
Description
-------
see jira
NOTE: WS will be addressed once the patch is reviewd for functinality
Have a few questions as part of this patch:
Why do we make the name optional? It actually throws an exception if we have more than one column as empty. So would it not be wise to make it a mandatory? or can we have columns with no names in databases?
Second, the length attribute, is it more like maxLength that the columns have? if so we should just call it so.
Diffs (updated)
-----
common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java ecb5aa3
common/src/main/java/org/apache/sqoop/schema/type/AbstractComplexListType.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/AbstractComplexType.java ca9b3b1
common/src/main/java/org/apache/sqoop/schema/type/AbstractDateTime.java 5c969af
common/src/main/java/org/apache/sqoop/schema/type/AbstractNumber.java 1ecb2d5
common/src/main/java/org/apache/sqoop/schema/type/AbstractPrimitiveType.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/AbstractString.java 950c2fd
common/src/main/java/org/apache/sqoop/schema/type/Array.java d7dcc0c
common/src/main/java/org/apache/sqoop/schema/type/Binary.java 7111bf5
common/src/main/java/org/apache/sqoop/schema/type/Bit.java 2371746
common/src/main/java/org/apache/sqoop/schema/type/Column.java 2339d66
common/src/main/java/org/apache/sqoop/schema/type/Date.java 324a089
common/src/main/java/org/apache/sqoop/schema/type/DateTime.java d982d2a
common/src/main/java/org/apache/sqoop/schema/type/Decimal.java 5470b9c
common/src/main/java/org/apache/sqoop/schema/type/Enum.java 0c54fd0
common/src/main/java/org/apache/sqoop/schema/type/FixedPoint.java d949aa7
common/src/main/java/org/apache/sqoop/schema/type/FloatingPoint.java 9639197
common/src/main/java/org/apache/sqoop/schema/type/Map.java d3301c0
common/src/main/java/org/apache/sqoop/schema/type/Set.java a18699f
common/src/main/java/org/apache/sqoop/schema/type/Text.java db47ede
common/src/main/java/org/apache/sqoop/schema/type/Time.java 0f71508
common/src/main/java/org/apache/sqoop/schema/type/Unknown.java 97f72c0
common/src/test/java/org/apache/sqoop/json/util/TestSchemaSerialization.java 1640ead
Diff: https://reviews.apache.org/r/27918/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj
Re: Review Request 27918: Column Type enhancements for complex types
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27918/
-----------------------------------------------------------
(Updated Nov. 12, 2014, 11:45 a.m.)
Review request for Sqoop and Jarek Cecho.
Bugs: SQOOP-1709
https://issues.apache.org/jira/browse/SQOOP-1709
Repository: sqoop-sqoop2
Description (updated)
-------
see jira
NOTE: WS will be addressed once the patch is reviewd for functinality
Have a few questions as part of this patch:
Why do we make the name optional? It actually throws an exception if we have more than one column as empty. So would it not be wise to make it a mandatory? or can we have columns with no names in databases?
Second, the length attribute, is it more like maxLength that the columns have? if so we should just call it so.
Diffs
-----
common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java ecb5aa3
common/src/main/java/org/apache/sqoop/schema/type/AbstractComplexListType.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/AbstractComplexType.java ca9b3b1
common/src/main/java/org/apache/sqoop/schema/type/AbstractDateTime.java 5c969af
common/src/main/java/org/apache/sqoop/schema/type/AbstractNumber.java 1ecb2d5
common/src/main/java/org/apache/sqoop/schema/type/AbstractPrimitiveType.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/AbstractString.java 950c2fd
common/src/main/java/org/apache/sqoop/schema/type/Array.java d7dcc0c
common/src/main/java/org/apache/sqoop/schema/type/Binary.java 7111bf5
common/src/main/java/org/apache/sqoop/schema/type/Bit.java 2371746
common/src/main/java/org/apache/sqoop/schema/type/Column.java 2339d66
common/src/main/java/org/apache/sqoop/schema/type/Date.java 324a089
common/src/main/java/org/apache/sqoop/schema/type/DateTime.java d982d2a
common/src/main/java/org/apache/sqoop/schema/type/Decimal.java 5470b9c
common/src/main/java/org/apache/sqoop/schema/type/Enum.java 0c54fd0
common/src/main/java/org/apache/sqoop/schema/type/FixedPoint.java d949aa7
common/src/main/java/org/apache/sqoop/schema/type/FloatingPoint.java 9639197
common/src/main/java/org/apache/sqoop/schema/type/Map.java d3301c0
common/src/main/java/org/apache/sqoop/schema/type/Set.java a18699f
common/src/main/java/org/apache/sqoop/schema/type/Text.java db47ede
common/src/main/java/org/apache/sqoop/schema/type/Time.java 0f71508
common/src/main/java/org/apache/sqoop/schema/type/Unknown.java 97f72c0
common/src/test/java/org/apache/sqoop/json/util/TestSchemaSerialization.java 1640ead
Diff: https://reviews.apache.org/r/27918/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj
Re: Review Request 27918: Column Type enhancements for complex types
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27918/
-----------------------------------------------------------
(Updated Nov. 12, 2014, 11:32 a.m.)
Review request for Sqoop and Jarek Cecho.
Bugs: SQOOP-1709
https://issues.apache.org/jira/browse/SQOOP-1709
Repository: sqoop-sqoop2
Description
-------
see jira
NOTE: WS will be addressed once the patch is reviewd for functinality
Diffs
-----
common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java ecb5aa3
common/src/main/java/org/apache/sqoop/schema/type/AbstractComplexListType.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/AbstractComplexType.java ca9b3b1
common/src/main/java/org/apache/sqoop/schema/type/AbstractDateTime.java 5c969af
common/src/main/java/org/apache/sqoop/schema/type/AbstractNumber.java 1ecb2d5
common/src/main/java/org/apache/sqoop/schema/type/AbstractPrimitiveType.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/AbstractString.java 950c2fd
common/src/main/java/org/apache/sqoop/schema/type/Array.java d7dcc0c
common/src/main/java/org/apache/sqoop/schema/type/Binary.java 7111bf5
common/src/main/java/org/apache/sqoop/schema/type/Bit.java 2371746
common/src/main/java/org/apache/sqoop/schema/type/Column.java 2339d66
common/src/main/java/org/apache/sqoop/schema/type/Date.java 324a089
common/src/main/java/org/apache/sqoop/schema/type/DateTime.java d982d2a
common/src/main/java/org/apache/sqoop/schema/type/Decimal.java 5470b9c
common/src/main/java/org/apache/sqoop/schema/type/Enum.java 0c54fd0
common/src/main/java/org/apache/sqoop/schema/type/FixedPoint.java d949aa7
common/src/main/java/org/apache/sqoop/schema/type/FloatingPoint.java 9639197
common/src/main/java/org/apache/sqoop/schema/type/Map.java d3301c0
common/src/main/java/org/apache/sqoop/schema/type/Set.java a18699f
common/src/main/java/org/apache/sqoop/schema/type/Text.java db47ede
common/src/main/java/org/apache/sqoop/schema/type/Time.java 0f71508
common/src/main/java/org/apache/sqoop/schema/type/Unknown.java 97f72c0
common/src/test/java/org/apache/sqoop/json/util/TestSchemaSerialization.java 1640ead
Diff: https://reviews.apache.org/r/27918/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj
Re: Review Request 27918: Column Type enhancements for complex types
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27918/
-----------------------------------------------------------
(Updated Nov. 12, 2014, 11:22 a.m.)
Review request for Sqoop.
Bugs: SQOOP-1709
https://issues.apache.org/jira/browse/SQOOP-1709
Repository: sqoop-sqoop2
Description (updated)
-------
see jira
NOTE: WS will be addressed once the patch is reviewd for functinality
Diffs
-----
common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java ecb5aa3
common/src/main/java/org/apache/sqoop/schema/type/AbstractComplexListType.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/AbstractComplexType.java ca9b3b1
common/src/main/java/org/apache/sqoop/schema/type/AbstractDateTime.java 5c969af
common/src/main/java/org/apache/sqoop/schema/type/AbstractNumber.java 1ecb2d5
common/src/main/java/org/apache/sqoop/schema/type/AbstractPrimitiveType.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/AbstractString.java 950c2fd
common/src/main/java/org/apache/sqoop/schema/type/Array.java d7dcc0c
common/src/main/java/org/apache/sqoop/schema/type/Binary.java 7111bf5
common/src/main/java/org/apache/sqoop/schema/type/Bit.java 2371746
common/src/main/java/org/apache/sqoop/schema/type/Column.java 2339d66
common/src/main/java/org/apache/sqoop/schema/type/Date.java 324a089
common/src/main/java/org/apache/sqoop/schema/type/DateTime.java d982d2a
common/src/main/java/org/apache/sqoop/schema/type/Decimal.java 5470b9c
common/src/main/java/org/apache/sqoop/schema/type/Enum.java 0c54fd0
common/src/main/java/org/apache/sqoop/schema/type/FixedPoint.java d949aa7
common/src/main/java/org/apache/sqoop/schema/type/FloatingPoint.java 9639197
common/src/main/java/org/apache/sqoop/schema/type/Map.java d3301c0
common/src/main/java/org/apache/sqoop/schema/type/Set.java a18699f
common/src/main/java/org/apache/sqoop/schema/type/Text.java db47ede
common/src/main/java/org/apache/sqoop/schema/type/Time.java 0f71508
common/src/main/java/org/apache/sqoop/schema/type/Unknown.java 97f72c0
common/src/test/java/org/apache/sqoop/json/util/TestSchemaSerialization.java 1640ead
Diff: https://reviews.apache.org/r/27918/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj