You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "jayzhan211 (via GitHub)" <gi...@apache.org> on 2024/07/02 17:10:51 UTC
[I] Register SQL planners in `SessionState::new()` [datafusion]
jayzhan211 opened a new issue, #11216:
URL: https://github.com/apache/datafusion/issues/11216
It might make sense to move the registering of these planners into the constructor of SessionState rather than here (so users could potentially more carefully control the planner content). But we can do that as a follow on PR
_Originally posted by @alamb in https://github.com/apache/datafusion/pull/11208#discussion_r1662469258_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Register SQL planners in `SessionState::new()` [datafusion]
Posted by "dharanad (via GitHub)" <gi...@apache.org>.
dharanad commented on issue #11216:
URL: https://github.com/apache/datafusion/issues/11216#issuecomment-2206731237
> > hello @jayzhan211 , i would like to work on this. QQ: Is this issue any straight as it sounds or there is more to it?
>
> A little more than it. Ideally we need to update map capacity in provider with the number of references. But, I think you can try it.
>
> https://github.com/apache/datafusion/blob/75b9c9bea28757ec66d7e6a88997bd6f30c367f5/datafusion/core/src/execution/session_state.rs#L590-L608
Do you mean something like this
```
let mut provider = SessionContextProvider {
state: self,
tables: HashMap::with_capacity(references.len() + self.user_defined_sql_planners.len()),
};
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Register SQL planners in `SessionState::new()` [datafusion]
Posted by "dharanad (via GitHub)" <gi...@apache.org>.
dharanad commented on issue #11216:
URL: https://github.com/apache/datafusion/issues/11216#issuecomment-2203366285
hello @jayzhan211 , i would like to work on this. QQ: Is this issue any straight as it sounds or there is more to it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Register SQL planners in `SessionState::new()` [datafusion]
Posted by "dharanad (via GitHub)" <gi...@apache.org>.
dharanad commented on issue #11216:
URL: https://github.com/apache/datafusion/issues/11216#issuecomment-2203903859
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Register SQL planners in `SessionState::new()` [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #11216:
URL: https://github.com/apache/datafusion/issues/11216#issuecomment-2210818664
Update here is I think the current formulation is about as optimal as we can get it:
https://github.com/apache/datafusion/blob/dce77db316beb5bf5dc2326c350b2d642edbfed8/datafusion/core/src/execution/session_state.rs#L234-L242
(namely to make a Vec with a size known at compile time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Register SQL planners in `SessionState::new()` [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed issue #11216: Register SQL planners in `SessionState::new()`
URL: https://github.com/apache/datafusion/issues/11216
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org