[GitHub] [incubator-superset] betodealmeida opened a new pull request #7442: Workaround for no results returned

[GitBox <gi...@apache.org>]

betodealmeida opened a new pull request #7442: Workaround for no results returned
URL: https://github.com/apache/incubator-superset/pull/7442
 
 
   ### CATEGORY
   
   Choose one
   
   - [X] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   https://github.com/apache/incubator-superset/pull/7198 fixed a race condition in SQL Lab where the query payload would have state `success` but the `resultsKey` was set to `null`. Because of this, SQL Lab would stop polling the queries, but would never show the results because there was no `resultsKey`.
   
   @vylc reported that the bug is still happening. As a workaround, I changed the code so that it keeps polling when the state is `success` but `resultsKeys` is `null`. This should make the frontend poll until it can show the results from the query.
   
   <!-- ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF -->
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   I wasn't able to reproduce the problem, which is why I did this workaround. But I tested SQL Lab with this change, and it works as expected.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   
   @datability-io 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org