You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by mike-jumper <gi...@git.apache.org> on 2017/04/13 06:06:25 UTC

[GitHub] incubator-guacamole-client pull request #140: GUACAMOLE-250: Store image URL...

GitHub user mike-jumper opened a pull request:

    https://github.com/apache/incubator-guacamole-client/pull/140

    GUACAMOLE-250: Store image URL in client state only if such an image can be generated (non-zero width/height).

    The changes merged via #139 contain a bug in that a PNG image is attempted to be generated even for images with zero width or height. Such images contain no associated image data, and cannot be encoded as PNG.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mike-jumper/incubator-guacamole-client non-zero-images

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-guacamole-client/pull/140.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #140
    
----
commit 4582f123c3710c31231fd196711f8641edf4b27e
Author: Michael Jumper <mj...@apache.org>
Date:   2017-04-13T05:15:22Z

    GUACAMOLE-250: Store image URL in client state only if such an image can be generated (non-zero width/height).

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-guacamole-client pull request #140: GUACAMOLE-250: Store image URL...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-guacamole-client/pull/140


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---