You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by "AmitStredz (via GitHub)" <gi...@apache.org> on 2025/03/18 18:56:29 UTC
[PR] added "add to collab" button in Optimization_example [mahout]
AmitStredz opened a new pull request, #521:
URL: https://github.com/apache/mahout/pull/521
### Purpose of PR
Fixes #475
Added an "open in collab" button in the Optimization example.
### Linked Issues
Add links to related issues.
- Closes #475
### Changes Made
- [ ] Bug fix
- [x] New feature
- [ ] Documentation update
### Important ToDos
A GitHub issue exists (if not, please create one) [https://github.com/apache/mahout/issues]
- [x] Title of PR is "Issue #475: Add open in colab button to Optimization Example"
- [ ] Created unit tests where appropriate
- [ ] Added correct licenses on newly added files
- [ ] Assigned GitHub issue to self
- [ ] Added documentation in ScalaDocs/JavaDocs and to the website
- [x] Successfully built and ran all unit tests, verified that all tests pass locally
### Breaking Changes
Does this PR introduce a breaking change?
- [x] Yes
- [ ] No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Issue #475: Add open in colab button to Optimization Example [mahout]
Posted by "andrewmusselman (via GitHub)" <gi...@apache.org>.
andrewmusselman merged PR #521:
URL: https://github.com/apache/mahout/pull/521
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Issue #475: Add open in colab button to Optimization Example [mahout]
Posted by "rawkintrevo (via GitHub)" <gi...@apache.org>.
rawkintrevo commented on code in PR #521:
URL: https://github.com/apache/mahout/pull/521#discussion_r2005910354
##########
examples/Optimization_Example.ipynb:
##########
@@ -1,21 +1,26 @@
{
- "nbformat": 4,
- "nbformat_minor": 2,
"cells": [
{
- "cell_type": "code",
+ "cell_type": "markdown",
+ "metadata": {},
"source": [
- "# pip install git+https://github.com/apache/mahout.git@main"
- ],
+ "<a href=\"https://colab.research.google.com/github/rawkintrevo/mahout/blob/mahout-2198/examples/Simple_Example.ipynb\" target=\"_parent\"><img src=\"https://colab.research.google.com/assets/colab-badge.svg\" alt=\"Open In Colab\"/></a>"
Review Comment:
This links to a deleted branch in my repository
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Issue #475: Add open in colab button to Optimization Example [mahout]
Posted by "andrewmusselman (via GitHub)" <gi...@apache.org>.
andrewmusselman commented on PR #521:
URL: https://github.com/apache/mahout/pull/521#issuecomment-2741161347
Thanks @AmitStredz !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Issue #475: Add open in colab button to Optimization Example [mahout]
Posted by "AmitStredz (via GitHub)" <gi...@apache.org>.
AmitStredz commented on code in PR #521:
URL: https://github.com/apache/mahout/pull/521#discussion_r2005991551
##########
examples/Optimization_Example.ipynb:
##########
@@ -1,21 +1,26 @@
{
- "nbformat": 4,
- "nbformat_minor": 2,
"cells": [
{
- "cell_type": "code",
+ "cell_type": "markdown",
+ "metadata": {},
"source": [
- "# pip install git+https://github.com/apache/mahout.git@main"
- ],
+ "<a href=\"https://colab.research.google.com/github/rawkintrevo/mahout/blob/mahout-2198/examples/Simple_Example.ipynb\" target=\"_parent\"><img src=\"https://colab.research.google.com/assets/colab-badge.svg\" alt=\"Open In Colab\"/></a>"
Review Comment:
I've updated the url of the button in both the pages - Simple_Example.ipynb & Optimization_Example.ipynb to link to the files in mahout main repo.
Simple_Example.ipynb:
https://colab.research.google.com/github/apache/mahout/blob/main/examples/Simple_Example.ipynb
Optimization_Example.ipynb:
https://colab.research.google.com/github/apache/mahout/blob/main/examples/Optimization_Example.ipynb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Issue #475: Add open in colab button to Optimization Example [mahout]
Posted by "andrewmusselman (via GitHub)" <gi...@apache.org>.
andrewmusselman commented on code in PR #521:
URL: https://github.com/apache/mahout/pull/521#discussion_r2001795234
##########
examples/Optimization_Example.ipynb:
##########
@@ -1,21 +1,26 @@
{
- "nbformat": 4,
- "nbformat_minor": 2,
"cells": [
{
- "cell_type": "code",
+ "cell_type": "markdown",
+ "metadata": {},
"source": [
- "# pip install git+https://github.com/apache/mahout.git@main"
- ],
+ "<a href=\"https://colab.research.google.com/github/rawkintrevo/mahout/blob/mahout-2198/examples/Simple_Example.ipynb\" target=\"_parent\"><img src=\"https://colab.research.google.com/assets/colab-badge.svg\" alt=\"Open In Colab\"/></a>"
Review Comment:
Shouldn't this link to a notebook for https://github.com/apache/mahout/blob/main/examples/Optimization_Example.ipynb? @rawkintrevo do you have one up there on colab already?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Issue #475: Add open in colab button to Optimization Example [mahout]
Posted by "AmitStredz (via GitHub)" <gi...@apache.org>.
AmitStredz commented on code in PR #521:
URL: https://github.com/apache/mahout/pull/521#discussion_r2005991551
##########
examples/Optimization_Example.ipynb:
##########
@@ -1,21 +1,26 @@
{
- "nbformat": 4,
- "nbformat_minor": 2,
"cells": [
{
- "cell_type": "code",
+ "cell_type": "markdown",
+ "metadata": {},
"source": [
- "# pip install git+https://github.com/apache/mahout.git@main"
- ],
+ "<a href=\"https://colab.research.google.com/github/rawkintrevo/mahout/blob/mahout-2198/examples/Simple_Example.ipynb\" target=\"_parent\"><img src=\"https://colab.research.google.com/assets/colab-badge.svg\" alt=\"Open In Colab\"/></a>"
Review Comment:
I updated the url of the button in both the pages - Simple_Example.ipynb & Optimization_Example.ipynb to link to the files in mahout main repo.
Simple_Example.ipynb:
https://colab.research.google.com/github/apache/mahout/blob/main/examples/Simple_Example.ipynb
Optimization_Example.ipynb:
https://colab.research.google.com/github/apache/mahout/blob/main/examples/Optimization_Example.ipynb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Issue #475: Add open in colab button to Optimization Example [mahout]
Posted by "AmitStredz (via GitHub)" <gi...@apache.org>.
AmitStredz closed pull request #521: Issue #475: Add open in colab button to Optimization Example
URL: https://github.com/apache/mahout/pull/521
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Issue #475: Add open in colab button to Optimization Example [mahout]
Posted by "AmitStredz (via GitHub)" <gi...@apache.org>.
AmitStredz commented on PR #521:
URL: https://github.com/apache/mahout/pull/521#issuecomment-2740979498
> Please fix the link
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org