You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2017/10/13 00:06:17 UTC
Review Request 62959: Added doc for filesystem isolators.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62959/
-----------------------------------------------------------
Review request for mesos, Gilbert Song, Ilya Pronin, and James Peach.
Repository: mesos
Description
-------
Added doc for filesystem isolators.
Diffs
-----
docs/container-volume.md 359d4b20159ed505e2c0ff23a421be41aaf30698
docs/isolators/filesystems.md PRE-CREATION
docs/mesos-containerizer.md 68ed273786d77054eb7973e8f2804138fa2ffff9
Diff: https://reviews.apache.org/r/62959/diff/1/
Testing
-------
verified on github.
https://github.com/jieyu/mesos/blob/doc/docs/isolators/filesystems.md
Thanks,
Jie Yu
Re: Review Request 62959: Added doc for filesystem isolators.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62959/#review187983
-----------------------------------------------------------
docs/container-volume.md
Line 57 (original), 57 (patched)
<https://reviews.apache.org/r/62959/#comment265028>
"depends on *the* ..."
docs/isolators/filesystems.md
Lines 8 (patched)
<https://reviews.apache.org/r/62959/#comment265036>
"The Mesos Containerizer ..."
docs/isolators/filesystems.md
Lines 10 (patched)
<https://reviews.apache.org/r/62959/#comment265037>
"... for a container's ..."
docs/isolators/filesystems.md
Lines 14 (patched)
<https://reviews.apache.org/r/62959/#comment265030>
"supports *the* ..."
docs/isolators/filesystems.md
Lines 15 (patched)
<https://reviews.apache.org/r/62959/#comment265029>
AFAIK these anchors are generated by the Github markdown renderer, but not my Middleman. Once [r/62980](https://reviews.apache.org/r/62980/) lands you might need to rename the anchors.
docs/isolators/filesystems.md
Lines 22 (patched)
<https://reviews.apache.org/r/62959/#comment265032>
"... the Mesos Containerizer ..."
"... one of the filesystem isolators ..."
docs/isolators/filesystems.md
Lines 25 (patched)
<https://reviews.apache.org/r/62959/#comment265031>
"will default to using the ..."
docs/isolators/filesystems.md
Lines 28 (patched)
<https://reviews.apache.org/r/62959/#comment265034>
"Filesysem isolation ..."?
docs/isolators/filesystems.md
Lines 30 (patched)
<https://reviews.apache.org/r/62959/#comment265038>
"... functionality ..."
docs/isolators/filesystems.md
Lines 36 (patched)
<https://reviews.apache.org/r/62959/#comment265040>
"Filesystem isolation ..." or "The filesystem isolator ..."
docs/isolators/filesystems.md
Lines 47 (patched)
<https://reviews.apache.org/r/62959/#comment265033>
"Use the ..."
docs/isolators/filesystems.md
Lines 50 (patched)
<https://reviews.apache.org/r/62959/#comment265041>
"The `filesystem/posix` isolator handles ..."
docs/isolators/filesystems.md
Lines 56 (patched)
<https://reviews.apache.org/r/62959/#comment265035>
"The ..."
Both here and in the first paragraph of the other sections.
docs/isolators/filesystems.md
Lines 70 (patched)
<https://reviews.apache.org/r/62959/#comment265043>
"The `filesystem/linux` isolator handles ..."
- James Peach
On Oct. 13, 2017, 12:06 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62959/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2017, 12:06 a.m.)
>
>
> Review request for mesos, Gilbert Song, Ilya Pronin, and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added doc for filesystem isolators.
>
>
> Diffs
> -----
>
> docs/container-volume.md 359d4b20159ed505e2c0ff23a421be41aaf30698
> docs/isolators/filesystems.md PRE-CREATION
> docs/mesos-containerizer.md 68ed273786d77054eb7973e8f2804138fa2ffff9
>
>
> Diff: https://reviews.apache.org/r/62959/diff/1/
>
>
> Testing
> -------
>
> verified on github.
> https://github.com/jieyu/mesos/blob/doc/docs/isolators/filesystems.md
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 62959: Added doc for filesystem isolators.
Posted by Ilya Pronin <ip...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62959/#review187912
-----------------------------------------------------------
Fix it, then Ship it!
Looks good!
docs/isolators/filesystems.md
Lines 17-20 (patched)
<https://reviews.apache.org/r/62959/#comment264986>
Maybe worth mentioning that it's even broken on hosts with systemd (https://issues.apache.org/jira/browse/MESOS-6563).
docs/isolators/filesystems.md
Lines 41 (patched)
<https://reviews.apache.org/r/62959/#comment264989>
The isolator link here and below leads to the same section where it is located.
- Ilya Pronin
On Oct. 12, 2017, 5:06 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62959/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2017, 5:06 p.m.)
>
>
> Review request for mesos, Gilbert Song, Ilya Pronin, and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added doc for filesystem isolators.
>
>
> Diffs
> -----
>
> docs/container-volume.md 359d4b20159ed505e2c0ff23a421be41aaf30698
> docs/isolators/filesystems.md PRE-CREATION
> docs/mesos-containerizer.md 68ed273786d77054eb7973e8f2804138fa2ffff9
>
>
> Diff: https://reviews.apache.org/r/62959/diff/1/
>
>
> Testing
> -------
>
> verified on github.
> https://github.com/jieyu/mesos/blob/doc/docs/isolators/filesystems.md
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 62959: Added doc for filesystem isolators.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62959/#review187917
-----------------------------------------------------------
Fix it, then Ship it!
docs/isolators/filesystems.md
Lines 29 (patched)
<https://reviews.apache.org/r/62959/#comment264991>
remove an extra `isolator`.
- Gilbert Song
On Oct. 12, 2017, 5:06 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62959/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2017, 5:06 p.m.)
>
>
> Review request for mesos, Gilbert Song, Ilya Pronin, and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added doc for filesystem isolators.
>
>
> Diffs
> -----
>
> docs/container-volume.md 359d4b20159ed505e2c0ff23a421be41aaf30698
> docs/isolators/filesystems.md PRE-CREATION
> docs/mesos-containerizer.md 68ed273786d77054eb7973e8f2804138fa2ffff9
>
>
> Diff: https://reviews.apache.org/r/62959/diff/1/
>
>
> Testing
> -------
>
> verified on github.
> https://github.com/jieyu/mesos/blob/doc/docs/isolators/filesystems.md
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 62959: Added doc for filesystem isolators.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62959/#review187928
-----------------------------------------------------------
PASS: Mesos patch 62959 was successfully built and tested.
Reviews applied: `['62959']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62959
- Mesos Reviewbot Windows
On Oct. 13, 2017, 12:06 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62959/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2017, 12:06 a.m.)
>
>
> Review request for mesos, Gilbert Song, Ilya Pronin, and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added doc for filesystem isolators.
>
>
> Diffs
> -----
>
> docs/container-volume.md 359d4b20159ed505e2c0ff23a421be41aaf30698
> docs/isolators/filesystems.md PRE-CREATION
> docs/mesos-containerizer.md 68ed273786d77054eb7973e8f2804138fa2ffff9
>
>
> Diff: https://reviews.apache.org/r/62959/diff/1/
>
>
> Testing
> -------
>
> verified on github.
> https://github.com/jieyu/mesos/blob/doc/docs/isolators/filesystems.md
>
>
> Thanks,
>
> Jie Yu
>
>