You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/09/29 20:31:55 UTC

[GitHub] [trafficserver] randall commented on a change in pull request #8354: Adds support for TCP_NOTSENT_LOWAT sockopt

randall commented on a change in pull request #8354:
URL: https://github.com/apache/trafficserver/pull/8354#discussion_r718862436



##########
File path: mgmt/RecordsConfig.cc
##########
@@ -786,6 +786,8 @@ static const RecordElement RecordsConfig[] =
   ,
   {RECT_CONFIG, "proxy.config.net.sock_mss_in", RECD_INT, "0", RECU_RESTART_TS, RR_NULL, RECC_NULL, nullptr, RECA_NULL}
   ,
+  {RECT_CONFIG, "proxy.config.net.sock_notsent_lowat", RECD_INT, "16384", RECU_DYNAMIC, RR_NULL, RECC_NULL, nullptr, RECA_NULL}

Review comment:
       It's off by default (aka don't do setsockopt), but if you do enable via the masks (adding 64 to `proxy.config.net.sock_option_flag_in` record), it would enable it with the default value from here (or whatever is set in `records.config`)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org