You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/10/01 15:15:09 UTC

[GitHub] [spark] srowen opened a new pull request #25991: [MINOR][BUILD] Decode output of commands during merge script as UTF-8 consistently

srowen opened a new pull request #25991: [MINOR][BUILD] Decode output of commands during merge script as UTF-8 consistently
URL: https://github.com/apache/spark/pull/25991
 
 
   
   ### What changes were proposed in this pull request?
   
   In the PR merge script, decode the raw output of subprocess commands like `git` using UTF-8 encoding, consistently.
   
   ### Why are the changes needed?
   
   The merge script occasionally fails if run with Python 2 and the output of a command like `git` contains non-ASCII characters. I think this most usually happens when a user name, for example, contains Chinese characters.
   
   This is because the output is decoded according to `sys.getdefaultencoding()`, which is ASCII in Python 2. It's UTF-8 in Python 3, by default.
   
   ### Does this PR introduce any user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   The change caused a merge that failed before to succeed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org