You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2020/11/19 01:41:59 UTC
[Impala-ASF-CR] IMPALA-9121: try to avoid ASAN error in hdfs-util-test
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16748
Change subject: IMPALA-9121: try to avoid ASAN error in hdfs-util-test
......................................................................
IMPALA-9121: try to avoid ASAN error in hdfs-util-test
I couldn't discern the likely root cause of the ASAN error,
but have a hunch that it's a background thread accessing
some data structure that is being torn down as the
process exits.
The tests in this file are simple so there shouldn't really
be that much that can go wrong, except for the stuff
started by ExecEnv::Init().
I modified the test to only initialize the necessary configs
in ExecEnv, not start up the whole thing. Hopefully that
make the problem go away.
Testing:
Looped the test locally with ASAN.
Change-Id: Ic7b42be0f8b5d6c6a31095f9d1a278fd82bd500c
---
M be/src/runtime/exec-env.cc
M be/src/runtime/exec-env.h
M be/src/util/hdfs-util-test.cc
3 files changed, 18 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/48/16748/1
--
To view, visit http://gerrit.cloudera.org:8080/16748
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic7b42be0f8b5d6c6a31095f9d1a278fd82bd500c
Gerrit-Change-Number: 16748
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-9121: try to avoid ASAN error in hdfs-util-test
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16748 )
Change subject: IMPALA-9121: try to avoid ASAN error in hdfs-util-test
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6679/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/16748
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7b42be0f8b5d6c6a31095f9d1a278fd82bd500c
Gerrit-Change-Number: 16748
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Nov 2020 09:26:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9121: try to avoid ASAN error in hdfs-util-test
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16748 )
Change subject: IMPALA-9121: try to avoid ASAN error in hdfs-util-test
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/7682/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16748
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7b42be0f8b5d6c6a31095f9d1a278fd82bd500c
Gerrit-Change-Number: 16748
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Nov 2020 02:04:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9121: try to avoid ASAN error in hdfs-util-test
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16748 )
Change subject: IMPALA-9121: try to avoid ASAN error in hdfs-util-test
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16748
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7b42be0f8b5d6c6a31095f9d1a278fd82bd500c
Gerrit-Change-Number: 16748
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Nov 2020 09:26:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9121: try to avoid ASAN error in hdfs-util-test
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16748 )
Change subject: IMPALA-9121: try to avoid ASAN error in hdfs-util-test
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/16748
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7b42be0f8b5d6c6a31095f9d1a278fd82bd500c
Gerrit-Change-Number: 16748
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Nov 2020 14:51:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9121: try to avoid ASAN error in hdfs-util-test
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16748 )
Change subject: IMPALA-9121: try to avoid ASAN error in hdfs-util-test
......................................................................
IMPALA-9121: try to avoid ASAN error in hdfs-util-test
I couldn't discern the likely root cause of the ASAN error,
but have a hunch that it's a background thread accessing
some data structure that is being torn down as the
process exits.
The tests in this file are simple so there shouldn't really
be that much that can go wrong, except for the stuff
started by ExecEnv::Init().
I modified the test to only initialize the necessary configs
in ExecEnv, not start up the whole thing. Hopefully that
make the problem go away.
Testing:
Looped the test locally with ASAN.
Change-Id: Ic7b42be0f8b5d6c6a31095f9d1a278fd82bd500c
Reviewed-on: http://gerrit.cloudera.org:8080/16748
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/runtime/exec-env.cc
M be/src/runtime/exec-env.h
M be/src/util/hdfs-util-test.cc
3 files changed, 18 insertions(+), 15 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/16748
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic7b42be0f8b5d6c6a31095f9d1a278fd82bd500c
Gerrit-Change-Number: 16748
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-9121: try to avoid ASAN error in hdfs-util-test
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16748 )
Change subject: IMPALA-9121: try to avoid ASAN error in hdfs-util-test
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16748
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7b42be0f8b5d6c6a31095f9d1a278fd82bd500c
Gerrit-Change-Number: 16748
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Nov 2020 09:26:47 +0000
Gerrit-HasComments: No