[GitHub] [beam] AnandInguva commented on a diff in pull request #24599: Update Protobuf and GCP dependencies in Beam Python SDK

["AnandInguva (via GitHub)" <gi...@apache.org>]

AnandInguva commented on code in PR #24599:
URL: https://github.com/apache/beam/pull/24599#discussion_r1194170523


##########
sdks/python/container/base_image_requirements_manual.txt:
##########
@@ -32,14 +32,11 @@ cython<1
 # some versions of libraries that launch Beam pipelines, like tensorflow-transform.
 # Leaving 'future' in our containers for now prevent breaking tft users.
 future
-# TODO: Remove the upper bound once Tensorflow 2.11 is released.
-# https://github.com/apache/beam/issues/23355
-google-cloud-profiler<4.0.0

Review Comment:
   ahh...this was not intentional. 
   
   @Abacn these are beam external images. Dataflow images are internal: https://source.corp.google.com/piper///depot/google3/third_party/cloud/dataflow/worker/images/base_python/Dockerfile.base-python;rcl=522192081;l=117



##########
sdks/python/container/base_image_requirements_manual.txt:
##########
@@ -32,14 +32,11 @@ cython<1
 # some versions of libraries that launch Beam pipelines, like tensorflow-transform.
 # Leaving 'future' in our containers for now prevent breaking tft users.
 future
-# TODO: Remove the upper bound once Tensorflow 2.11 is released.
-# https://github.com/apache/beam/issues/23355
-google-cloud-profiler<4.0.0

Review Comment:
   ahh...this was not intentional.  
   
   @Abacn these are beam external images. Dataflow images are internal: https://source.corp.google.com/piper///depot/google3/third_party/cloud/dataflow/worker/images/base_python/Dockerfile.base-python;rcl=522192081;l=117



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org