You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Sijie Guo (JIRA)" <ji...@apache.org> on 2012/10/15 11:44:02 UTC
[jira] [Created] (BOOKKEEPER-433) Validate subscriber id for
subscription
Sijie Guo created BOOKKEEPER-433:
------------------------------------
Summary: Validate subscriber id for subscription
Key: BOOKKEEPER-433
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-433
Project: Bookkeeper
Issue Type: Bug
Components: hedwig-server
Affects Versions: 4.2.0
Reporter: Sijie Guo
Assignee: Sijie Guo
Fix For: 4.2.0
currently we don't validate the topic and the subscriber id when subscription. we need to validate it since we prefix underscore for a subscriber to indicate it is a remote subscriber.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-433) Validate subscriber id for
subscription
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476106#comment-13476106 ]
Sijie Guo commented on BOOKKEEPER-433:
--------------------------------------
{quote}
it might be good to think about how we can accept arbitrary binary subscriber ids without colliding with private/internal subscriber ids.
{quote}
yeah. I agreed that it would be better to not collide with internal subscriber id. so how about adding a field in SubscriptionPreferences to indicate a subscriber is local or remote?
Besides that, I had to clarify that although we used 'ByteString' for topic and subscriber id now, actually we could not accept arbitrary bytes for topic name or subscriber id now even w/o prefixing underscore. because we use 'subscriber id' directly as part of znode path to store metadata in ZooKeeper, if the strings has spaces or prefixing with '/', they are failed to be used as a topic name or subscriber id. so this jira would also handle such case.
> Validate subscriber id for subscription
> ---------------------------------------
>
> Key: BOOKKEEPER-433
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-433
> Project: Bookkeeper
> Issue Type: Bug
> Components: hedwig-server
> Affects Versions: 4.2.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.2.0
>
>
> currently we don't validate the topic and the subscriber id when subscription. we need to validate it since we prefix underscore for a subscriber to indicate it is a remote subscriber.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-433) Validate subscriber id for
subscription
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476076#comment-13476076 ]
Stu Hood commented on BOOKKEEPER-433:
-------------------------------------
IMO, rather than validating the subscriber id, it might be good to think about how we can accept arbitrary binary subscriber ids without colliding with private/internal subscriber ids. Technically, subscriber ids can already contain arbitrary bytes (ByteString), so internally namespacing or marking private/internal subscriber ids in some way makes more sense to me (as suggested on the [other ticket|https://issues.apache.org/jira/browse/BOOKKEEPER-422?focusedCommentId=13473538&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13473538].)
> Validate subscriber id for subscription
> ---------------------------------------
>
> Key: BOOKKEEPER-433
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-433
> Project: Bookkeeper
> Issue Type: Bug
> Components: hedwig-server
> Affects Versions: 4.2.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.2.0
>
>
> currently we don't validate the topic and the subscriber id when subscription. we need to validate it since we prefix underscore for a subscriber to indicate it is a remote subscriber.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-433) Validate subscriber id for
subscription
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated BOOKKEEPER-433:
----------------------------------
Fix Version/s: (was: 4.2.0)
4.3.0
> Validate subscriber id for subscription
> ---------------------------------------
>
> Key: BOOKKEEPER-433
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-433
> Project: Bookkeeper
> Issue Type: Bug
> Components: hedwig-server
> Affects Versions: 4.2.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.3.0
>
>
> currently we don't validate the topic and the subscriber id when subscription. we need to validate it since we prefix underscore for a subscriber to indicate it is a remote subscriber.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira