You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@geode.apache.org by kl...@apache.org on 2016/03/16 19:07:36 UTC

[2/2] incubator-geode git commit: Add comment

Add comment


Project: http://git-wip-us.apache.org/repos/asf/incubator-geode/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-geode/commit/7d3bea09
Tree: http://git-wip-us.apache.org/repos/asf/incubator-geode/tree/7d3bea09
Diff: http://git-wip-us.apache.org/repos/asf/incubator-geode/diff/7d3bea09

Branch: refs/heads/feature/GEODE-949-2
Commit: 7d3bea0910d7779df8da13d83e57794af9c2e98a
Parents: d60d8a3
Author: Kirk Lund <kl...@apache.org>
Authored: Wed Mar 16 11:07:21 2016 -0700
Committer: Kirk Lund <kl...@apache.org>
Committed: Wed Mar 16 11:07:21 2016 -0700

----------------------------------------------------------------------
 .../internal/membership/gms/auth/GMSAuthenticator.java   | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/7d3bea09/geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/auth/GMSAuthenticator.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/auth/GMSAuthenticator.java b/geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/auth/GMSAuthenticator.java
index d472de0..741eb2c 100755
--- a/geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/auth/GMSAuthenticator.java
+++ b/geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/auth/GMSAuthenticator.java
@@ -111,7 +111,7 @@ public class GMSAuthenticator implements Authenticator {
    */
   @Override
   public String authenticate(InternalDistributedMember member, Object credentials) throws AuthenticationFailedException {
-    return authenticate(member, credentials, securityProps, services.getJoinLeave().getMemberID());
+    return authenticate(member, credentials, this.securityProps, this.services.getJoinLeave().getMemberID());
   }
 
   /**
@@ -124,7 +124,7 @@ public class GMSAuthenticator implements Authenticator {
       return null;
     }
 
-    InternalLogWriter securityLogWriter = services.getSecurityLogWriter();
+    InternalLogWriter securityLogWriter = this.services.getSecurityLogWriter();
     String failMsg = null;
     if (credentials != null) {
       try {
@@ -156,9 +156,10 @@ public class GMSAuthenticator implements Authenticator {
         throw new AuthenticationFailedException(HandShake_AUTHENTICATOR_INSTANCE_COULD_NOT_BE_OBTAINED.toLocalizedString());
       }
 
-      LogWriter logWriter = services.getLogWriter();
-      LogWriter securityLogWriter = services.getSecurityLogWriter();
-      auth.init(securityProps, logWriter, securityLogWriter);
+      LogWriter logWriter = this.services.getLogWriter();
+      LogWriter securityLogWriter = this.services.getSecurityLogWriter();
+
+      auth.init(this.securityProps, logWriter, securityLogWriter); // this.securityProps contains security-ldap-basedn but security-ldap-baseDomainName is expected
       return auth.authenticate((Properties) credentials, member);
 
     } catch (GemFireSecurityException gse) {