[PR] perf(release-vote-draft, release-vote-tally): render the vote drafts and decide the tally as code [magpie]

["potiuk (via GitHub)" <gi...@apache.org>]

potiuk opened a new pull request, #1617:
URL: https://github.com/apache/magpie/pull/1617

   ## Summary
   
   Third PR of the stack; it builds on the verify-rc PR.
   
   - **`release-vote-draft`:**
     - `verdict` adds the planning-issue blocker and the verify-rc gate. A PASS counts only for this exact RC, FAIL or no comment blocks, and `--skip-verify-check` resolves it.
     - `render --step 2` draws the `[VOTE]` subject and body with every conditional block, plus the `atr vote start` command.
     - `render --step 3 --sent-at` computes the close time.
   - **`release-vote-tally`:**
     - `tally.py` moves into the package unchanged.
     - `verdict` blocks on a previous AMBIGUOUS note.
     - `archive-url` and `preclassify` are new; `preclassify` parses bare vote lines only and leaves everything else to the agent.
     - `tally --min-approvals` applies the pr-approval rule.
     - `render` draws the `[RESULT] [VOTE]` mail, refuses a halted tally, and never puts reply text in the body.
   - **Size:** vote-draft goes from 6,842 to 5,409 tokens, vote-tally from 5,799 to 5,589. Each delivery mode, override, mechanism and outcome gets its own file.
   
   ## Behaviour changes worth a look
   
   - **A verify-rc `PASS-WITH-WARNINGS` proceeds, with a warning.** Golden rule 5 says "PASS", but verify-rc's own Golden rule 4 treats PASS-WITH-WARNINGS as a PASS, and the Hard rule only forbids FAIL.
   - **A missing URL, or a missing `svn_revision` under svnpubsub, is now a hard refusal** rather than a placeholder.
   - **The pr-approval rule is `binding +1 >= approval_pr_min_approvals`, with no veto.** No veto was ever specified, and release votes can't be vetoed.
   - **The github-discussion and maintainer-roster pass rules are unspecified** and stay with the agent.
   - **An expedited reason naming a CVE or "security" comes back as a warning**, and rewording it stays the agent's job.
   - **The `atr vote start` command quotes its configured values;** the subject comes from a template.
   
   ## Type of change
   
   - [x] Skill change — eval fixtures updated below
   - [x] Python package
   
   ## Test plan
   
   - [x] `prek run --all-files` passes on the stack tip.
   - [x] `tools/release-management`: pytest / ruff / mypy, with two real-`load` integration tests.
   - [x] Evals: twelve cases are now pytest cases named after each former case, with byte-identical expected bodies. The six kept judgement cases pass 3/3 per skill, against a baseline of 9/9 each.
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [x] Yes — Claude Code (Opus 5). I reviewed the diff and the test results; commits carry `Generated-by:`.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   
   https://claude.ai/code/session_01GTPsZ5aEE5bUVYqp47Dpvv
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] perf(release-vote-draft, release-vote-tally): render the vote drafts and decide the tally as code [magpie]

["potiuk (via GitHub)" <gi...@apache.org>]

potiuk merged PR #1617:
URL: https://github.com/apache/magpie/pull/1617


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org