You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openwebbeans.apache.org by "Paul J. Reder (JIRA)" <ji...@apache.org> on 2009/10/28 18:21:59 UTC

[jira] Created: (OWB-149) BeforeShutDown (in current code) should be BeforeShutdown to match spec.

BeforeShutDown (in current code) should be BeforeShutdown to match spec.
------------------------------------------------------------------------

                 Key: OWB-149
                 URL: https://issues.apache.org/jira/browse/OWB-149
             Project: OpenWebBeans
          Issue Type: Bug
            Reporter: Paul J. Reder
            Assignee: Gurkan Erdogdu
            Priority: Minor


Currently the code uses BeforeShutDown (with a capital D) where the spec uses BeforeShutdown. The code needs to fire the event that beans will expect to observe.

I'll be submitting a patch shortly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (OWB-149) BeforeShutDown (in current code) should be BeforeShutdown to match spec.

Posted by "Paul J. Reder (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OWB-149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771032#action_12771032 ] 

Paul J. Reder commented on OWB-149:
-----------------------------------

Actually, after further study, it turns out that the confusion came from the fireEvent call.
This case calls fireEvent(new BeforeShutDownImpl(), ... 
as opposed to other calls that use the event directly (i.e. fireEvent(new BeforeShutDown, ...)

BeforeShutDownImpl implements BeforeShutdown, so the correct event should get generated, but the impl should have the typo fixed to remove the confusion.

> BeforeShutDown (in current code) should be BeforeShutdown to match spec.
> ------------------------------------------------------------------------
>
>                 Key: OWB-149
>                 URL: https://issues.apache.org/jira/browse/OWB-149
>             Project: OpenWebBeans
>          Issue Type: Bug
>            Reporter: Paul J. Reder
>            Assignee: Gurkan Erdogdu
>            Priority: Minor
>
> Currently the code uses BeforeShutDown (with a capital D) where the spec uses BeforeShutdown. The code needs to fire the event that beans will expect to observe.
> I'll be submitting a patch shortly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Assigned: (OWB-149) BeforeShutDown (in current code) should be BeforeShutdown to match spec.

Posted by "Mark Struberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OWB-149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Struberg reassigned OWB-149:
---------------------------------

    Assignee: Mark Struberg  (was: Gurkan Erdogdu)

> BeforeShutDown (in current code) should be BeforeShutdown to match spec.
> ------------------------------------------------------------------------
>
>                 Key: OWB-149
>                 URL: https://issues.apache.org/jira/browse/OWB-149
>             Project: OpenWebBeans
>          Issue Type: Bug
>            Reporter: Paul J. Reder
>            Assignee: Mark Struberg
>            Priority: Minor
>
> Currently the code uses BeforeShutDown (with a capital D) where the spec uses BeforeShutdown. The code needs to fire the event that beans will expect to observe.
> I'll be submitting a patch shortly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (OWB-149) BeforeShutDown (in current code) should be BeforeShutdown to match spec.

Posted by "Mark Struberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OWB-149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Struberg resolved OWB-149.
-------------------------------

       Resolution: Fixed
    Fix Version/s: M4

I renamed it to BeforeShutdownImpl. txs!

> BeforeShutDown (in current code) should be BeforeShutdown to match spec.
> ------------------------------------------------------------------------
>
>                 Key: OWB-149
>                 URL: https://issues.apache.org/jira/browse/OWB-149
>             Project: OpenWebBeans
>          Issue Type: Bug
>            Reporter: Paul J. Reder
>            Assignee: Mark Struberg
>            Priority: Minor
>             Fix For: M4
>
>
> Currently the code uses BeforeShutDown (with a capital D) where the spec uses BeforeShutdown. The code needs to fire the event that beans will expect to observe.
> I'll be submitting a patch shortly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.