You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/10 06:59:46 UTC
[GitHub] [incubator-nuttx] GUIDINGLI opened a new pull request #5197: serial: merge serial check signo to one place
GUIDINGLI opened a new pull request #5197:
URL: https://github.com/apache/incubator-nuttx/pull/5197
## Summary
serial: merge serial check signo to one place
## Impact
serial
## Testing
VELA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko merged pull request #5197: serial: merge serial check signo to one place
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged pull request #5197:
URL: https://github.com/apache/incubator-nuttx/pull/5197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5197: serial: merge serial check signo to one place
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #5197:
URL: https://github.com/apache/incubator-nuttx/pull/5197#issuecomment-1008590139
@normanr this patch should address the issue you report here: https://github.com/apache/incubator-nuttx/pull/5017.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5197: serial: merge serial check signo to one place
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5197:
URL: https://github.com/apache/incubator-nuttx/pull/5197#discussion_r780971357
##########
File path: drivers/serial/serial.c
##########
@@ -1887,17 +1892,71 @@ void uart_reset_sem(FAR uart_dev_t *dev)
}
/****************************************************************************
- * Name: uart_launch
+ * Name: uart_check_special
*
* Description:
- * This function is called when user want launch a new program by
- * using a special char.
+ * Check if the SIGINT or SIGTSTP character is in the contiguous Rx DMA
+ * buffer region. The first signal associated with the first such
+ * character is returned.
+ *
+ * If there multiple such characters in the buffer, only the signal
+ * associated with the first is returned (this a bug!)
+ *
+ * Returned Value:
+ * 0 if a signal-related character does not appear in the. Otherwise,
+ * SIGKILL or SIGTSTP may be returned to indicate the appropriate signal
+ * action.
*
****************************************************************************/
-#ifdef CONFIG_TTY_LAUNCH
-void uart_launch(void)
+#if defined(CONFIG_TTY_SIGINT) || defined(CONFIG_TTY_SIGTSTP) || \
+ defined(CONFIG_TTY_FORCE_PANIC) || defined(CONFIG_TTY_LAUNCH)
+int uart_check_special(FAR uart_dev_t *dev, const char *buf, size_t size)
{
- work_queue(HPWORK, &g_serial_work, uart_launch_worker, NULL, 0);
+ size_t i;
+
+#ifdef CONFIG_SERIAL_TERMIOS
+ if (!(dev->tc_lflag & ISIG))
Review comment:
```suggestion
if ((dev->tc_lflag & ISIG) == 0)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org