You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cayenne.apache.org by "John Huss (Created) (JIRA)" <ji...@apache.org> on 2011/11/02 17:37:34 UTC

[jira] [Created] (CAY-1637) [PATCH] DataContextFactory is cumbersome to customize

[PATCH] DataContextFactory is cumbersome to customize
-----------------------------------------------------

                 Key: CAY-1637
                 URL: https://issues.apache.org/jira/browse/CAY-1637
             Project: Cayenne
          Issue Type: Improvement
          Components: Core Library
    Affects Versions: 3.1M4
         Environment: Mac 10.6
            Reporter: John Huss
            Priority: Minor
         Attachments: context-factory-patch.txt

DataContextFactory is cumbersome to customize.  I want to use my own custom subclass of DataContext (which is probably the only customization ever needed, right?) and in order to do so I have to copy the complete source of DataContextFactory and replace DataContext with MyContext.  It can be made much easier by refactoring the constructor call into an overridable method that does just that.  CayenneContextFactory has the same problem.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CAY-1637) [PATCH] DataContextFactory is cumbersome to customize

Posted by "John Huss (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAY-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Huss updated CAY-1637:
---------------------------

    Attachment: context-factory-patch.txt

Patch attached
                
> [PATCH] DataContextFactory is cumbersome to customize
> -----------------------------------------------------
>
>                 Key: CAY-1637
>                 URL: https://issues.apache.org/jira/browse/CAY-1637
>             Project: Cayenne
>          Issue Type: Improvement
>          Components: Core Library
>    Affects Versions: 3.1M4
>         Environment: Mac 10.6
>            Reporter: John Huss
>            Priority: Minor
>              Labels: patch
>         Attachments: context-factory-patch.txt
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> DataContextFactory is cumbersome to customize.  I want to use my own custom subclass of DataContext (which is probably the only customization ever needed, right?) and in order to do so I have to copy the complete source of DataContextFactory and replace DataContext with MyContext.  It can be made much easier by refactoring the constructor call into an overridable method that does just that.  CayenneContextFactory has the same problem.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (CAY-1637) [PATCH] DataContextFactory is cumbersome to customize

Posted by "Andrus Adamchik (Closed) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAY-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrus Adamchik closed CAY-1637.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 3.1M4

Thanks John. I applied the patch and committed to trunk.
                
> [PATCH] DataContextFactory is cumbersome to customize
> -----------------------------------------------------
>
>                 Key: CAY-1637
>                 URL: https://issues.apache.org/jira/browse/CAY-1637
>             Project: Cayenne
>          Issue Type: Improvement
>          Components: Core Library
>    Affects Versions: 3.1M4
>         Environment: Mac 10.6
>            Reporter: John Huss
>            Priority: Minor
>              Labels: patch
>             Fix For: 3.1M4
>
>         Attachments: context-factory-patch.txt
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> DataContextFactory is cumbersome to customize.  I want to use my own custom subclass of DataContext (which is probably the only customization ever needed, right?) and in order to do so I have to copy the complete source of DataContextFactory and replace DataContext with MyContext.  It can be made much easier by refactoring the constructor call into an overridable method that does just that.  CayenneContextFactory has the same problem.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira