[GitHub] [spark] panbingkun commented on a diff in pull request #41740: [SPARK-44208][CORE][SQL] Assign clear error class names for some logic that directly uses exceptions

["panbingkun (via GitHub)" <gi...@apache.org>]

panbingkun commented on code in PR #41740:
URL: https://github.com/apache/spark/pull/41740#discussion_r1246247122


##########
core/src/main/resources/error/error-classes.json:
##########
@@ -2264,6 +2284,23 @@
       "Attempted to unset non-existent properties [<properties>] in table <table>."
     ]
   },
+  "UNSUPPORTED_ADD_FILE" : {
+    "message" : [
+      "Don't support add file."
+    ],
+    "subClass" : {
+      "DIRECTORY" : {
+        "message" : [
+          "The file <path> is a directory, you must set \"spark.sql.legacy.addSingleFileInAddFile\" to \"false\"."
+        ]
+      },
+      "LOCAL_DIRECTORY" : {
+        "message" : [
+          "The file <path> is a local directory, but not running \"local mode\"."

Review Comment:
   I really like this change



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org