You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2020/01/14 03:18:44 UTC
[GitHub] [bookkeeper] rdhabalia opened a new pull request #2245:
[bookie-server-config] Avoid considering empty journalDirectories
rdhabalia opened a new pull request #2245: [bookie-server-config] Avoid considering empty journalDirectories
URL: https://github.com/apache/bookkeeper/pull/2245
As discussed at : https://github.com/apache/pulsar/issues/6042
### Issue
We have config management tool which manages bookie-server configuration and sets empty value of `journalDirectories` if bookie-server is still wants to use single journal dir: `journalDirectory`. In this case, bookie-server doesn't consider `journalDirectory` value and keeps empty list of `journalDirectories` which stats bookie with invalid configuration.
### Expected behavior
Bookie-server should parse empty configuration `journalDirectories=` properly and avoid picking up empty value of `journalDirectories` and in that case, bookie-server should fallback to `journalDirectory` config.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] rdhabalia commented on issue #2245:
[bookie-server-config] Avoid considering empty journalDirectories
Posted by GitBox <gi...@apache.org>.
rdhabalia commented on issue #2245: [bookie-server-config] Avoid considering empty journalDirectories
URL: https://github.com/apache/bookkeeper/pull/2245#issuecomment-578924120
run pr validation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] rdhabalia edited a comment on issue #2245:
[bookie-server-config] Avoid considering empty journalDirectories
Posted by GitBox <gi...@apache.org>.
rdhabalia edited a comment on issue #2245: [bookie-server-config] Avoid considering empty journalDirectories
URL: https://github.com/apache/bookkeeper/pull/2245#issuecomment-580004119
fixed in #2258
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] rdhabalia merged pull request #2245:
[bookie-server-config] Avoid considering empty journalDirectories
Posted by GitBox <gi...@apache.org>.
rdhabalia merged pull request #2245: [bookie-server-config] Avoid considering empty journalDirectories
URL: https://github.com/apache/bookkeeper/pull/2245
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] rdhabalia commented on issue #2245:
[bookie-server-config] Avoid considering empty journalDirectories
Posted by GitBox <gi...@apache.org>.
rdhabalia commented on issue #2245: [bookie-server-config] Avoid considering empty journalDirectories
URL: https://github.com/apache/bookkeeper/pull/2245#issuecomment-606823270
I see..thank you for sharing the info..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] rdhabalia commented on issue #2245:
[bookie-server-config] Avoid considering empty journalDirectories
Posted by GitBox <gi...@apache.org>.
rdhabalia commented on issue #2245: [bookie-server-config] Avoid considering empty journalDirectories
URL: https://github.com/apache/bookkeeper/pull/2245#issuecomment-598473696
can we retrigger this job..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] eolivelli commented on issue #2245:
[bookie-server-config] Avoid considering empty journalDirectories
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #2245: [bookie-server-config] Avoid considering empty journalDirectories
URL: https://github.com/apache/bookkeeper/pull/2245#issuecomment-606821744
You did it well.
You assigned correct labels.
Usually it is better to not self merge your own issues and let another fellow commiter to merge your patches. But there is no such strict rule it it only about community working.
The rules are: each patch must have two supporting committers. If the contributor is a committer you just only need another approval.
For big changes or changes to the public API we use to issue a BP (Bookkeeper Proposal) and discuss it before discussing the implementation.
It is good to have you on board!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] eolivelli commented on issue #2245:
[bookie-server-config] Avoid considering empty journalDirectories
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #2245: [bookie-server-config] Avoid considering empty journalDirectories
URL: https://github.com/apache/bookkeeper/pull/2245#issuecomment-606582907
All tests passed.
I will merge as soon as possible.
thank you @rdhabalia
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] rdhabalia commented on issue #2245:
[bookie-server-config] Avoid considering empty journalDirectories
Posted by GitBox <gi...@apache.org>.
rdhabalia commented on issue #2245: [bookie-server-config] Avoid considering empty journalDirectories
URL: https://github.com/apache/bookkeeper/pull/2245#issuecomment-580004119
fixed in #2151 2258
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] eolivelli commented on issue #2245:
[bookie-server-config] Avoid considering empty journalDirectories
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #2245: [bookie-server-config] Avoid considering empty journalDirectories
URL: https://github.com/apache/bookkeeper/pull/2245#issuecomment-593618695
@rdhabalia I have retriggered the integration tests suite.
I hope we can merge this patch soon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] sijie commented on issue #2245: [bookie-server-config]
Avoid considering empty journalDirectories
Posted by GitBox <gi...@apache.org>.
sijie commented on issue #2245: [bookie-server-config] Avoid considering empty journalDirectories
URL: https://github.com/apache/bookkeeper/pull/2245#issuecomment-580953869
@eolivelli @rdhabalia Github actions doesn't allow people without write permissions to trigger the actions. Even ASF has started disabling trigger phrases for Jenkins as well. I understand it is inconvenient for contributors. we can look into solutions to address them.
However, I think we have replied on trigger phrases too much in the past. These trigger phrases hide the problems in tests. We should start looking into how to make these tests reliable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] rdhabalia commented on issue #2245:
[bookie-server-config] Avoid considering empty journalDirectories
Posted by GitBox <gi...@apache.org>.
rdhabalia commented on issue #2245: [bookie-server-config] Avoid considering empty journalDirectories
URL: https://github.com/apache/bookkeeper/pull/2245#issuecomment-580542756
can we please retrigger the failed jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] rdhabalia commented on issue #2245:
[bookie-server-config] Avoid considering empty journalDirectories
Posted by GitBox <gi...@apache.org>.
rdhabalia commented on issue #2245: [bookie-server-config] Avoid considering empty journalDirectories
URL: https://github.com/apache/bookkeeper/pull/2245#issuecomment-606819383
@eolivelli
I just merged with `./dev/bk-merge-pr.py`, can you please let me know if anything I missed or should take care while merging PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] rdhabalia commented on issue #2245:
[bookie-server-config] Avoid considering empty journalDirectories
Posted by GitBox <gi...@apache.org>.
rdhabalia commented on issue #2245: [bookie-server-config] Avoid considering empty journalDirectories
URL: https://github.com/apache/bookkeeper/pull/2245#issuecomment-597278220
thanks @eolivelli , hopefully it passes once we retrigger the job again.. please let me know if you want me to rebase it with latest master changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] eolivelli commented on issue #2245:
[bookie-server-config] Avoid considering empty journalDirectories
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #2245: [bookie-server-config] Avoid considering empty journalDirectories
URL: https://github.com/apache/bookkeeper/pull/2245#issuecomment-603686554
@rdhabalia can you please take a look ?
Try to merge with current master.
Then I will be happy to merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] rdhabalia commented on issue #2245:
[bookie-server-config] Avoid considering empty journalDirectories
Posted by GitBox <gi...@apache.org>.
rdhabalia commented on issue #2245: [bookie-server-config] Avoid considering empty journalDirectories
URL: https://github.com/apache/bookkeeper/pull/2245#issuecomment-580925396
I can't trigger integration test failure with github action because I am not committer. So, is there any other way I can trigger this specific job? or can someone trigger it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] eolivelli commented on issue #2245:
[bookie-server-config] Avoid considering empty journalDirectories
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #2245: [bookie-server-config] Avoid considering empty journalDirectories
URL: https://github.com/apache/bookkeeper/pull/2245#issuecomment-580714150
@sijie
I have merged #2258 from @rdhabalia
now the master branch is in good same.
The error was not related to this patch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] rdhabalia opened a new pull request #2245:
[bookie-server-config] Avoid considering empty journalDirectories
Posted by GitBox <gi...@apache.org>.
rdhabalia opened a new pull request #2245: [bookie-server-config] Avoid considering empty journalDirectories
URL: https://github.com/apache/bookkeeper/pull/2245
As discussed at : https://github.com/apache/pulsar/issues/6042
### Issue
We have config management tool which manages bookie-server configuration and sets empty value of `journalDirectories` if bookie-server is still wants to use single journal dir: `journalDirectory`. In this case, bookie-server doesn't consider `journalDirectory` value and keeps empty list of `journalDirectories` which stats bookie with invalid configuration.
### Expected behavior
Bookie-server should parse empty configuration `journalDirectories=` properly and avoid picking up empty value of `journalDirectories` and in that case, bookie-server should fallback to `journalDirectory` config.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] rdhabalia closed pull request #2245:
[bookie-server-config] Avoid considering empty journalDirectories
Posted by GitBox <gi...@apache.org>.
rdhabalia closed pull request #2245: [bookie-server-config] Avoid considering empty journalDirectories
URL: https://github.com/apache/bookkeeper/pull/2245
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] eolivelli commented on issue #2245:
[bookie-server-config] Avoid considering empty journalDirectories
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #2245: [bookie-server-config] Avoid considering empty journalDirectories
URL: https://github.com/apache/bookkeeper/pull/2245#issuecomment-578833724
trying to close/repone in order to trigger CI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] eolivelli commented on issue #2245:
[bookie-server-config] Avoid considering empty journalDirectories
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #2245: [bookie-server-config] Avoid considering empty journalDirectories
URL: https://github.com/apache/bookkeeper/pull/2245#issuecomment-580952712
It is also unfortunate that I can't access github actions dashboard from mobile (I am most of the time of mobile)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] eolivelli commented on issue #2245:
[bookie-server-config] Avoid considering empty journalDirectories
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #2245: [bookie-server-config] Avoid considering empty journalDirectories
URL: https://github.com/apache/bookkeeper/pull/2245#issuecomment-598566807
It failed again
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] eolivelli commented on issue #2245:
[bookie-server-config] Avoid considering empty journalDirectories
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #2245: [bookie-server-config] Avoid considering empty journalDirectories
URL: https://github.com/apache/bookkeeper/pull/2245#issuecomment-580952471
@rdhabalia can you please tell about this problem on dev@ list ?
This way we can discuss with the community about how to find a solution
Meanwhile I will take care of kicking CI.
Are integration tests passing on your machine?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] rdhabalia opened a new pull request #2245:
[bookie-server-config] Avoid considering empty journalDirectories
Posted by GitBox <gi...@apache.org>.
rdhabalia opened a new pull request #2245: [bookie-server-config] Avoid considering empty journalDirectories
URL: https://github.com/apache/bookkeeper/pull/2245
As discussed at : https://github.com/apache/pulsar/issues/6042
### Issue
We have config management tool which manages bookie-server configuration and sets empty value of `journalDirectories` if bookie-server is still wants to use single journal dir: `journalDirectory`. In this case, bookie-server doesn't consider `journalDirectory` value and keeps empty list of `journalDirectories` which stats bookie with invalid configuration.
### Expected behavior
Bookie-server should parse empty configuration `journalDirectories=` properly and avoid picking up empty value of `journalDirectories` and in that case, bookie-server should fallback to `journalDirectory` config.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] eolivelli closed pull request #2245:
[bookie-server-config] Avoid considering empty journalDirectories
Posted by GitBox <gi...@apache.org>.
eolivelli closed pull request #2245: [bookie-server-config] Avoid considering empty journalDirectories
URL: https://github.com/apache/bookkeeper/pull/2245
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] eolivelli commented on issue #2245:
[bookie-server-config] Avoid considering empty journalDirectories
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #2245: [bookie-server-config] Avoid considering empty journalDirectories
URL: https://github.com/apache/bookkeeper/pull/2245#issuecomment-578532393
Why github actions did not trigger?
Btw we can merge this patch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] rdhabalia commented on issue #2245:
[bookie-server-config] Avoid considering empty journalDirectories
Posted by GitBox <gi...@apache.org>.
rdhabalia commented on issue #2245: [bookie-server-config] Avoid considering empty journalDirectories
URL: https://github.com/apache/bookkeeper/pull/2245#issuecomment-577929608
ping
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] rdhabalia closed pull request #2245:
[bookie-server-config] Avoid considering empty journalDirectories
Posted by GitBox <gi...@apache.org>.
rdhabalia closed pull request #2245: [bookie-server-config] Avoid considering empty journalDirectories
URL: https://github.com/apache/bookkeeper/pull/2245
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] rdhabalia edited a comment on issue #2245:
[bookie-server-config] Avoid considering empty journalDirectories
Posted by GitBox <gi...@apache.org>.
rdhabalia edited a comment on issue #2245: [bookie-server-config] Avoid considering empty journalDirectories
URL: https://github.com/apache/bookkeeper/pull/2245#issuecomment-580004119
fixed in #2151
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] eolivelli closed pull request #2245:
[bookie-server-config] Avoid considering empty journalDirectories
Posted by GitBox <gi...@apache.org>.
eolivelli closed pull request #2245: [bookie-server-config] Avoid considering empty journalDirectories
URL: https://github.com/apache/bookkeeper/pull/2245
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] sijie commented on issue #2245: [bookie-server-config]
Avoid considering empty journalDirectories
Posted by GitBox <gi...@apache.org>.
sijie commented on issue #2245: [bookie-server-config] Avoid considering empty journalDirectories
URL: https://github.com/apache/bookkeeper/pull/2245#issuecomment-580573621
@rdhabalia
```
[ERROR] src/main/java/org/apache/bookkeeper/stream/storage/impl/cluster/ZkClusterInitializer.java:[35] (imports) ImportOrder: Import org.apache.bookkeeper.stream.storage.StorageConstants.getSegmentsRootPath appears after other imports that it should precede
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.0.0:check (default-cli) on project stream-storage-service-impl: You have 1 Checkstyle violation. -> [Help 1]
[ERROR]
```
Are you able to check the results of github actions?
The PR validation failure doesn't seem to be not a flaky failure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] rdhabalia opened a new pull request #2245:
[bookie-server-config] Avoid considering empty journalDirectories
Posted by GitBox <gi...@apache.org>.
rdhabalia opened a new pull request #2245: [bookie-server-config] Avoid considering empty journalDirectories
URL: https://github.com/apache/bookkeeper/pull/2245
As discussed at : https://github.com/apache/pulsar/issues/6042
### Issue
We have config management tool which manages bookie-server configuration and sets empty value of `journalDirectories` if bookie-server is still wants to use single journal dir: `journalDirectory`. In this case, bookie-server doesn't consider `journalDirectory` value and keeps empty list of `journalDirectories` which stats bookie with invalid configuration.
### Expected behavior
Bookie-server should parse empty configuration `journalDirectories=` properly and avoid picking up empty value of `journalDirectories` and in that case, bookie-server should fallback to `journalDirectory` config.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] rdhabalia commented on issue #2245:
[bookie-server-config] Avoid considering empty journalDirectories
Posted by GitBox <gi...@apache.org>.
rdhabalia commented on issue #2245: [bookie-server-config] Avoid considering empty journalDirectories
URL: https://github.com/apache/bookkeeper/pull/2245#issuecomment-579992511
`PR Validation` build is failing with below exception:
```
[ERROR] src/main/java/org/apache/bookkeeper/stream/storage/impl/cluster/ZkClusterInitializer.java:[35] (imports) ImportOrder: Import org.apache.bookkeeper.stream.storage.StorageConstants.getSegmentsRootPath appears after other imports that it should precede
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.0.0:check (default-cli) on project stream-storage-service-impl: You have 1 Checkstyle violation. -> [Help 1]
```
There is no change for `ZkClusterInitializer` in the PR. So we know if it's a known issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] eolivelli removed a comment on issue #2245:
[bookie-server-config] Avoid considering empty journalDirectories
Posted by GitBox <gi...@apache.org>.
eolivelli removed a comment on issue #2245: [bookie-server-config] Avoid considering empty journalDirectories
URL: https://github.com/apache/bookkeeper/pull/2245#issuecomment-580952712
It is also unfortunate that I can't access github actions dashboard from mobile (I am most of the time of mobile)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] rdhabalia opened a new pull request #2245:
[bookie-server-config] Avoid considering empty journalDirectories
Posted by GitBox <gi...@apache.org>.
rdhabalia opened a new pull request #2245: [bookie-server-config] Avoid considering empty journalDirectories
URL: https://github.com/apache/bookkeeper/pull/2245
As discussed at : https://github.com/apache/pulsar/issues/6042
### Issue
We have config management tool which manages bookie-server configuration and sets empty value of `journalDirectories` if bookie-server is still wants to use single journal dir: `journalDirectory`. In this case, bookie-server doesn't consider `journalDirectory` value and keeps empty list of `journalDirectories` which stats bookie with invalid configuration.
### Expected behavior
Bookie-server should parse empty configuration `journalDirectories=` properly and avoid picking up empty value of `journalDirectories` and in that case, bookie-server should fallback to `journalDirectory` config.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] eolivelli commented on issue #2245:
[bookie-server-config] Avoid considering empty journalDirectories
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #2245: [bookie-server-config] Avoid considering empty journalDirectories
URL: https://github.com/apache/bookkeeper/pull/2245#issuecomment-598566709
Merging as soon as tests pass
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services