You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/22 17:26:04 UTC
[GitHub] [spark] kazuyukitanimura opened a new pull request, #37619: [SPARK-40088][SQL][TESTS] Add SparkPlanWIthAQESuite
kazuyukitanimura opened a new pull request, #37619:
URL: https://github.com/apache/spark/pull/37619
### What changes were proposed in this pull request?
This PR proposes to add `SparkPlanWithAQESuite` i.e. test cases of `SparkPlanSuite` with AQE (Adaptive Query Execution) turned on.
### Why are the changes needed?
Currently `SparkPlanSuite` assumes that AQE is always turned off. We should also test with AQE turned on
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Added an AQE version tests along with the non AQE version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kazuyukitanimura commented on pull request #37619: [SPARK-40088][SQL][TESTS] Add SparkPlanWithAQESuite
Posted by GitBox <gi...@apache.org>.
kazuyukitanimura commented on PR #37619:
URL: https://github.com/apache/spark/pull/37619#issuecomment-1223238429
Sorry style fixed and CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kazuyukitanimura commented on pull request #37619: [SPARK-40088][SQL][TESTS] Add SparkPlanWIthAQESuite
Posted by GitBox <gi...@apache.org>.
kazuyukitanimura commented on PR #37619:
URL: https://github.com/apache/spark/pull/37619#issuecomment-1222717975
Thank you all for the quick reviews!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #37619: [SPARK-40088][SQL][TESTS] Add SparkPlanWithAQESuite
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on PR #37619:
URL: https://github.com/apache/spark/pull/37619#issuecomment-1225087639
If we want to test AQE off for all test suites, can we add one more job in Github Action with AQE turned off?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kazuyukitanimura commented on pull request #37619: [SPARK-40088][SQL][TESTS] Add SparkPlanWithAQESuite
Posted by GitBox <gi...@apache.org>.
kazuyukitanimura commented on PR #37619:
URL: https://github.com/apache/spark/pull/37619#issuecomment-1225168794
Actually, there is only one more suite that fails with AQE force apply as far as I know. I don't think we need to test all suits with a separate Github Action.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #37619: [SPARK-40088][SQL][TESTS] Add SparkPlanWithAQESuite
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on PR #37619:
URL: https://github.com/apache/spark/pull/37619#issuecomment-1225207900
why do we care about AQE force apply? It's a testing feature and should never be enabled in production.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kazuyukitanimura commented on pull request #37619: [SPARK-40088][SQL][TESTS] Add SparkPlanWIthAQESuite
Posted by GitBox <gi...@apache.org>.
kazuyukitanimura commented on PR #37619:
URL: https://github.com/apache/spark/pull/37619#issuecomment-1222689274
cc @sunchao @viirya
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #37619: [SPARK-40088][SQL][TESTS] Add SparkPlanWithAQESuite
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #37619:
URL: https://github.com/apache/spark/pull/37619#issuecomment-1223288652
Thanks. Merging to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya closed pull request #37619: [SPARK-40088][SQL][TESTS] Add SparkPlanWithAQESuite
Posted by GitBox <gi...@apache.org>.
viirya closed pull request #37619: [SPARK-40088][SQL][TESTS] Add SparkPlanWithAQESuite
URL: https://github.com/apache/spark/pull/37619
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kazuyukitanimura commented on pull request #37619: [SPARK-40088][SQL][TESTS] Add SparkPlanWithAQESuite
Posted by GitBox <gi...@apache.org>.
kazuyukitanimura commented on PR #37619:
URL: https://github.com/apache/spark/pull/37619#issuecomment-1225164465
The intention is to add tests where that fails for AQE "force" apply on. I can add one more job ing Github Action with AQE force applied if it makes sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org