[GitHub] [incubator-druid] jihoonson commented on a change in pull request #7494: API to drop data by interval

[GitBox <gi...@apache.org>]

jihoonson commented on a change in pull request #7494: API to drop data by interval
URL: https://github.com/apache/incubator-druid/pull/7494#discussion_r278276598
 
 

 ##########
 File path: docs/content/operations/api-reference.md
 ##########
 @@ -230,6 +230,19 @@ Enables all segments of datasource which are not overshadowed by others.
 
 Enables a segment of a datasource.
 
+* `/druid/coordinator/v1/datasources/{dataSourceName}/markUnused`
 
 Review comment:
   Please add the below two things:
   
   - The segments would be disabled when this API is called, but then can be enabled by the coordinator if any loadRule matches.
   - If an indexing task was running which read the same segments at the same time, the behavior is undefined. All segments would be disabled but the indexing task can read data from those segments and succeed. Please add a warning as well to not use any indexing task and this API at the same time.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org